Remove duplicate read permission on default roles

This commit is contained in:
Carlos Monastyrski
2025-12-04 14:18:10 -03:00
parent 2b038575ad
commit 003aa1cd59
3 changed files with 6 additions and 6 deletions
@@ -109,8 +109,7 @@ const buildAdminPermissionRules = () => {
ProjectPermissionCertificateActions.Create, ProjectPermissionCertificateActions.Create,
ProjectPermissionCertificateActions.Delete, ProjectPermissionCertificateActions.Delete,
ProjectPermissionCertificateActions.ReadPrivateKey, ProjectPermissionCertificateActions.ReadPrivateKey,
ProjectPermissionCertificateActions.Import, ProjectPermissionCertificateActions.Import
ProjectPermissionCertificateActions.Read
], ],
ProjectPermissionSub.Certificates ProjectPermissionSub.Certificates
); );
@@ -484,8 +483,7 @@ const buildMemberPermissionRules = () => {
ProjectPermissionCertificateActions.Edit, ProjectPermissionCertificateActions.Edit,
ProjectPermissionCertificateActions.Create, ProjectPermissionCertificateActions.Create,
ProjectPermissionCertificateActions.Delete, ProjectPermissionCertificateActions.Delete,
ProjectPermissionCertificateActions.Import, ProjectPermissionCertificateActions.Import
ProjectPermissionCertificateActions.Read
], ],
ProjectPermissionSub.Certificates ProjectPermissionSub.Certificates
); );
@@ -7,6 +7,7 @@ import { TableName } from "@app/db/schemas";
import { getConfig } from "@app/lib/config/env"; import { getConfig } from "@app/lib/config/env";
import { crypto } from "@app/lib/crypto/cryptography"; import { crypto } from "@app/lib/crypto/cryptography";
import { BadRequestError, CryptographyError, NotFoundError } from "@app/lib/errors"; import { BadRequestError, CryptographyError, NotFoundError } from "@app/lib/errors";
import { PermissionFilters } from "@app/lib/knex/permission-filter-utils";
import { OrgServiceActor } from "@app/lib/types"; import { OrgServiceActor } from "@app/lib/types";
import { blockLocalAndPrivateIpAddresses } from "@app/lib/validator"; import { blockLocalAndPrivateIpAddresses } from "@app/lib/validator";
import { TAppConnectionDALFactory } from "@app/services/app-connection/app-connection-dal"; import { TAppConnectionDALFactory } from "@app/services/app-connection/app-connection-dal";
@@ -720,7 +721,7 @@ export const AcmeCertificateAuthorityFns = ({
permissionFilters permissionFilters
}: { }: {
projectId: string; projectId: string;
permissionFilters?: import("@app/lib/knex/permission-filter-utils").PermissionFilters; permissionFilters?: PermissionFilters;
}) => { }) => {
const cas = await certificateAuthorityDAL.findWithAssociatedCa( const cas = await certificateAuthorityDAL.findWithAssociatedCa(
{ {
@@ -5,6 +5,7 @@ import RE2 from "re2";
import { TableName } from "@app/db/schemas"; import { TableName } from "@app/db/schemas";
import { crypto } from "@app/lib/crypto/cryptography"; import { crypto } from "@app/lib/crypto/cryptography";
import { BadRequestError, NotFoundError } from "@app/lib/errors"; import { BadRequestError, NotFoundError } from "@app/lib/errors";
import { PermissionFilters } from "@app/lib/knex/permission-filter-utils";
import { ms } from "@app/lib/ms"; import { ms } from "@app/lib/ms";
import { OrgServiceActor } from "@app/lib/types"; import { OrgServiceActor } from "@app/lib/types";
import { TAppConnectionDALFactory } from "@app/services/app-connection/app-connection-dal"; import { TAppConnectionDALFactory } from "@app/services/app-connection/app-connection-dal";
@@ -803,7 +804,7 @@ export const AzureAdCsCertificateAuthorityFns = ({
permissionFilters permissionFilters
}: { }: {
projectId: string; projectId: string;
permissionFilters?: import("@app/lib/knex/permission-filter-utils").PermissionFilters; permissionFilters?: PermissionFilters;
}) => { }) => {
const cas = await certificateAuthorityDAL.findWithAssociatedCa( const cas = await certificateAuthorityDAL.findWithAssociatedCa(
{ {