From e7c5645aa970502191dd8a4faf8f59a0e7c80160 Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Fri, 24 May 2024 00:35:55 +0800
Subject: [PATCH] misc: made aws sm mapping one to one plaintext

---
 .../integration-sync-secret.ts                | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/backend/src/services/integration-auth/integration-sync-secret.ts b/backend/src/services/integration-auth/integration-sync-secret.ts
index 5c5500a69..40d51c81a 100644
--- a/backend/src/services/integration-auth/integration-sync-secret.ts
+++ b/backend/src/services/integration-auth/integration-sync-secret.ts
@@ -587,7 +587,10 @@ const syncSecretsAWSSecretManager = async ({
     }
   });
 
-  const processAwsSecret = async (secretId: string, keyValuePairs: Record<string, string | null | undefined>) => {
+  const processAwsSecret = async (
+    secretId: string,
+    secretValue: Record<string, string | null | undefined> | string
+  ) => {
     try {
       const awsSecretManagerSecret = await secretsManager.send(
         new GetSecretValueCommand({
@@ -595,17 +598,20 @@ const syncSecretsAWSSecretManager = async ({
         })
       );
 
-      let awsSecretManagerSecretObj: { [key: string]: AWS.SecretsManager } = {};
-
+      let secretToCompare;
       if (awsSecretManagerSecret?.SecretString) {
-        awsSecretManagerSecretObj = JSON.parse(awsSecretManagerSecret.SecretString);
+        if (typeof secretValue === "string") {
+          secretToCompare = awsSecretManagerSecret.SecretString;
+        } else {
+          secretToCompare = JSON.parse(awsSecretManagerSecret.SecretString);
+        }
       }
 
-      if (!isEqual(awsSecretManagerSecretObj, keyValuePairs)) {
+      if (!isEqual(secretToCompare, secretValue)) {
         await secretsManager.send(
           new UpdateSecretCommand({
             SecretId: secretId,
-            SecretString: JSON.stringify(keyValuePairs)
+            SecretString: typeof secretValue === "string" ? secretValue : JSON.stringify(secretValue)
           })
         );
       }
@@ -695,7 +701,7 @@ const syncSecretsAWSSecretManager = async ({
         await secretsManager.send(
           new CreateSecretCommand({
             Name: secretId,
-            SecretString: JSON.stringify(keyValuePairs),
+            SecretString: typeof secretValue === "string" ? secretValue : JSON.stringify(secretValue),
             ...(metadata.kmsKeyId && { KmsKeyId: metadata.kmsKeyId }),
             Tags: metadata.secretAWSTag
               ? metadata.secretAWSTag.map((tag: { key: string; value: string }) => ({ Key: tag.key, Value: tag.value }))
@@ -708,9 +714,7 @@ const syncSecretsAWSSecretManager = async ({
 
   if (metadata.mappingBehavior === IntegrationMappingBehavior.ONE_TO_ONE) {
     for await (const [key, value] of Object.entries(secrets)) {
-      await processAwsSecret(key, {
-        [key]: value.value
-      });
+      await processAwsSecret(key, value.value);
     }
   } else {
     await processAwsSecret(integration.app as string, getSecretKeyValuePair(secrets));