fix: review comments

This commit is contained in:
Piyush Gupta
2025-10-16 00:49:15 +05:30
parent 846403d424
commit 069241dbbc
7 changed files with 12 additions and 11 deletions
@@ -148,7 +148,7 @@ export const listLaravelForgeServers = async (
export const listLaravelForgeSites = async (
appConnection: TLaravelForgeConnection,
organizationSlug: string,
serverId: number
serverId: string
): Promise<TLaravelForgeSite[]> => {
const { credentials } = appConnection;
const { apiToken } = credentials;
@@ -54,7 +54,7 @@ export const laravelForgeConnectionService = (getAppConnection: TGetAppConnectio
connectionId: string,
actor: OrgServiceActor,
organizationSlug: string,
serverId: number
serverId: string
): Promise<TLaravelForgeSite[]> => {
const appConnection = await getAppConnection(AppConnection.LaravelForge, connectionId, actor);
try {
@@ -26,9 +26,10 @@ const LaravelForgeSyncDestinationConfigSchema = z.object({
)
.describe(SecretSyncs.DESTINATION_CONFIG.LARAVEL_FORGE.orgSlug),
orgName: z.string().optional().describe(SecretSyncs.DESTINATION_CONFIG.LARAVEL_FORGE.orgName),
serverId: z.coerce
.number()
.int("Server ID must be a valid integer")
serverId: z
.string()
.min(1, "Server ID is required")
.regex(/^\d+$/, "Server ID must be a valid integer")
.describe(SecretSyncs.DESTINATION_CONFIG.LARAVEL_FORGE.serverId),
serverName: z.string().optional().describe(SecretSyncs.DESTINATION_CONFIG.LARAVEL_FORGE.serverName),
siteId: z.string().min(1, "Site ID is required").describe(SecretSyncs.DESTINATION_CONFIG.LARAVEL_FORGE.siteId),
@@ -21,7 +21,7 @@ export type TLaravelForgeSyncWithCredentials = TLaravelForgeSync & {
export type TGetLaravelForgeSecrets = {
apiToken: string;
orgSlug: string;
serverId: number;
serverId: string;
siteId: string;
};