From 06c103c10af0ec6a150ae29303695d5a53e26d49 Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Tue, 7 May 2024 22:19:20 +0800
Subject: [PATCH] misc: added handling for no changes made

---
 .../components/SelectionPanel/SelectionPanel.tsx     | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/frontend/src/views/SecretOverviewPage/components/SelectionPanel/SelectionPanel.tsx b/frontend/src/views/SecretOverviewPage/components/SelectionPanel/SelectionPanel.tsx
index 03d2d44be..4f331e989 100644
--- a/frontend/src/views/SecretOverviewPage/components/SelectionPanel/SelectionPanel.tsx
+++ b/frontend/src/views/SecretOverviewPage/components/SelectionPanel/SelectionPanel.tsx
@@ -52,6 +52,8 @@ export const SelectionPanel = ({ getFolderByNameAndEnv, getSecretByKey, secretPa
   );
 
   const handleBulkDelete = async () => {
+    let processedEntries = 0;
+
     const promises = userAvailableEnvs.map(async (env) => {
       // additional check: ensure that bulk delete is only executed on envs that user has access to
       if (
@@ -67,6 +69,7 @@ export const SelectionPanel = ({ getFolderByNameAndEnv, getSecretByKey, secretPa
         Object.keys(selectedEntries.folder).map(async (folderName) => {
           const folder = getFolderByNameAndEnv(folderName, env.slug);
           if (folder) {
+            processedEntries += 1;
             await deleteFolder({
               folderId: folder?.id,
               path: secretPath,
@@ -95,6 +98,7 @@ export const SelectionPanel = ({ getFolderByNameAndEnv, getSecretByKey, secretPa
       );
 
       if (secretsToDelete.length > 0) {
+        processedEntries += secretsToDelete.length;
         await deleteBatchSecretV3({
           secretPath,
           workspaceId,
@@ -106,7 +110,13 @@ export const SelectionPanel = ({ getFolderByNameAndEnv, getSecretByKey, secretPa
 
     const results = await Promise.allSettled(promises);
     const areEntriesDeleted = results.some((result) => result.status === "fulfilled");
-    if (areEntriesDeleted) {
+    if (processedEntries === 0) {
+      handlePopUpClose("bulkDeleteEntries");
+      createNotification({
+        type: "info",
+        text: "No changes have been made. Ensure that you have sufficient access."
+      });
+    } else if (areEntriesDeleted) {
       handlePopUpClose("bulkDeleteEntries");
       resetSelectedEntries();
       createNotification({