awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 07:26:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve requestEmailChangeOTP await logic

Browse Source
This commit is contained in:
Carlos Monastyrski
2025-09-11 11:44:16 -03:00
parent 0d15a03ebb
commit 08de78417a
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/user/user-service.ts
+9 -10
View File
@@ -196,8 +196,8 @@ export const userServiceFactory = ({
}; };
const requestEmailChangeOTP = async ({ userId, newEmail }: TUpdateUserEmailDTO) => { const requestEmailChangeOTP = async ({ userId, newEmail }: TUpdateUserEmailDTO) => {
const startTime = new Date();
const changeEmailOTP = await userDAL.transaction(async (tx) => { const changeEmailOTP = await userDAL.transaction(async (tx) => {
const startTime = new Date();
const user = await userDAL.findById(userId, tx); const user = await userDAL.findById(userId, tx);
if (!user) if (!user)
throw new NotFoundError({ message: `User with ID '${userId}' not found`, name: "RequestEmailChangeOTP" }); throw new NotFoundError({ message: `User with ID '${userId}' not found`, name: "RequestEmailChangeOTP" });
@@ -236,17 +236,16 @@ export const userServiceFactory = ({
}); });
} }
// Force this function to have a minimum execution time of 2 seconds to avoid possible information disclosure about existing users
const endTime = new Date();
const timeDiff = endTime.getTime() - startTime.getTime();
if (timeDiff < 2000) {
await new Promise((resolve) => {
setTimeout(resolve, 2000 - timeDiff);
});
}
return { success: true, message: "Verification code sent to new email address" }; return { success: true, message: "Verification code sent to new email address" };
}); });
// Force this function to have a minimum execution time of 2 seconds to avoid possible information disclosure about existing users
const endTime = new Date();
const timeDiff = endTime.getTime() - startTime.getTime();
if (timeDiff < 2000) {
await new Promise((resolve) => {
setTimeout(resolve, 2000 - timeDiff);
});
}
return changeEmailOTP; return changeEmailOTP;
}; };