feat: lint and finally completed

backend/src/services/role/org/org-role-factory.ts

@@ -10,9 +10,9 @@ import {
 } from "@app/ee/services/permission/org-permission";
 import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
 import { BadRequestError } from "@app/lib/errors";
+import { isCustomOrgRole } from "@app/services/org/org-role-fns";
 
 import { TRoleScopeFactory } from "../role-types";
-import { isCustomOrgRole } from "@app/services/org/org-role-fns";
 
 // TODO(simp): missing external group checking
 type TOrgRoleScopeFactoryDep = {

backend/src/services/role/project/project-role-factory.ts

@@ -1,16 +1,7 @@
-import { v4 as uuidv4 } from "uuid";
 import { ForbiddenError } from "@casl/ability";
+import { v4 as uuidv4 } from "uuid";
 
 import { AccessScope, ActionProjectType, ProjectMembershipRole, ProjectType } from "@app/db/schemas";
-import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
-import {
-  isCustomProjectRole,
-  ProjectPermissionActions,
-  ProjectPermissionSub
-} from "@app/ee/services/permission/project-permission";
-import { BadRequestError } from "@app/lib/errors";
-
-import { TRoleScopeFactory } from "../role-types";
 import {
   cryptographicOperatorPermissions,
   projectAdminPermissions,
@@ -19,8 +10,17 @@ import {
   projectViewerPermission,
   sshHostBootstrapPermissions
 } from "@app/ee/services/permission/default-roles";
+import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
+import {
+  isCustomProjectRole,
+  ProjectPermissionActions,
+  ProjectPermissionSub
+} from "@app/ee/services/permission/project-permission";
+import { BadRequestError } from "@app/lib/errors";
 import { TProjectDALFactory } from "@app/services/project/project-dal";
 
+import { TRoleScopeFactory } from "../role-types";
+
 type TProjectRoleScopeFactoryDep = {
   permissionService: Pick<TPermissionServiceFactory, "getProjectPermission">;
   projectDAL: Pick<TProjectDALFactory, "findById">;

backend/src/services/role/role-service.ts

@@ -1,9 +1,16 @@
+import { packRules } from "@casl/ability/extra";
+import { requestContext } from "@fastify/request-context";
+
 import { AccessScope, ActionProjectType, TableName } from "@app/db/schemas";
 import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
 import { BadRequestError, NotFoundError } from "@app/lib/errors";
 import { validateHandlebarTemplate } from "@app/lib/template/validate-handlebars";
 import { UnpackedPermissionSchema, unpackPermissions } from "@app/server/routes/sanitizedSchema/permission";
 
+import { ActorType } from "../auth/auth-type";
+import { TIdentityDALFactory } from "../identity/identity-dal";
+import { TProjectDALFactory } from "../project/project-dal";
+import { TUserDALFactory } from "../user/user-dal";
 import { newNamespaceRoleFactory } from "./namespace/namespace-role-factory";
 import { newOrgRoleFactory } from "./org/org-role-factory";
 import { newProjectRoleFactory } from "./project/project-role-factory";
@@ -17,12 +24,6 @@ import {
   TListRoleDTO,
   TUpdateRoleDTO
 } from "./role-types";
-import { TProjectDALFactory } from "../project/project-dal";
-import { packRules } from "@casl/ability/extra";
-import { requestContext } from "@fastify/request-context";
-import { TIdentityDALFactory } from "../identity/identity-dal";
-import { TUserDALFactory } from "../user/user-dal";
-import { ActorType } from "../auth/auth-type";
 
 type TRoleServiceFactoryDep = {
   roleDAL: TRoleDALFactory;

backend/src/services/role/role-types.ts

@@ -1,6 +1,7 @@
+import { MongoAbility, RawRuleOf } from "@casl/ability";
+
 import { AccessScopeData, TRoles } from "@app/db/schemas";
 import { OrgServiceActor } from "@app/lib/types";
-import { MongoAbility, RawRuleOf } from "@casl/ability";
 
 export interface TRoleScopeFactory {
   onCreateRoleGuard: (arg: TCreateRoleDTO) => Promise<void>;