Merge pull request #3673 from Infisical/check-for-recipients-on-project-access

Fix(org-admin-project-access): Check for recipients prior to sending project access email
This commit is contained in:
Scott Wilson
2025-06-02 07:05:53 -07:00
committed by GitHub
@@ -196,17 +196,20 @@ export const orgAdminServiceFactory = ({
.filter( .filter(
(member) => member.roles.some((role) => role.role === ProjectMembershipRole.Admin) && member.userId !== actorId (member) => member.roles.some((role) => role.role === ProjectMembershipRole.Admin) && member.userId !== actorId
) )
.map((el) => el.user.email!); .map((el) => el.user.email!)
.filter(Boolean);
await smtpService.sendMail({ if (filteredProjectMembers.length) {
template: SmtpTemplates.OrgAdminProjectDirectAccess, await smtpService.sendMail({
recipients: filteredProjectMembers, template: SmtpTemplates.OrgAdminProjectDirectAccess,
subjectLine: "Organization Admin Project Direct Access Issued", recipients: filteredProjectMembers,
substitutions: { subjectLine: "Organization Admin Project Direct Access Issued",
projectName: project.name, substitutions: {
email: projectMembers.find((el) => el.userId === actorId)?.user?.username projectName: project.name,
} email: projectMembers.find((el) => el.userId === actorId)?.user?.username
}); }
});
}
return { isExistingMember: false, membership: updatedMembership }; return { isExistingMember: false, membership: updatedMembership };
}; };