awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 22:27:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better error handling

Browse Source
This commit is contained in:
Fang-Pen Lin
2025-11-07 09:19:43 -08:00
parent 7edde54281
commit 181faff20b
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/pki-acme/pki-acme-challenge-service.ts
+15 -7
View File
@@ -77,13 +77,21 @@ export const pkiAcmeChallengeServiceFactory = ({
await acmeChallengeDAL.markAsInvalidCascadeById(challengeId, tx); await acmeChallengeDAL.markAsInvalidCascadeById(challengeId, tx);
// Properly type and inspect the error // Properly type and inspect the error
if (error instanceof TypeError && error.message.includes("fetch failed")) { if (error instanceof TypeError && error.message.includes("fetch failed")) {
const cause = error.cause as AggregateError; const cause = error.cause;
if (cause?.errors?.[0]?.code === "ECONNREFUSED") { if (cause instanceof Error) {
logger.error(error, "Connection refused."); if (cause.message.includes("ECONNREFUSED")) {
return new AcmeConnectionError({ message: "Connection refused." }); return new AcmeConnectionError({ message: "Connection refused" });
} else if (cause?.errors?.[0]?.code === "ENOTFOUND") { } else if (cause.message.includes("ENOTFOUND")) {
logger.error(error, "Hostname could not be resolved (DNS failure)."); return new AcmeDnsFailureError({ message: "Hostname could not be resolved (DNS failure)" });
return new AcmeDnsFailureError({ message: "Hostname could not be resolved (DNS failure)." }); }
} else if (cause instanceof AggregateError) {
// TODO: handle multiple errors
const firstError = cause.errors?.[0];
if (firstError?.code === "ECONNREFUSED") {
return new AcmeConnectionError({ message: "Connection refused" });
} else if (firstError?.code === "ENOTFOUND") {
return new AcmeDnsFailureError({ message: "Hostname could not be resolved (DNS failure)" });
}
} }
} else if (error instanceof Error) { } else if (error instanceof Error) {
logger.error(error, "Error validating ACME challenge response"); logger.error(error, "Error validating ACME challenge response");