awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-08 15:28:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2192 from GLEF1X/perf/optimize-group-delete

Browse Source 
perf(group-fns): optimize sequential delete to be concurrent
This commit is contained in:
Maidul Islam
2024-07-29 22:13:00 -04:00
committed by GitHub
parent 1d97921c7c 98b6373d6a
commit 1c8299054a
1 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/group/group-fns.ts
+7 -2
View File
@@ -336,8 +336,10 @@ export const removeUsersFromGroupByUserIds = async ({
) )
); );
// TODO: this part can be optimized const promises: Array<Promise<void>> = [];
for await (const userId of userIds) { for (const userId of userIds) {
promises.push(
(async () => {
const t = await userGroupMembershipDAL.filterProjectsByUserMembership(userId, group.id, projectIds, tx); const t = await userGroupMembershipDAL.filterProjectsByUserMembership(userId, group.id, projectIds, tx);
const projectsToDeleteKeyFor = projectIds.filter((p) => !t.has(p)); const projectsToDeleteKeyFor = projectIds.filter((p) => !t.has(p));
@@ -360,7 +362,10 @@ export const removeUsersFromGroupByUserIds = async ({
}, },
tx tx
); );
})()
);
} }
await Promise.all(promises);
} }
if (membersToRemoveFromGroupPending.length) { if (membersToRemoveFromGroupPending.length) {