From 1d09d4cdfdbe90517219542ba3b6fac24a46735e Mon Sep 17 00:00:00 2001
From: = <akhilmhdh@gmail.com>
Date: Fri, 26 Jul 2024 23:44:28 +0530
Subject: [PATCH] feat: resolved a edge case on snapshot based secret version
 insertion due to missing snapshots in some parts

---
 backend/src/services/secret/secret-queue.ts | 56 +++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/backend/src/services/secret/secret-queue.ts b/backend/src/services/secret/secret-queue.ts
index f04055dc4..0fbce0964 100644
--- a/backend/src/services/secret/secret-queue.ts
+++ b/backend/src/services/secret/secret-queue.ts
@@ -946,6 +946,62 @@ export const secretQueueFactory = ({
             });
           });
         });
+        // this is corner case in which some times the snapshot may not have the secret version of an existing secret
+        // example: on some integration it will pull values from 3rd party on integration but snapshot is not taken
+        // Thus it won't have secret version
+        const latestSecretVersionByFolder = await secretVersionDAL.findLatestVersionMany(
+          folderId,
+          projectV1Secrets.map((el) => el.id),
+          tx
+        );
+        Object.values(latestSecretVersionByFolder).forEach((el) => {
+          if (projectV3SecretVersionsGroupById[el.id]) return;
+          const key = decryptSymmetric128BitHexKeyUTF8({
+            ciphertext: el.secretKeyCiphertext,
+            iv: el.secretKeyIV,
+            tag: el.secretKeyTag,
+            key: botKey
+          });
+          const value = decryptSymmetric128BitHexKeyUTF8({
+            ciphertext: el.secretValueCiphertext,
+            iv: el.secretValueIV,
+            tag: el.secretValueTag,
+            key: botKey
+          });
+          const comment =
+            el.secretCommentCiphertext && el.secretCommentTag && el.secretCommentIV
+              ? decryptSymmetric128BitHexKeyUTF8({
+                  ciphertext: el.secretCommentCiphertext,
+                  iv: el.secretCommentIV,
+                  tag: el.secretCommentTag,
+                  key: botKey
+                })
+              : "";
+          const encryptedValue = secretManagerEncryptor({ plainText: Buffer.from(value) }).cipherTextBlob;
+
+          const encryptedComment = comment
+            ? secretManagerEncryptor({ plainText: Buffer.from(comment) }).cipherTextBlob
+            : null;
+          projectV3SecretVersionsGroupById[el.id] = {
+            id: el.id,
+            createdAt: el.createdAt,
+            updatedAt: el.updatedAt,
+            skipMultilineEncoding: el.skipMultilineEncoding,
+            encryptedComment,
+            encryptedValue,
+            key,
+            version: el.version,
+            type: el.type,
+            userId: el.userId,
+            folderId: el.folderId,
+            metadata: el.metadata,
+            reminderNote: el.secretReminderNote,
+            reminderRepeatDays: el.secretReminderRepeatDays,
+            secretId: el.secretId,
+            envId: el.envId
+          };
+        });
+
         const projectV3SecretVersions = Object.values(projectV3SecretVersionsGroupById);
         if (projectV3SecretVersions.length) {
           await secretVersionV2BridgeDAL.insertMany(projectV3SecretVersions, tx);