mirror of
https://github.com/awatertrevi/infisical.git
synced 2026-10-11 11:29:21 +00:00
improvements: address feedback
This commit is contained in:
@@ -222,7 +222,7 @@ export const AsExternalLink: Story = {
|
||||
variant: "info",
|
||||
asChild: true,
|
||||
children: (
|
||||
<a href="https://infisical.com/">
|
||||
<a target="_blank" rel="noopener noreferrer" href="https://infisical.com/">
|
||||
Link <ExternalLinkIcon />
|
||||
</a>
|
||||
)
|
||||
@@ -263,7 +263,7 @@ export const AsButton: Story = {
|
||||
variant: "org",
|
||||
asChild: true,
|
||||
children: (
|
||||
<button type="button" onClick={() => alert("button clicked")}>
|
||||
<button type="button" onClick={() => console.log("click")}>
|
||||
<GlobeIcon />
|
||||
Organization
|
||||
<ChevronsUpDownIcon />
|
||||
|
||||
@@ -39,7 +39,7 @@ type TBadgeProps = VariantProps<typeof badgeVariants> &
|
||||
asChild?: boolean;
|
||||
};
|
||||
|
||||
const Badge = forwardRef<HTMLButtonElement | HTMLSpanElement | HTMLAnchorElement, TBadgeProps>(
|
||||
const Badge = forwardRef<HTMLSpanElement, TBadgeProps>(
|
||||
({ className, variant, asChild = false, isTruncatable = false, ...props }, ref): JSX.Element => {
|
||||
const Comp = asChild ? Slot : "span";
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user