improvements: address feedback

This commit is contained in:
Scott Wilson
2025-10-23 13:02:26 -07:00
parent 7034cac367
commit 2081cd9585
7 changed files with 29 additions and 25 deletions
@@ -222,7 +222,7 @@ export const AsExternalLink: Story = {
variant: "info",
asChild: true,
children: (
<a href="https://infisical.com/">
<a target="_blank" rel="noopener noreferrer" href="https://infisical.com/">
Link <ExternalLinkIcon />
</a>
)
@@ -263,7 +263,7 @@ export const AsButton: Story = {
variant: "org",
asChild: true,
children: (
<button type="button" onClick={() => alert("button clicked")}>
<button type="button" onClick={() => console.log("click")}>
<GlobeIcon />
Organization
<ChevronsUpDownIcon />
@@ -39,7 +39,7 @@ type TBadgeProps = VariantProps<typeof badgeVariants> &
asChild?: boolean;
};
const Badge = forwardRef<HTMLButtonElement | HTMLSpanElement | HTMLAnchorElement, TBadgeProps>(
const Badge = forwardRef<HTMLSpanElement, TBadgeProps>(
({ className, variant, asChild = false, isTruncatable = false, ...props }, ref): JSX.Element => {
const Comp = asChild ? Slot : "span";
return (