Address greptile comments

This commit is contained in:
Carlos Monastyrski
2025-11-06 03:28:21 -03:00
parent 33617dbaa7
commit 208ba59e65
8 changed files with 49 additions and 58 deletions

View File

@@ -181,7 +181,8 @@ export const createPkiAlertV2Schema = z.object({
eventType: z.nativeEnum(PkiAlertEventTypeV2),
alertBefore: z
.string()
.regex(/^\d+[dwmy]$/)
.regex(/^\d+[dwmy]$/, "Must be in format like '30d', '1w', '3m', '1y'")
.refine((val) => val.length <= 32, "Alert timing too long")
.optional(),
filters: z.array(pkiFilterRuleV2Schema),
enabled: z.boolean().default(true),

View File

@@ -249,7 +249,7 @@ export const CreatePkiAlertV2FormSteps = () => {
{watchedFilters?.map((filter, index) => (
<div
key={`filter-${filter.field}-${filter.operator}-${String(filter.value)}-${index}`}
key={`filter-${index}`}
className="space-y-2 rounded-md border border-mineshaft-600 p-3"
>
<div className="flex items-center justify-between">
@@ -551,10 +551,7 @@ export const CreatePkiAlertV2FormSteps = () => {
<div className="flex flex-wrap gap-x-8 gap-y-2">
{watchedFilters && watchedFilters.length > 0 ? (
watchedFilters.map((filter, index) => (
<GenericFieldLabel
key={`review-filter-${filter.field}-${filter.operator}-${String(filter.value)}-${index}`}
label={`Rule ${index + 1}`}
>
<GenericFieldLabel key={`review-filter-${index}`} label={`Rule ${index + 1}`}>
<span className="font-mono text-xs">
{filter.field
.replace(/_/g, " ")