Update permission logic

backend/src/ee/services/permission/project-permission.ts

@@ -68,7 +68,6 @@ export enum ProjectPermissionGroupActions {
 }
 
 export enum ProjectPermissionSshHostActions {
-  Read = "read",
   Create = "create",
   Edit = "edit",
   Delete = "delete",
@@ -629,7 +628,6 @@ const buildAdminPermissionRules = () => {
 
   can(
     [
-      ProjectPermissionSshHostActions.Read,
       ProjectPermissionSshHostActions.Edit,
       ProjectPermissionSshHostActions.Create,
       ProjectPermissionSshHostActions.Delete,

backend/src/ee/services/ssh-host/ssh-host-service.ts

@@ -337,7 +337,7 @@ export const sshHostServiceFactory = ({
       });
     }
 
-    const { permission } = await permissionService.getProjectPermission({
+    await permissionService.getProjectPermission({
       actor,
       actorId,
       projectId: host.projectId,
@@ -346,13 +346,6 @@ export const sshHostServiceFactory = ({
       actionProjectType: ActionProjectType.SSH
     });
 
-    ForbiddenError.from(permission).throwUnlessCan(
-      ProjectPermissionSshHostActions.Read,
-      subject(ProjectPermissionSub.SshHosts, {
-        hostname: host.hostname
-      })
-    );
-
     return host;
   };
 

backend/src/services/project/project-service.ts

@@ -1068,8 +1068,7 @@ export const projectServiceFactory = ({
     actor,
     projectId
   }: TListProjectSshHostsDTO) => {
-    console.log("listProjectSshHosts: ", actor, actorId, actorAuthMethod, actorOrgId, projectId);
-    const { permission } = await permissionService.getProjectPermission({
+    await permissionService.getProjectPermission({
       actor,
       actorId,
       projectId,
@@ -1078,10 +1077,7 @@ export const projectServiceFactory = ({
       actionProjectType: ActionProjectType.SSH
     });
 
-    ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.SshHosts);
-
     const hosts = await sshHostDAL.findSshHostsWithLoginMappings(projectId);
-
     return hosts;
   };