From d7271b9631334d43bae37020cfc9fc3e3df5864d Mon Sep 17 00:00:00 2001
From: Pranav2612000 <pranav2000joglekar@gmail.com>
Date: Tue, 17 Dec 2024 18:49:12 +0530
Subject: [PATCH 1/2] improv ui: use radix modal mode for Modals

Using the modal mode ensures that interaction with outside elements
is disabled ( for e.g scroll ) and only dialog content is visible to
screen readers.
---
 frontend/src/components/v2/Modal/Modal.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/v2/Modal/Modal.tsx b/frontend/src/components/v2/Modal/Modal.tsx
index a741d6d02..2e216ba08 100644
--- a/frontend/src/components/v2/Modal/Modal.tsx
+++ b/frontend/src/components/v2/Modal/Modal.tsx
@@ -72,7 +72,7 @@ ModalContent.displayName = "ModalContent";
 
 export type ModalProps = Omit<DialogPrimitive.DialogProps, "open"> & { isOpen?: boolean };
 export const Modal = ({ isOpen, ...props }: ModalProps) => (
-  <DialogPrimitive.Root open={isOpen} {...props} />
+  <DialogPrimitive.Root open={isOpen} {...props} modal/>
 );
 
 export const ModalTrigger = DialogPrimitive.Trigger;

From 6a681dcf6aa5f1ed13184b329dd30dba3930e695 Mon Sep 17 00:00:00 2001
From: Pranav2612000 <pranav2000joglekar@gmail.com>
Date: Tue, 17 Dec 2024 18:51:47 +0530
Subject: [PATCH 2/2] improv ux: don't close 'Create secrets' modal when
 clicking outside it

Fixes #2845
---
 frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx b/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
index 1162485cf..eee9adfee 100644
--- a/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
+++ b/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
@@ -1125,6 +1125,7 @@ export const SecretOverviewPage = () => {
           bodyClassName="overflow-visible"
           title="Create Secrets"
           subTitle="Create a secret across multiple environments"
+          onPointerDownOutside={(e) => e.preventDefault()}
         >
           <CreateSecretForm
             secretPath={secretPath}