From 2273c21eb26c49a3e782378bf8c455e5eaa4c0aa Mon Sep 17 00:00:00 2001 From: Tuan Dang Date: Wed, 2 Oct 2024 09:10:22 -0400 Subject: [PATCH] Clean PR --- backend/src/server/routes/v1/secret-sharing-router.ts | 2 +- .../src/services/secret-sharing/secret-sharing-service.ts | 5 ----- .../src/views/ViewSecretPublicPage/ViewSecretPublicPage.tsx | 3 --- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/backend/src/server/routes/v1/secret-sharing-router.ts b/backend/src/server/routes/v1/secret-sharing-router.ts index fa4e9bf6a..3363cc6c0 100644 --- a/backend/src/server/routes/v1/secret-sharing-router.ts +++ b/backend/src/server/routes/v1/secret-sharing-router.ts @@ -100,7 +100,7 @@ export const registerSecretSharingRouter = async (server: FastifyZodProvider) => }, schema: { body: z.object({ - secretValue: z.string(), + secretValue: z.string().max(10_000), password: z.string().optional(), expiresAt: z.string(), expiresAfterViews: z.number().min(1).optional() diff --git a/backend/src/services/secret-sharing/secret-sharing-service.ts b/backend/src/services/secret-sharing/secret-sharing-service.ts index b427844d0..0f7ee20b4 100644 --- a/backend/src/services/secret-sharing/secret-sharing-service.ts +++ b/backend/src/services/secret-sharing/secret-sharing-service.ts @@ -114,11 +114,6 @@ export const secretSharingServiceFactory = ({ throw new BadRequestError({ message: "Expiration date cannot exceed more than 30 days" }); } - // Limit Input ciphertext length to 13000 (equivalent to 10,000 characters of Plaintext)n - if (secretValue.length > 10_000) { - throw new BadRequestError({ message: "Shared secret value too long" }); - } - const encryptWithRoot = kmsService.encryptWithRootKey(); const encryptedSecret = encryptWithRoot(Buffer.from(secretValue)); diff --git a/frontend/src/views/ViewSecretPublicPage/ViewSecretPublicPage.tsx b/frontend/src/views/ViewSecretPublicPage/ViewSecretPublicPage.tsx index 95475ad4a..cc2cc16ba 100644 --- a/frontend/src/views/ViewSecretPublicPage/ViewSecretPublicPage.tsx +++ b/frontend/src/views/ViewSecretPublicPage/ViewSecretPublicPage.tsx @@ -53,9 +53,6 @@ export const ViewSecretPublicPage = () => { ((error as AxiosError)?.response?.data as { message: string })?.message === "Invalid credentials"; - console.log("data", fetchSecret); - console.log("err", error); - const shouldShowPasswordPrompt = isInvalidCredential || (fetchSecret?.isPasswordProtected && !fetchSecret.secret); const isValidatingPassword = Boolean(password) && isFetching;