From 22d6aa8e460031a6f1a0831e4ba4a33de029e828 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?H=C3=BCseyin=20Berke=20B=C3=BCt=C3=BCn?=
 <8071263+Zamion101@users.noreply.github.com>
Date: Sat, 24 Dec 2022 21:45:53 +0100
Subject: [PATCH] fix: Fixed wrong naming for error handler middleware

---
 backend/src/app.ts                                           | 5 +++--
 .../{catchUnroutedRequests.ts => requestErrorHandler.ts}     | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
 rename backend/src/middleware/{catchUnroutedRequests.ts => requestErrorHandler.ts} (92%)

diff --git a/backend/src/app.ts b/backend/src/app.ts
index d00a02283..af88105fd 100644
--- a/backend/src/app.ts
+++ b/backend/src/app.ts
@@ -29,8 +29,9 @@ import {
   integrationAuth as integrationAuthRouter
 } from './routes';
 import { getLogger } from './utils/logger';
-import { catchUnroutedRequests } from './middleware/catchUnroutedRequests';
 import { RouteNotFoundError } from './utils/errors';
+import { errorHandler } from '@sentry/node/types/handlers';
+import { requestErrorHandler } from './middleware/requestErrorHandler';
 
 export const app = express();
 
@@ -80,7 +81,7 @@ app.use((req, res, next)=>{
 })
 
 //* Error Handling Middleware (must be after all routing logic)
-app.use(catchUnroutedRequests)
+app.use(requestErrorHandler)
 
 
 export const server = app.listen(PORT, () => {
diff --git a/backend/src/middleware/catchUnroutedRequests.ts b/backend/src/middleware/requestErrorHandler.ts
similarity index 92%
rename from backend/src/middleware/catchUnroutedRequests.ts
rename to backend/src/middleware/requestErrorHandler.ts
index 55c2e9001..36f1dce49 100644
--- a/backend/src/middleware/catchUnroutedRequests.ts
+++ b/backend/src/middleware/requestErrorHandler.ts
@@ -6,7 +6,7 @@ import { getLogger } from "../utils/logger";
 import RequestError, { LogLevel } from "../utils/requestError";
 
 
-export const catchUnroutedRequests: ErrorRequestHandler = (error: RequestError|Error, req, res, next) => {
+export const requestErrorHandler: ErrorRequestHandler = (error: RequestError|Error, req, res, next) => {
     if(res.headersSent) return next();
     //TODO: Find better way to type check for error. In current setting you need to cast type to get the functions and variables from RequestError
     if(!(error instanceof RequestError)){