mirror of
https://github.com/awatertrevi/infisical.git
synced 2026-10-08 05:27:52 +00:00
feat(secrets-ui): Improve SecretDashboard table to support multiple changes on a single commit
This commit is contained in:
@@ -3,11 +3,14 @@ import { z } from "zod";
|
|||||||
|
|
||||||
import { EventType } from "@app/ee/services/audit-log/audit-log-types";
|
import { EventType } from "@app/ee/services/audit-log/audit-log-types";
|
||||||
import { removeTrailingSlash } from "@app/lib/fn";
|
import { removeTrailingSlash } from "@app/lib/fn";
|
||||||
import { readLimit } from "@app/server/config/rateLimiter";
|
import { isValidFolderName } from "@app/lib/validator";
|
||||||
|
import { readLimit, secretsLimit } from "@app/server/config/rateLimiter";
|
||||||
|
import { SecretNameSchema } from "@app/server/lib/schemas";
|
||||||
import { verifyAuth } from "@app/server/plugins/auth/verify-auth";
|
import { verifyAuth } from "@app/server/plugins/auth/verify-auth";
|
||||||
import { booleanSchema } from "@app/server/routes/sanitizedSchemas";
|
import { booleanSchema } from "@app/server/routes/sanitizedSchemas";
|
||||||
import { AuthMode } from "@app/services/auth/auth-type";
|
import { AuthMode } from "@app/services/auth/auth-type";
|
||||||
import { commitChangesResponseSchema, resourceChangeSchema } from "@app/services/folder-commit/folder-commit-schemas";
|
import { commitChangesResponseSchema, resourceChangeSchema } from "@app/services/folder-commit/folder-commit-schemas";
|
||||||
|
import { ResourceMetadataSchema } from "@app/services/resource-metadata/resource-metadata-schema";
|
||||||
|
|
||||||
const commitHistoryItemSchema = z.object({
|
const commitHistoryItemSchema = z.object({
|
||||||
id: z.string(),
|
id: z.string(),
|
||||||
@@ -413,4 +416,134 @@ export const registerPITRouter = async (server: FastifyZodProvider) => {
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
server.route({
|
||||||
|
method: "POST",
|
||||||
|
url: "/batch/commit",
|
||||||
|
config: {
|
||||||
|
rateLimit: secretsLimit
|
||||||
|
},
|
||||||
|
schema: {
|
||||||
|
hide: true,
|
||||||
|
description: "Commit changes",
|
||||||
|
security: [
|
||||||
|
{
|
||||||
|
bearerAuth: []
|
||||||
|
}
|
||||||
|
],
|
||||||
|
body: z.object({
|
||||||
|
projectSlug: z.string().trim().optional(),
|
||||||
|
workspaceId: z.string().trim().optional(),
|
||||||
|
environment: z.string().trim(),
|
||||||
|
secretPath: z.string().trim().default("/").transform(removeTrailingSlash),
|
||||||
|
message: z.string().trim(),
|
||||||
|
changes: z.object({
|
||||||
|
secrets: z.object({
|
||||||
|
create: z
|
||||||
|
.array(
|
||||||
|
z.object({
|
||||||
|
secretKey: SecretNameSchema,
|
||||||
|
secretValue: z.string().transform((val) => (val.at(-1) === "\n" ? `${val.trim()}\n` : val.trim())),
|
||||||
|
secretComment: z.string().trim().optional().default(""),
|
||||||
|
skipMultilineEncoding: z.boolean().optional(),
|
||||||
|
metadata: z.record(z.string()).optional(),
|
||||||
|
secretMetadata: ResourceMetadataSchema.optional(),
|
||||||
|
tagIds: z.string().array().optional()
|
||||||
|
})
|
||||||
|
)
|
||||||
|
.optional(),
|
||||||
|
update: z
|
||||||
|
.array(
|
||||||
|
z.object({
|
||||||
|
secretKey: SecretNameSchema,
|
||||||
|
newSecretName: SecretNameSchema.optional(),
|
||||||
|
secretValue: z
|
||||||
|
.string()
|
||||||
|
.transform((val) => (val.at(-1) === "\n" ? `${val.trim()}\n` : val.trim()))
|
||||||
|
.optional(),
|
||||||
|
secretComment: z.string().trim().optional().default(""),
|
||||||
|
skipMultilineEncoding: z.boolean().optional(),
|
||||||
|
metadata: z.record(z.string()).optional(),
|
||||||
|
secretMetadata: ResourceMetadataSchema.optional(),
|
||||||
|
tagIds: z.string().array().optional()
|
||||||
|
})
|
||||||
|
)
|
||||||
|
.optional(),
|
||||||
|
delete: z
|
||||||
|
.array(
|
||||||
|
z.object({
|
||||||
|
secretKey: SecretNameSchema
|
||||||
|
})
|
||||||
|
)
|
||||||
|
.optional()
|
||||||
|
}),
|
||||||
|
folders: z.object({
|
||||||
|
create: z
|
||||||
|
.array(
|
||||||
|
z.object({
|
||||||
|
folderName: z
|
||||||
|
.string()
|
||||||
|
.trim()
|
||||||
|
.refine((name) => isValidFolderName(name), {
|
||||||
|
message: "Invalid folder name. Only alphanumeric characters, dashes, and underscores are allowed."
|
||||||
|
}),
|
||||||
|
description: z.string().optional()
|
||||||
|
})
|
||||||
|
)
|
||||||
|
.optional(),
|
||||||
|
update: z
|
||||||
|
.array(
|
||||||
|
z.object({
|
||||||
|
folderName: z
|
||||||
|
.string()
|
||||||
|
.trim()
|
||||||
|
.refine((name) => isValidFolderName(name), {
|
||||||
|
message: "Invalid folder name. Only alphanumeric characters, dashes, and underscores are allowed."
|
||||||
|
}),
|
||||||
|
description: z.string().optional(),
|
||||||
|
id: z.string()
|
||||||
|
})
|
||||||
|
)
|
||||||
|
.optional(),
|
||||||
|
delete: z
|
||||||
|
.array(
|
||||||
|
z.object({
|
||||||
|
folderName: z
|
||||||
|
.string()
|
||||||
|
.trim()
|
||||||
|
.refine((name) => isValidFolderName(name), {
|
||||||
|
message: "Invalid folder name. Only alphanumeric characters, dashes, and underscores are allowed."
|
||||||
|
}),
|
||||||
|
id: z.string()
|
||||||
|
})
|
||||||
|
)
|
||||||
|
.optional()
|
||||||
|
})
|
||||||
|
})
|
||||||
|
}),
|
||||||
|
response: {
|
||||||
|
200: z.object({
|
||||||
|
message: z.string()
|
||||||
|
})
|
||||||
|
}
|
||||||
|
},
|
||||||
|
onRequest: verifyAuth([AuthMode.JWT]),
|
||||||
|
handler: async (req) => {
|
||||||
|
await server.services.pit.processNewCommitRaw({
|
||||||
|
actorId: req.permission.id,
|
||||||
|
actor: req.permission.type,
|
||||||
|
actorOrgId: req.permission.orgId,
|
||||||
|
actorAuthMethod: req.permission.authMethod,
|
||||||
|
projectId: req.body.workspaceId,
|
||||||
|
environment: req.body.environment,
|
||||||
|
secretPath: req.body.secretPath,
|
||||||
|
message: req.body.message,
|
||||||
|
changes: {
|
||||||
|
secrets: req.body.changes.secrets,
|
||||||
|
folders: req.body.changes.folders
|
||||||
|
}
|
||||||
|
});
|
||||||
|
return { message: "success" };
|
||||||
|
}
|
||||||
|
});
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -2,28 +2,50 @@
|
|||||||
import { ForbiddenError } from "@casl/ability";
|
import { ForbiddenError } from "@casl/ability";
|
||||||
|
|
||||||
import { ProjectPermissionCommitsActions, ProjectPermissionSub } from "@app/ee/services/permission/project-permission";
|
import { ProjectPermissionCommitsActions, ProjectPermissionSub } from "@app/ee/services/permission/project-permission";
|
||||||
import { NotFoundError } from "@app/lib/errors";
|
import { BadRequestError, NotFoundError } from "@app/lib/errors";
|
||||||
import { logger } from "@app/lib/logger";
|
import { logger } from "@app/lib/logger";
|
||||||
import { ActorAuthMethod, ActorType } from "@app/services/auth/auth-type";
|
import { ActorAuthMethod, ActorType } from "@app/services/auth/auth-type";
|
||||||
import { ResourceType, TFolderCommitServiceFactory } from "@app/services/folder-commit/folder-commit-service";
|
import { TFolderCommitDALFactory } from "@app/services/folder-commit/folder-commit-dal";
|
||||||
|
import {
|
||||||
|
ResourceType,
|
||||||
|
TCreateCommitChangeDTO,
|
||||||
|
TFolderCommitServiceFactory
|
||||||
|
} from "@app/services/folder-commit/folder-commit-service";
|
||||||
import {
|
import {
|
||||||
isFolderCommitChange,
|
isFolderCommitChange,
|
||||||
isSecretCommitChange
|
isSecretCommitChange
|
||||||
} from "@app/services/folder-commit-changes/folder-commit-changes-dal";
|
} from "@app/services/folder-commit-changes/folder-commit-changes-dal";
|
||||||
|
import { TProjectDALFactory } from "@app/services/project/project-dal";
|
||||||
import { TProjectEnvDALFactory } from "@app/services/project-env/project-env-dal";
|
import { TProjectEnvDALFactory } from "@app/services/project-env/project-env-dal";
|
||||||
import { TSecretServiceFactory } from "@app/services/secret/secret-service";
|
import { TSecretServiceFactory } from "@app/services/secret/secret-service";
|
||||||
|
import { SecretProtectionType, TProcessNewCommitRawDTO } from "@app/services/secret/secret-types";
|
||||||
import { TSecretFolderDALFactory } from "@app/services/secret-folder/secret-folder-dal";
|
import { TSecretFolderDALFactory } from "@app/services/secret-folder/secret-folder-dal";
|
||||||
import { TSecretFolderServiceFactory } from "@app/services/secret-folder/secret-folder-service";
|
import { TSecretFolderServiceFactory } from "@app/services/secret-folder/secret-folder-service";
|
||||||
|
import { TSecretV2BridgeServiceFactory } from "@app/services/secret-v2-bridge/secret-v2-bridge-service";
|
||||||
|
import { SecretOperations, SecretUpdateMode } from "@app/services/secret-v2-bridge/secret-v2-bridge-types";
|
||||||
|
|
||||||
import { TPermissionServiceFactory } from "../permission/permission-service-types";
|
import { TPermissionServiceFactory } from "../permission/permission-service-types";
|
||||||
|
import { TSecretApprovalPolicyServiceFactory } from "../secret-approval-policy/secret-approval-policy-service";
|
||||||
|
import { TSecretApprovalRequestServiceFactory } from "../secret-approval-request/secret-approval-request-service";
|
||||||
|
|
||||||
type TPitServiceFactoryDep = {
|
type TPitServiceFactoryDep = {
|
||||||
folderCommitService: TFolderCommitServiceFactory;
|
folderCommitService: TFolderCommitServiceFactory;
|
||||||
secretService: Pick<TSecretServiceFactory, "getSecretVersionsV2ByIds" | "getChangeVersions">;
|
secretService: Pick<TSecretServiceFactory, "getSecretVersionsV2ByIds" | "getChangeVersions">;
|
||||||
folderService: Pick<TSecretFolderServiceFactory, "getFolderById" | "getFolderVersions">;
|
folderService: Pick<
|
||||||
|
TSecretFolderServiceFactory,
|
||||||
|
"getFolderById" | "getFolderVersions" | "createManyFolders" | "updateManyFolders" | "deleteManyFolders"
|
||||||
|
>;
|
||||||
permissionService: Pick<TPermissionServiceFactory, "getProjectPermission">;
|
permissionService: Pick<TPermissionServiceFactory, "getProjectPermission">;
|
||||||
folderDAL: Pick<TSecretFolderDALFactory, "findSecretPathByFolderIds">;
|
folderDAL: Pick<TSecretFolderDALFactory, "findSecretPathByFolderIds" | "findBySecretPath">;
|
||||||
projectEnvDAL: Pick<TProjectEnvDALFactory, "findOne">;
|
projectEnvDAL: Pick<TProjectEnvDALFactory, "findOne">;
|
||||||
|
secretApprovalRequestService: Pick<
|
||||||
|
TSecretApprovalRequestServiceFactory,
|
||||||
|
"generateSecretApprovalRequest" | "generateSecretApprovalRequestV2Bridge"
|
||||||
|
>;
|
||||||
|
secretApprovalPolicyService: Pick<TSecretApprovalPolicyServiceFactory, "getSecretApprovalPolicy">;
|
||||||
|
projectDAL: Pick<TProjectDALFactory, "checkProjectUpgradeStatus" | "findProjectBySlug" | "findById">;
|
||||||
|
secretV2BridgeService: TSecretV2BridgeServiceFactory;
|
||||||
|
folderCommitDAL: Pick<TFolderCommitDALFactory, "transaction">;
|
||||||
};
|
};
|
||||||
|
|
||||||
export type TPitServiceFactory = ReturnType<typeof pitServiceFactory>;
|
export type TPitServiceFactory = ReturnType<typeof pitServiceFactory>;
|
||||||
@@ -34,7 +56,12 @@ export const pitServiceFactory = ({
|
|||||||
folderService,
|
folderService,
|
||||||
permissionService,
|
permissionService,
|
||||||
folderDAL,
|
folderDAL,
|
||||||
projectEnvDAL
|
projectEnvDAL,
|
||||||
|
secretApprovalRequestService,
|
||||||
|
secretApprovalPolicyService,
|
||||||
|
projectDAL,
|
||||||
|
secretV2BridgeService,
|
||||||
|
folderCommitDAL
|
||||||
}: TPitServiceFactoryDep) => {
|
}: TPitServiceFactoryDep) => {
|
||||||
const getCommitsCount = async ({
|
const getCommitsCount = async ({
|
||||||
actor,
|
actor,
|
||||||
@@ -471,6 +498,251 @@ export const pitServiceFactory = ({
|
|||||||
});
|
});
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const processNewCommitRaw = async ({
|
||||||
|
actorId,
|
||||||
|
projectSlug,
|
||||||
|
projectId: optionalProjectId,
|
||||||
|
environment,
|
||||||
|
actor,
|
||||||
|
actorOrgId,
|
||||||
|
actorAuthMethod,
|
||||||
|
secretPath,
|
||||||
|
message,
|
||||||
|
changes = {
|
||||||
|
secrets: {
|
||||||
|
create: [],
|
||||||
|
update: [],
|
||||||
|
delete: []
|
||||||
|
},
|
||||||
|
folders: {
|
||||||
|
create: [],
|
||||||
|
update: [],
|
||||||
|
delete: []
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}: {
|
||||||
|
actorId: string;
|
||||||
|
projectSlug?: string;
|
||||||
|
projectId?: string;
|
||||||
|
environment: string;
|
||||||
|
actor: ActorType;
|
||||||
|
actorOrgId: string;
|
||||||
|
actorAuthMethod: ActorAuthMethod;
|
||||||
|
secretPath: string;
|
||||||
|
message: string;
|
||||||
|
changes: TProcessNewCommitRawDTO;
|
||||||
|
}) => {
|
||||||
|
if (!projectSlug && !optionalProjectId)
|
||||||
|
throw new BadRequestError({ message: "Must provide either project slug or projectId" });
|
||||||
|
|
||||||
|
let projectId = optionalProjectId as string;
|
||||||
|
if (!optionalProjectId && projectSlug) {
|
||||||
|
const project = await projectDAL.findProjectBySlug(projectSlug, actorOrgId);
|
||||||
|
if (!project) throw new NotFoundError({ message: `Project with slug '${projectSlug}' not found` });
|
||||||
|
projectId = project.id;
|
||||||
|
}
|
||||||
|
|
||||||
|
const policy =
|
||||||
|
actor === ActorType.USER
|
||||||
|
? await secretApprovalPolicyService.getSecretApprovalPolicy(projectId, environment, secretPath)
|
||||||
|
: undefined;
|
||||||
|
|
||||||
|
const project = await projectDAL.findById(projectId);
|
||||||
|
if (project.enforceCapitalization) {
|
||||||
|
const caseViolatingSecretKeys = [
|
||||||
|
// Check create operations
|
||||||
|
...(changes.secrets?.create
|
||||||
|
?.filter((sec) => sec.secretKey !== sec.secretKey.toUpperCase())
|
||||||
|
.map((sec) => sec.secretKey) ?? []),
|
||||||
|
|
||||||
|
// Check update operations
|
||||||
|
...(changes.secrets?.update
|
||||||
|
?.filter(
|
||||||
|
(sec) =>
|
||||||
|
sec.secretKey !== sec.secretKey.toUpperCase() ||
|
||||||
|
(sec.newSecretKey && sec.newSecretKey !== sec.newSecretKey.toUpperCase())
|
||||||
|
)
|
||||||
|
.map((sec) => sec.secretKey) ?? [])
|
||||||
|
];
|
||||||
|
|
||||||
|
if (caseViolatingSecretKeys.length) {
|
||||||
|
throw new BadRequestError({
|
||||||
|
message: `Secret names must be in UPPERCASE per project requirements: ${caseViolatingSecretKeys.join(
|
||||||
|
", "
|
||||||
|
)}. You can disable this requirement in project settings`
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
await folderCommitDAL.transaction(async (trx) => {
|
||||||
|
const targetFolder = await folderDAL.findBySecretPath(projectId, environment, secretPath);
|
||||||
|
if (!targetFolder)
|
||||||
|
throw new NotFoundError({
|
||||||
|
message: `Folder with path '${secretPath}' in environment with slug '${environment}' not found`,
|
||||||
|
name: "CreateManySecret"
|
||||||
|
});
|
||||||
|
const commitChanges: TCreateCommitChangeDTO[] = [];
|
||||||
|
|
||||||
|
if ((changes.folders?.create?.length ?? 0) > 0) {
|
||||||
|
await folderService.createManyFolders({
|
||||||
|
projectId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
actorOrgId,
|
||||||
|
actorAuthMethod,
|
||||||
|
folders:
|
||||||
|
changes.folders?.create?.map((folder) => ({
|
||||||
|
name: folder.folderName,
|
||||||
|
environment,
|
||||||
|
path: secretPath,
|
||||||
|
description: folder.description
|
||||||
|
})) ?? [],
|
||||||
|
tx: trx,
|
||||||
|
commitChanges
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((changes.folders?.update?.length ?? 0) > 0) {
|
||||||
|
await folderService.updateManyFolders({
|
||||||
|
projectId,
|
||||||
|
projectSlug: projectSlug || "",
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
actorOrgId,
|
||||||
|
actorAuthMethod,
|
||||||
|
folders:
|
||||||
|
changes.folders?.update?.map((folder) => ({
|
||||||
|
environment,
|
||||||
|
path: secretPath,
|
||||||
|
id: folder.id,
|
||||||
|
name: folder.folderName,
|
||||||
|
description: folder.description
|
||||||
|
})) ?? [],
|
||||||
|
tx: trx,
|
||||||
|
commitChanges
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((changes.folders?.delete?.length ?? 0) > 0) {
|
||||||
|
await folderService.deleteManyFolders({
|
||||||
|
projectId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
actorOrgId,
|
||||||
|
actorAuthMethod,
|
||||||
|
folders:
|
||||||
|
changes.folders?.delete?.map((folder) => ({
|
||||||
|
environment,
|
||||||
|
path: secretPath,
|
||||||
|
idOrName: folder.id
|
||||||
|
})) ?? [],
|
||||||
|
tx: trx,
|
||||||
|
commitChanges
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (policy) {
|
||||||
|
const approval = await secretApprovalRequestService.generateSecretApprovalRequestV2Bridge({
|
||||||
|
policy,
|
||||||
|
secretPath,
|
||||||
|
environment,
|
||||||
|
projectId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
actorOrgId,
|
||||||
|
actorAuthMethod,
|
||||||
|
data: {
|
||||||
|
[SecretOperations.Create]:
|
||||||
|
changes.secrets?.create?.map((el) => ({
|
||||||
|
tagIds: el.tagIds,
|
||||||
|
secretValue: el.secretValue,
|
||||||
|
secretComment: el.secretComment,
|
||||||
|
metadata: el.metadata,
|
||||||
|
skipMultilineEncoding: el.skipMultilineEncoding,
|
||||||
|
secretKey: el.secretKey,
|
||||||
|
secretMetadata: el.secretMetadata
|
||||||
|
})) ?? [],
|
||||||
|
[SecretOperations.Update]:
|
||||||
|
changes.secrets?.update?.map((el) => ({
|
||||||
|
tagIds: el.tagIds,
|
||||||
|
secretValue: el.secretValue,
|
||||||
|
secretComment: el.secretComment,
|
||||||
|
metadata: el.metadata,
|
||||||
|
skipMultilineEncoding: el.skipMultilineEncoding,
|
||||||
|
secretKey: el.secretKey,
|
||||||
|
secretMetadata: el.secretMetadata
|
||||||
|
})) ?? [],
|
||||||
|
[SecretOperations.Delete]:
|
||||||
|
changes.secrets?.delete?.map((el) => ({
|
||||||
|
secretKey: el.secretKey
|
||||||
|
})) ?? []
|
||||||
|
}
|
||||||
|
});
|
||||||
|
return { type: SecretProtectionType.Approval as const, approval };
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((changes.secrets?.create?.length ?? 0) > 0) {
|
||||||
|
await secretV2BridgeService.createManySecret({
|
||||||
|
secretPath,
|
||||||
|
environment,
|
||||||
|
projectId,
|
||||||
|
actorAuthMethod,
|
||||||
|
actorOrgId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
secrets: changes.secrets?.create ?? [],
|
||||||
|
tx: trx,
|
||||||
|
commitChanges
|
||||||
|
});
|
||||||
|
}
|
||||||
|
if ((changes.secrets?.update?.length ?? 0) > 0) {
|
||||||
|
await secretV2BridgeService.updateManySecret({
|
||||||
|
secretPath,
|
||||||
|
environment,
|
||||||
|
projectId,
|
||||||
|
actorAuthMethod,
|
||||||
|
actorOrgId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
secrets: changes.secrets?.update ?? [],
|
||||||
|
mode: SecretUpdateMode.FailOnNotFound,
|
||||||
|
tx: trx,
|
||||||
|
commitChanges
|
||||||
|
});
|
||||||
|
}
|
||||||
|
if ((changes.secrets?.delete?.length ?? 0) > 0) {
|
||||||
|
await secretV2BridgeService.deleteManySecret({
|
||||||
|
secretPath,
|
||||||
|
environment,
|
||||||
|
projectId,
|
||||||
|
actorAuthMethod,
|
||||||
|
actorOrgId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
secrets: changes.secrets?.delete ?? [],
|
||||||
|
tx: trx,
|
||||||
|
commitChanges
|
||||||
|
});
|
||||||
|
}
|
||||||
|
if (commitChanges?.length > 0) {
|
||||||
|
await folderCommitService.createCommit(
|
||||||
|
{
|
||||||
|
actor: {
|
||||||
|
type: actor || ActorType.PLATFORM,
|
||||||
|
metadata: {
|
||||||
|
id: actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message,
|
||||||
|
folderId: targetFolder.id,
|
||||||
|
changes: commitChanges
|
||||||
|
},
|
||||||
|
trx
|
||||||
|
);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
return {
|
return {
|
||||||
getCommitsCount,
|
getCommitsCount,
|
||||||
getCommitsForFolder,
|
getCommitsForFolder,
|
||||||
@@ -478,6 +750,7 @@ export const pitServiceFactory = ({
|
|||||||
compareCommitChanges,
|
compareCommitChanges,
|
||||||
rollbackToCommit,
|
rollbackToCommit,
|
||||||
revertCommit,
|
revertCommit,
|
||||||
getFolderStateAtCommit
|
getFolderStateAtCommit,
|
||||||
|
processNewCommitRaw
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1536,7 +1536,12 @@ export const registerRoutes = async (
|
|||||||
folderService,
|
folderService,
|
||||||
permissionService,
|
permissionService,
|
||||||
folderDAL,
|
folderDAL,
|
||||||
projectEnvDAL
|
projectEnvDAL,
|
||||||
|
secretApprovalRequestService,
|
||||||
|
secretApprovalPolicyService,
|
||||||
|
projectDAL,
|
||||||
|
secretV2BridgeService,
|
||||||
|
folderCommitDAL
|
||||||
});
|
});
|
||||||
|
|
||||||
const identityOidcAuthService = identityOidcAuthServiceFactory({
|
const identityOidcAuthService = identityOidcAuthServiceFactory({
|
||||||
|
|||||||
@@ -47,6 +47,14 @@ export enum ResourceType {
|
|||||||
FOLDER = "folder"
|
FOLDER = "folder"
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export type TCreateCommitChangeDTO = {
|
||||||
|
type: string;
|
||||||
|
secretVersionId?: string;
|
||||||
|
folderVersionId?: string;
|
||||||
|
isUpdate?: boolean;
|
||||||
|
folderId?: string;
|
||||||
|
};
|
||||||
|
|
||||||
type TCreateCommitDTO = {
|
type TCreateCommitDTO = {
|
||||||
actor: {
|
actor: {
|
||||||
type: string;
|
type: string;
|
||||||
@@ -57,13 +65,7 @@ type TCreateCommitDTO = {
|
|||||||
};
|
};
|
||||||
message?: string;
|
message?: string;
|
||||||
folderId: string;
|
folderId: string;
|
||||||
changes: {
|
changes: TCreateCommitChangeDTO[];
|
||||||
type: string;
|
|
||||||
secretVersionId?: string;
|
|
||||||
folderVersionId?: string;
|
|
||||||
isUpdate?: boolean;
|
|
||||||
folderId?: string;
|
|
||||||
}[];
|
|
||||||
omitIgnoreFilter?: boolean;
|
omitIgnoreFilter?: boolean;
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -895,16 +897,16 @@ export const folderCommitServiceFactory = ({
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const newCommit = await folderCommitDAL.create(
|
const newCommit = await folderCommitDAL.create(
|
||||||
{
|
{
|
||||||
actorMetadata: metadata,
|
actorMetadata: metadata,
|
||||||
actorType: data.actor.type,
|
actorType: data.actor.type,
|
||||||
message: data.message,
|
message: data.message,
|
||||||
folderId: data.folderId,
|
folderId: data.folderId,
|
||||||
envId: folder.envId
|
envId: folder.envId
|
||||||
},
|
},
|
||||||
tx
|
tx
|
||||||
);
|
);
|
||||||
|
|
||||||
const batchSize = 500;
|
const batchSize = 500;
|
||||||
const chunks = chunkArray(changes, batchSize);
|
const chunks = chunkArray(changes, batchSize);
|
||||||
|
|||||||
@@ -1,4 +1,6 @@
|
|||||||
|
/* eslint-disable no-await-in-loop */
|
||||||
import { ForbiddenError, subject } from "@casl/ability";
|
import { ForbiddenError, subject } from "@casl/ability";
|
||||||
|
import { Knex } from "knex";
|
||||||
import path from "path";
|
import path from "path";
|
||||||
import { v4 as uuidv4, validate as uuidValidate } from "uuid";
|
import { v4 as uuidv4, validate as uuidValidate } from "uuid";
|
||||||
|
|
||||||
@@ -12,14 +14,21 @@ import { BadRequestError, NotFoundError } from "@app/lib/errors";
|
|||||||
import { OrderByDirection, OrgServiceActor } from "@app/lib/types";
|
import { OrderByDirection, OrgServiceActor } from "@app/lib/types";
|
||||||
import { buildFolderPath } from "@app/services/secret-folder/secret-folder-fns";
|
import { buildFolderPath } from "@app/services/secret-folder/secret-folder-fns";
|
||||||
|
|
||||||
import { ChangeType, CommitType, TFolderCommitServiceFactory } from "../folder-commit/folder-commit-service";
|
import {
|
||||||
|
ChangeType,
|
||||||
|
CommitType,
|
||||||
|
TCreateCommitChangeDTO,
|
||||||
|
TFolderCommitServiceFactory
|
||||||
|
} from "../folder-commit/folder-commit-service";
|
||||||
import { TProjectDALFactory } from "../project/project-dal";
|
import { TProjectDALFactory } from "../project/project-dal";
|
||||||
import { TProjectEnvDALFactory } from "../project-env/project-env-dal";
|
import { TProjectEnvDALFactory } from "../project-env/project-env-dal";
|
||||||
import { TSecretV2BridgeDALFactory } from "../secret-v2-bridge/secret-v2-bridge-dal";
|
import { TSecretV2BridgeDALFactory } from "../secret-v2-bridge/secret-v2-bridge-dal";
|
||||||
import { TSecretFolderDALFactory } from "./secret-folder-dal";
|
import { TSecretFolderDALFactory } from "./secret-folder-dal";
|
||||||
import {
|
import {
|
||||||
TCreateFolderDTO,
|
TCreateFolderDTO,
|
||||||
|
TCreateManyFoldersDTO,
|
||||||
TDeleteFolderDTO,
|
TDeleteFolderDTO,
|
||||||
|
TDeleteManyFoldersDTO,
|
||||||
TGetFolderByIdDTO,
|
TGetFolderByIdDTO,
|
||||||
TGetFolderDTO,
|
TGetFolderDTO,
|
||||||
TGetFoldersDeepByEnvsDTO,
|
TGetFoldersDeepByEnvsDTO,
|
||||||
@@ -236,19 +245,26 @@ export const secretFolderServiceFactory = ({
|
|||||||
actor,
|
actor,
|
||||||
actorId,
|
actorId,
|
||||||
projectSlug,
|
projectSlug,
|
||||||
|
projectId: providedProjectId,
|
||||||
actorAuthMethod,
|
actorAuthMethod,
|
||||||
actorOrgId,
|
actorOrgId,
|
||||||
folders
|
folders,
|
||||||
}: TUpdateManyFoldersDTO) => {
|
tx: providedTx,
|
||||||
const project = await projectDAL.findProjectBySlug(projectSlug, actorOrgId);
|
commitChanges
|
||||||
if (!project) {
|
}: TUpdateManyFoldersDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[]; projectId?: string }) => {
|
||||||
throw new NotFoundError({ message: `Project with slug '${projectSlug}' not found` });
|
let projectId = providedProjectId;
|
||||||
|
if (!projectId) {
|
||||||
|
const project = await projectDAL.findProjectBySlug(projectSlug, actorOrgId);
|
||||||
|
if (!project) {
|
||||||
|
throw new NotFoundError({ message: `Project with slug '${projectSlug}' not found` });
|
||||||
|
}
|
||||||
|
projectId = project.id;
|
||||||
}
|
}
|
||||||
|
|
||||||
const { permission } = await permissionService.getProjectPermission({
|
const { permission } = await permissionService.getProjectPermission({
|
||||||
actor,
|
actor,
|
||||||
actorId,
|
actorId,
|
||||||
projectId: project.id,
|
projectId,
|
||||||
actorAuthMethod,
|
actorAuthMethod,
|
||||||
actorOrgId
|
actorOrgId
|
||||||
});
|
});
|
||||||
@@ -260,12 +276,12 @@ export const secretFolderServiceFactory = ({
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
const result = await folderDAL.transaction(async (tx) =>
|
const executeBulkUpdate = async (tx: Knex) => {
|
||||||
Promise.all(
|
return Promise.all(
|
||||||
folders.map(async (newFolder) => {
|
folders.map(async (newFolder) => {
|
||||||
const { environment, path: secretPath, id, name, description } = newFolder;
|
const { environment, path: secretPath, id, name, description } = newFolder;
|
||||||
|
|
||||||
const parentFolder = await folderDAL.findBySecretPath(project.id, environment, secretPath);
|
const parentFolder = await folderDAL.findBySecretPath(projectId as string, environment, secretPath, tx);
|
||||||
if (!parentFolder) {
|
if (!parentFolder) {
|
||||||
throw new NotFoundError({
|
throw new NotFoundError({
|
||||||
message: `Folder with path '${secretPath}' in environment with slug '${environment}' not found`,
|
message: `Folder with path '${secretPath}' in environment with slug '${environment}' not found`,
|
||||||
@@ -273,10 +289,10 @@ export const secretFolderServiceFactory = ({
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
const env = await projectEnvDAL.findOne({ projectId: project.id, slug: environment });
|
const env = await projectEnvDAL.findOne({ projectId, slug: environment });
|
||||||
if (!env) {
|
if (!env) {
|
||||||
throw new NotFoundError({
|
throw new NotFoundError({
|
||||||
message: `Environment with slug '${environment}' in project with ID '${project.id}' not found`,
|
message: `Environment with slug '${environment}' in project with ID '${projectId}' not found`,
|
||||||
name: "UpdateManyFolders"
|
name: "UpdateManyFolders"
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
@@ -323,26 +339,34 @@ export const secretFolderServiceFactory = ({
|
|||||||
},
|
},
|
||||||
tx
|
tx
|
||||||
);
|
);
|
||||||
await folderCommitService.createCommit(
|
if (commitChanges) {
|
||||||
{
|
commitChanges.push({
|
||||||
actor: {
|
type: CommitType.ADD,
|
||||||
type: actor,
|
isUpdate: true,
|
||||||
metadata: {
|
folderVersionId: folderVersion.id
|
||||||
id: actorId
|
});
|
||||||
}
|
} else {
|
||||||
|
await folderCommitService.createCommit(
|
||||||
|
{
|
||||||
|
actor: {
|
||||||
|
type: actor,
|
||||||
|
metadata: {
|
||||||
|
id: actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Folder updated",
|
||||||
|
folderId: parentFolder.id,
|
||||||
|
changes: [
|
||||||
|
{
|
||||||
|
type: CommitType.ADD,
|
||||||
|
isUpdate: true,
|
||||||
|
folderVersionId: folderVersion.id
|
||||||
|
}
|
||||||
|
]
|
||||||
},
|
},
|
||||||
message: "Folder updated",
|
tx
|
||||||
folderId: parentFolder.id,
|
);
|
||||||
changes: [
|
}
|
||||||
{
|
|
||||||
type: CommitType.ADD,
|
|
||||||
isUpdate: true,
|
|
||||||
folderVersionId: folderVersion.id
|
|
||||||
}
|
|
||||||
]
|
|
||||||
},
|
|
||||||
tx
|
|
||||||
);
|
|
||||||
if (!doc) {
|
if (!doc) {
|
||||||
throw new NotFoundError({
|
throw new NotFoundError({
|
||||||
message: `Failed to update folder with id '${id}', not found`,
|
message: `Failed to update folder with id '${id}', not found`,
|
||||||
@@ -352,13 +376,16 @@ export const secretFolderServiceFactory = ({
|
|||||||
|
|
||||||
return { oldFolder: folder, newFolder: doc };
|
return { oldFolder: folder, newFolder: doc };
|
||||||
})
|
})
|
||||||
)
|
);
|
||||||
);
|
};
|
||||||
|
|
||||||
|
// Execute with provided transaction or create new one
|
||||||
|
const result = providedTx ? await executeBulkUpdate(providedTx) : await folderDAL.transaction(executeBulkUpdate);
|
||||||
|
|
||||||
await Promise.all(result.map(async (res) => snapshotService.performSnapshot(res.newFolder.parentId as string)));
|
await Promise.all(result.map(async (res) => snapshotService.performSnapshot(res.newFolder.parentId as string)));
|
||||||
|
|
||||||
return {
|
return {
|
||||||
projectId: project.id,
|
projectId,
|
||||||
newFolders: result.map((res) => res.newFolder),
|
newFolders: result.map((res) => res.newFolder),
|
||||||
oldFolders: result.map((res) => res.oldFolder)
|
oldFolders: result.map((res) => res.oldFolder)
|
||||||
};
|
};
|
||||||
@@ -974,6 +1001,361 @@ export const secretFolderServiceFactory = ({
|
|||||||
}));
|
}));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const createManyFolders = async ({
|
||||||
|
projectId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
actorAuthMethod,
|
||||||
|
actorOrgId,
|
||||||
|
folders,
|
||||||
|
tx: providedTx,
|
||||||
|
commitChanges
|
||||||
|
}: TCreateManyFoldersDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
|
||||||
|
const { permission } = await permissionService.getProjectPermission({
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
projectId,
|
||||||
|
actorAuthMethod,
|
||||||
|
actorOrgId
|
||||||
|
});
|
||||||
|
|
||||||
|
folders.forEach(({ environment, path: secretPath }) => {
|
||||||
|
ForbiddenError.from(permission).throwUnlessCan(
|
||||||
|
ProjectPermissionActions.Create,
|
||||||
|
subject(ProjectPermissionSub.SecretFolders, { environment, secretPath })
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
const foldersByEnv = folders.reduce(
|
||||||
|
(acc, folder) => {
|
||||||
|
if (!acc[folder.environment]) {
|
||||||
|
acc[folder.environment] = [];
|
||||||
|
}
|
||||||
|
acc[folder.environment].push(folder);
|
||||||
|
return acc;
|
||||||
|
},
|
||||||
|
{} as Record<string, typeof folders>
|
||||||
|
);
|
||||||
|
|
||||||
|
const executeBulkCreate = async (tx: Knex) => {
|
||||||
|
const createdFolders = [];
|
||||||
|
|
||||||
|
for (const [environment, envFolders] of Object.entries(foldersByEnv)) {
|
||||||
|
const env = await projectEnvDAL.findOne({ projectId, slug: environment });
|
||||||
|
if (!env) {
|
||||||
|
throw new NotFoundError({
|
||||||
|
message: `Environment with slug '${environment}' in project with ID '${projectId}' not found`
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
await tx.raw("SELECT pg_advisory_xact_lock(?)", [PgSqlLock.CreateFolder(env.id, env.projectId)]);
|
||||||
|
|
||||||
|
for (const folderSpec of envFolders) {
|
||||||
|
const { name, path: secretPath, description } = folderSpec;
|
||||||
|
|
||||||
|
const pathWithFolder = path.join(secretPath, name);
|
||||||
|
const parentFolder = await folderDAL.findClosestFolder(projectId, environment, pathWithFolder, tx);
|
||||||
|
|
||||||
|
if (!parentFolder) {
|
||||||
|
throw new NotFoundError({
|
||||||
|
message: `Parent folder for path '${pathWithFolder}' not found`
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if the exact folder already exists
|
||||||
|
const existingFolder = await folderDAL.findOne(
|
||||||
|
{
|
||||||
|
envId: env.id,
|
||||||
|
parentId: parentFolder.id,
|
||||||
|
name,
|
||||||
|
isReserved: false
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingFolder) {
|
||||||
|
createdFolders.push(existingFolder);
|
||||||
|
// eslint-disable-next-line no-continue
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Handle exact folder case
|
||||||
|
if (parentFolder.path === pathWithFolder) {
|
||||||
|
createdFolders.push(parentFolder);
|
||||||
|
// eslint-disable-next-line no-continue
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
let currentParentId = parentFolder.id;
|
||||||
|
|
||||||
|
// Build the full path we need by processing each segment
|
||||||
|
if (parentFolder.path !== secretPath) {
|
||||||
|
const missingSegments = secretPath.substring(parentFolder.path.length).split("/").filter(Boolean);
|
||||||
|
const newFolders: TSecretFoldersInsert[] = [];
|
||||||
|
|
||||||
|
for (const segment of missingSegments) {
|
||||||
|
const existingSegment = await folderDAL.findOne(
|
||||||
|
{
|
||||||
|
name: segment,
|
||||||
|
parentId: currentParentId,
|
||||||
|
envId: env.id,
|
||||||
|
isReserved: false
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingSegment) {
|
||||||
|
currentParentId = existingSegment.id;
|
||||||
|
} else {
|
||||||
|
const newFolder = {
|
||||||
|
name: segment,
|
||||||
|
parentId: currentParentId,
|
||||||
|
id: uuidv4(),
|
||||||
|
envId: env.id,
|
||||||
|
version: 1
|
||||||
|
};
|
||||||
|
|
||||||
|
currentParentId = newFolder.id;
|
||||||
|
newFolders.push(newFolder);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (newFolders.length) {
|
||||||
|
const docs = await folderDAL.insertMany(newFolders, tx);
|
||||||
|
const folderVersions = await folderVersionDAL.insertMany(
|
||||||
|
docs.map((doc) => ({
|
||||||
|
name: doc.name,
|
||||||
|
envId: doc.envId,
|
||||||
|
version: doc.version,
|
||||||
|
folderId: doc.id,
|
||||||
|
description: doc.description
|
||||||
|
})),
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
await folderCommitService.createCommit(
|
||||||
|
{
|
||||||
|
actor: {
|
||||||
|
type: actor,
|
||||||
|
metadata: {
|
||||||
|
id: actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Folders created (batch)",
|
||||||
|
folderId: currentParentId,
|
||||||
|
changes: folderVersions.map((fv) => ({
|
||||||
|
type: CommitType.ADD,
|
||||||
|
folderVersionId: fv.id
|
||||||
|
}))
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Create the target folder
|
||||||
|
const doc = await folderDAL.create(
|
||||||
|
{ name, envId: env.id, version: 1, parentId: currentParentId, description },
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
|
||||||
|
const folderVersion = await folderVersionDAL.create(
|
||||||
|
{
|
||||||
|
name: doc.name,
|
||||||
|
envId: doc.envId,
|
||||||
|
version: doc.version,
|
||||||
|
folderId: doc.id,
|
||||||
|
description: doc.description
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
|
||||||
|
if (commitChanges) {
|
||||||
|
commitChanges.push({
|
||||||
|
type: CommitType.ADD,
|
||||||
|
folderVersionId: folderVersion.id
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
await folderCommitService.createCommit(
|
||||||
|
{
|
||||||
|
actor: {
|
||||||
|
type: actor,
|
||||||
|
metadata: {
|
||||||
|
id: actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Folder created (batch)",
|
||||||
|
folderId: doc.id,
|
||||||
|
changes: [
|
||||||
|
{
|
||||||
|
type: CommitType.ADD,
|
||||||
|
folderVersionId: folderVersion.id
|
||||||
|
}
|
||||||
|
]
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
createdFolders.push(doc);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return createdFolders;
|
||||||
|
};
|
||||||
|
const result = providedTx ? await executeBulkCreate(providedTx) : await folderDAL.transaction(executeBulkCreate);
|
||||||
|
const uniqueParentIds = [...new Set(result.map((folder) => folder.parentId).filter(Boolean))];
|
||||||
|
await Promise.all(uniqueParentIds.map((parentId) => snapshotService.performSnapshot(parentId as string)));
|
||||||
|
|
||||||
|
return {
|
||||||
|
folders: result,
|
||||||
|
count: result.length
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
const deleteManyFolders = async ({
|
||||||
|
projectId,
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
actorOrgId,
|
||||||
|
actorAuthMethod,
|
||||||
|
folders,
|
||||||
|
tx: providedTx,
|
||||||
|
commitChanges
|
||||||
|
}: TDeleteManyFoldersDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
|
||||||
|
const { permission } = await permissionService.getProjectPermission({
|
||||||
|
actor,
|
||||||
|
actorId,
|
||||||
|
projectId,
|
||||||
|
actorAuthMethod,
|
||||||
|
actorOrgId
|
||||||
|
});
|
||||||
|
|
||||||
|
folders.forEach(({ environment, path: secretPath }) => {
|
||||||
|
ForbiddenError.from(permission).throwUnlessCan(
|
||||||
|
ProjectPermissionActions.Delete,
|
||||||
|
subject(ProjectPermissionSub.SecretFolders, { environment, secretPath })
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
const foldersByEnv = folders.reduce(
|
||||||
|
(acc, folder) => {
|
||||||
|
if (!acc[folder.environment]) {
|
||||||
|
acc[folder.environment] = [];
|
||||||
|
}
|
||||||
|
acc[folder.environment].push(folder);
|
||||||
|
return acc;
|
||||||
|
},
|
||||||
|
{} as Record<string, typeof folders>
|
||||||
|
);
|
||||||
|
|
||||||
|
const executeBulkDelete = async (tx: Knex) => {
|
||||||
|
const deletedFolders = [];
|
||||||
|
|
||||||
|
for (const [environment, envFolders] of Object.entries(foldersByEnv)) {
|
||||||
|
const env = await projectEnvDAL.findOne({ projectId, slug: environment });
|
||||||
|
if (!env) {
|
||||||
|
throw new NotFoundError({
|
||||||
|
message: `Environment with slug '${environment}' not found`
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
for (const folderSpec of envFolders) {
|
||||||
|
const { path: secretPath, idOrName } = folderSpec;
|
||||||
|
|
||||||
|
const parentFolder = await folderDAL.findBySecretPath(projectId, environment, secretPath, tx);
|
||||||
|
if (!parentFolder) {
|
||||||
|
throw new NotFoundError({
|
||||||
|
message: `Folder with path '${secretPath}' in environment with slug '${environment}' not found`
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
await $checkFolderPolicy({ projectId, env, parentId: parentFolder.id, idOrName });
|
||||||
|
|
||||||
|
let folderToDelete = await folderDAL
|
||||||
|
.findOne({
|
||||||
|
envId: env.id,
|
||||||
|
name: idOrName,
|
||||||
|
parentId: parentFolder.id,
|
||||||
|
isReserved: false
|
||||||
|
})
|
||||||
|
.catch(() => null);
|
||||||
|
|
||||||
|
if (!folderToDelete && uuidValidate(idOrName)) {
|
||||||
|
folderToDelete = await folderDAL
|
||||||
|
.findOne({
|
||||||
|
envId: env.id,
|
||||||
|
id: idOrName,
|
||||||
|
parentId: parentFolder.id,
|
||||||
|
isReserved: false
|
||||||
|
})
|
||||||
|
.catch(() => null);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!folderToDelete) {
|
||||||
|
throw new NotFoundError({
|
||||||
|
message: `Folder with ID/name '${idOrName}' not found`
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
const [doc] = await folderDAL.delete(
|
||||||
|
{
|
||||||
|
envId: env.id,
|
||||||
|
id: folderToDelete.id,
|
||||||
|
parentId: parentFolder.id,
|
||||||
|
isReserved: false
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
|
||||||
|
const folderVersions = await folderVersionDAL.findLatestFolderVersions([doc.id], tx);
|
||||||
|
|
||||||
|
if (commitChanges) {
|
||||||
|
commitChanges.push({
|
||||||
|
type: CommitType.DELETE,
|
||||||
|
folderVersionId: folderVersions[doc.id].id,
|
||||||
|
folderId: doc.id
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
await folderCommitService.createCommit(
|
||||||
|
{
|
||||||
|
actor: {
|
||||||
|
type: actor,
|
||||||
|
metadata: {
|
||||||
|
id: actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Folder deleted (batch)",
|
||||||
|
folderId: parentFolder.id,
|
||||||
|
changes: [
|
||||||
|
{
|
||||||
|
type: CommitType.DELETE,
|
||||||
|
folderVersionId: folderVersions[doc.id].id,
|
||||||
|
folderId: doc.id
|
||||||
|
}
|
||||||
|
]
|
||||||
|
},
|
||||||
|
tx
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
deletedFolders.push(doc);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return deletedFolders;
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = providedTx ? await executeBulkDelete(providedTx) : await folderDAL.transaction(executeBulkDelete);
|
||||||
|
|
||||||
|
const uniqueParentIds = [...new Set(result.map((folder) => folder.parentId).filter(Boolean))];
|
||||||
|
await Promise.all(uniqueParentIds.map((parentId) => snapshotService.performSnapshot(parentId as string)));
|
||||||
|
|
||||||
|
return {
|
||||||
|
folders: result,
|
||||||
|
count: result.length
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
return {
|
return {
|
||||||
createFolder,
|
createFolder,
|
||||||
updateFolder,
|
updateFolder,
|
||||||
@@ -986,6 +1368,8 @@ export const secretFolderServiceFactory = ({
|
|||||||
getFoldersDeepByEnvs,
|
getFoldersDeepByEnvs,
|
||||||
getProjectEnvironmentsFolders,
|
getProjectEnvironmentsFolders,
|
||||||
getFolderVersionsByIds,
|
getFolderVersionsByIds,
|
||||||
getFolderVersions
|
getFolderVersions,
|
||||||
|
createManyFolders,
|
||||||
|
deleteManyFolders
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,6 +1,8 @@
|
|||||||
import { OrderByDirection, TProjectPermission } from "@app/lib/types";
|
import { OrderByDirection, TProjectPermission } from "@app/lib/types";
|
||||||
import { SecretsOrderBy } from "@app/services/secret/secret-types";
|
import { SecretsOrderBy } from "@app/services/secret/secret-types";
|
||||||
|
|
||||||
|
import { ActorAuthMethod, ActorType } from "../auth/auth-type";
|
||||||
|
|
||||||
export enum ReservedFolders {
|
export enum ReservedFolders {
|
||||||
SecretReplication = "__reserve_replication_"
|
SecretReplication = "__reserve_replication_"
|
||||||
}
|
}
|
||||||
@@ -62,3 +64,30 @@ export type TGetFoldersDeepByEnvsDTO = {
|
|||||||
export type TFindFoldersDeepByParentIdsDTO = {
|
export type TFindFoldersDeepByParentIdsDTO = {
|
||||||
parentIds: string[];
|
parentIds: string[];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export type TCreateManyFoldersDTO = {
|
||||||
|
projectId: string;
|
||||||
|
actor: ActorType;
|
||||||
|
actorId: string;
|
||||||
|
actorAuthMethod: ActorAuthMethod;
|
||||||
|
actorOrgId?: string;
|
||||||
|
folders: Array<{
|
||||||
|
name: string;
|
||||||
|
environment: string;
|
||||||
|
path: string;
|
||||||
|
description?: string;
|
||||||
|
}>;
|
||||||
|
};
|
||||||
|
|
||||||
|
export type TDeleteManyFoldersDTO = {
|
||||||
|
projectId: string;
|
||||||
|
actor: ActorType;
|
||||||
|
actorId: string;
|
||||||
|
actorAuthMethod: ActorAuthMethod;
|
||||||
|
actorOrgId?: string;
|
||||||
|
folders: Array<{
|
||||||
|
environment: string;
|
||||||
|
path: string;
|
||||||
|
idOrName: string;
|
||||||
|
}>;
|
||||||
|
};
|
||||||
|
|||||||
@@ -67,6 +67,7 @@ export const getAllSecretReferences = (maybeSecretReference: string) => {
|
|||||||
export const fnSecretBulkInsert = async ({
|
export const fnSecretBulkInsert = async ({
|
||||||
// TODO: Pick types here
|
// TODO: Pick types here
|
||||||
folderId,
|
folderId,
|
||||||
|
commitChanges,
|
||||||
orgId,
|
orgId,
|
||||||
inputSecrets,
|
inputSecrets,
|
||||||
secretDAL,
|
secretDAL,
|
||||||
@@ -134,28 +135,32 @@ export const fnSecretBulkInsert = async ({
|
|||||||
tx
|
tx
|
||||||
);
|
);
|
||||||
|
|
||||||
const commitChanges = secretVersions
|
const changes = secretVersions
|
||||||
.filter(({ type }) => type === SecretType.Shared)
|
.filter(({ type }) => type === SecretType.Shared)
|
||||||
.map((sv) => ({
|
.map((sv) => ({
|
||||||
type: CommitType.ADD,
|
type: CommitType.ADD,
|
||||||
secretVersionId: sv.id
|
secretVersionId: sv.id
|
||||||
}));
|
}));
|
||||||
|
|
||||||
if (commitChanges.length > 0) {
|
if (changes.length > 0) {
|
||||||
await folderCommitService.createCommit(
|
if (commitChanges) {
|
||||||
{
|
commitChanges.push(...changes);
|
||||||
actor: {
|
} else {
|
||||||
type: actorType || ActorType.PLATFORM,
|
await folderCommitService.createCommit(
|
||||||
metadata: {
|
{
|
||||||
id: actor?.actorId
|
actor: {
|
||||||
}
|
type: actorType || ActorType.PLATFORM,
|
||||||
|
metadata: {
|
||||||
|
id: actor?.actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Secret Created",
|
||||||
|
folderId,
|
||||||
|
changes
|
||||||
},
|
},
|
||||||
message: "Secret Created",
|
tx
|
||||||
folderId,
|
);
|
||||||
changes: commitChanges
|
}
|
||||||
},
|
|
||||||
tx
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
await secretDAL.upsertSecretReferences(
|
await secretDAL.upsertSecretReferences(
|
||||||
@@ -209,6 +214,7 @@ export const fnSecretBulkUpdate = async ({
|
|||||||
tx,
|
tx,
|
||||||
inputSecrets,
|
inputSecrets,
|
||||||
folderId,
|
folderId,
|
||||||
|
commitChanges,
|
||||||
orgId,
|
orgId,
|
||||||
secretDAL,
|
secretDAL,
|
||||||
secretVersionDAL,
|
secretVersionDAL,
|
||||||
@@ -359,28 +365,32 @@ export const fnSecretBulkUpdate = async ({
|
|||||||
{ tx }
|
{ tx }
|
||||||
);
|
);
|
||||||
|
|
||||||
const commitChanges = secretVersions
|
const changes = secretVersions
|
||||||
.filter(({ type }) => type === SecretType.Shared)
|
.filter(({ type }) => type === SecretType.Shared)
|
||||||
.map((sv) => ({
|
.map((sv) => ({
|
||||||
type: CommitType.ADD,
|
type: CommitType.ADD,
|
||||||
isUpdate: true,
|
isUpdate: true,
|
||||||
secretVersionId: sv.id
|
secretVersionId: sv.id
|
||||||
}));
|
}));
|
||||||
if (commitChanges.length > 0) {
|
if (changes.length > 0) {
|
||||||
await folderCommitService.createCommit(
|
if (commitChanges) {
|
||||||
{
|
commitChanges.push(...changes);
|
||||||
actor: {
|
} else {
|
||||||
type: actorType || ActorType.PLATFORM,
|
await folderCommitService.createCommit(
|
||||||
metadata: {
|
{
|
||||||
id: actor?.actorId
|
actor: {
|
||||||
}
|
type: actorType || ActorType.PLATFORM,
|
||||||
|
metadata: {
|
||||||
|
id: actor?.actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Secret Updated",
|
||||||
|
folderId,
|
||||||
|
changes
|
||||||
},
|
},
|
||||||
message: "Secret Updated",
|
tx
|
||||||
folderId,
|
);
|
||||||
changes: commitChanges
|
}
|
||||||
},
|
|
||||||
tx
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return secretsWithTags.map((secret) => ({ ...secret, _id: secret.id }));
|
return secretsWithTags.map((secret) => ({ ...secret, _id: secret.id }));
|
||||||
@@ -395,7 +405,8 @@ export const fnSecretBulkDelete = async ({
|
|||||||
secretDAL,
|
secretDAL,
|
||||||
secretQueueService,
|
secretQueueService,
|
||||||
folderCommitService,
|
folderCommitService,
|
||||||
secretVersionDAL
|
secretVersionDAL,
|
||||||
|
commitChanges
|
||||||
}: TFnSecretBulkDelete) => {
|
}: TFnSecretBulkDelete) => {
|
||||||
const deletedSecrets = await secretDAL.deleteMany(
|
const deletedSecrets = await secretDAL.deleteMany(
|
||||||
inputSecrets.map(({ type, secretKey }) => ({
|
inputSecrets.map(({ type, secretKey }) => ({
|
||||||
@@ -421,27 +432,31 @@ export const fnSecretBulkDelete = async ({
|
|||||||
tx
|
tx
|
||||||
);
|
);
|
||||||
|
|
||||||
const commitChanges = deletedSecrets
|
const changes = deletedSecrets
|
||||||
.filter(({ type }) => type === SecretType.Shared)
|
.filter(({ type }) => type === SecretType.Shared)
|
||||||
.map(({ id }) => ({
|
.map(({ id }) => ({
|
||||||
type: CommitType.DELETE,
|
type: CommitType.DELETE,
|
||||||
secretVersionId: secretVersions[id].id
|
secretVersionId: secretVersions[id].id
|
||||||
}));
|
}));
|
||||||
if (commitChanges.length > 0) {
|
if (changes.length > 0) {
|
||||||
await folderCommitService.createCommit(
|
if (commitChanges) {
|
||||||
{
|
commitChanges.push(...changes);
|
||||||
actor: {
|
} else {
|
||||||
type: actorType || ActorType.PLATFORM,
|
await folderCommitService.createCommit(
|
||||||
metadata: {
|
{
|
||||||
id: actorId
|
actor: {
|
||||||
}
|
type: actorType || ActorType.PLATFORM,
|
||||||
|
metadata: {
|
||||||
|
id: actorId
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message: "Secret Deleted",
|
||||||
|
folderId,
|
||||||
|
changes
|
||||||
},
|
},
|
||||||
message: "Secret Deleted",
|
tx
|
||||||
folderId,
|
);
|
||||||
changes: commitChanges
|
}
|
||||||
},
|
|
||||||
tx
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return deletedSecrets;
|
return deletedSecrets;
|
||||||
|
|||||||
@@ -28,7 +28,7 @@ import { logger } from "@app/lib/logger";
|
|||||||
import { alphaNumericNanoId } from "@app/lib/nanoid";
|
import { alphaNumericNanoId } from "@app/lib/nanoid";
|
||||||
|
|
||||||
import { ActorType } from "../auth/auth-type";
|
import { ActorType } from "../auth/auth-type";
|
||||||
import { TFolderCommitServiceFactory } from "../folder-commit/folder-commit-service";
|
import { TCreateCommitChangeDTO, TFolderCommitServiceFactory } from "../folder-commit/folder-commit-service";
|
||||||
import { TKmsServiceFactory } from "../kms/kms-service";
|
import { TKmsServiceFactory } from "../kms/kms-service";
|
||||||
import { KmsDataKey } from "../kms/kms-types";
|
import { KmsDataKey } from "../kms/kms-types";
|
||||||
import { TProjectEnvDALFactory } from "../project-env/project-env-dal";
|
import { TProjectEnvDALFactory } from "../project-env/project-env-dal";
|
||||||
@@ -1474,8 +1474,10 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
actorOrgId,
|
actorOrgId,
|
||||||
environment,
|
environment,
|
||||||
projectId,
|
projectId,
|
||||||
secrets: inputSecrets
|
secrets: inputSecrets,
|
||||||
}: TCreateManySecretDTO) => {
|
tx: providedTx,
|
||||||
|
commitChanges
|
||||||
|
}: TCreateManySecretDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
|
||||||
const { permission } = await permissionService.getProjectPermission({
|
const { permission } = await permissionService.getProjectPermission({
|
||||||
actor,
|
actor,
|
||||||
actorId,
|
actorId,
|
||||||
@@ -1558,8 +1560,8 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
const { encryptor: secretManagerEncryptor, decryptor: secretManagerDecryptor } =
|
const { encryptor: secretManagerEncryptor, decryptor: secretManagerDecryptor } =
|
||||||
await kmsService.createCipherPairWithDataKey({ type: KmsDataKey.SecretManager, projectId });
|
await kmsService.createCipherPairWithDataKey({ type: KmsDataKey.SecretManager, projectId });
|
||||||
|
|
||||||
const newSecrets = await secretDAL.transaction(async (tx) =>
|
const executeBulkInsert = async (tx: Knex) => {
|
||||||
fnSecretBulkInsert({
|
return fnSecretBulkInsert({
|
||||||
inputSecrets: inputSecrets.map((el) => {
|
inputSecrets: inputSecrets.map((el) => {
|
||||||
const references = secretReferencesGroupByInputSecretKey[el.secretKey]?.nestedReferences;
|
const references = secretReferencesGroupByInputSecretKey[el.secretKey]?.nestedReferences;
|
||||||
|
|
||||||
@@ -1581,6 +1583,7 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
};
|
};
|
||||||
}),
|
}),
|
||||||
folderId,
|
folderId,
|
||||||
|
commitChanges,
|
||||||
orgId: actorOrgId,
|
orgId: actorOrgId,
|
||||||
secretDAL,
|
secretDAL,
|
||||||
resourceMetadataDAL,
|
resourceMetadataDAL,
|
||||||
@@ -1593,8 +1596,13 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
actorId
|
actorId
|
||||||
},
|
},
|
||||||
tx
|
tx
|
||||||
})
|
});
|
||||||
);
|
};
|
||||||
|
|
||||||
|
const newSecrets = providedTx
|
||||||
|
? await executeBulkInsert(providedTx)
|
||||||
|
: await secretDAL.transaction(executeBulkInsert);
|
||||||
|
|
||||||
await secretDAL.invalidateSecretCacheByProjectId(projectId);
|
await secretDAL.invalidateSecretCacheByProjectId(projectId);
|
||||||
await snapshotService.performSnapshot(folderId);
|
await snapshotService.performSnapshot(folderId);
|
||||||
await secretQueueService.syncSecrets({
|
await secretQueueService.syncSecrets({
|
||||||
@@ -1641,8 +1649,10 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
projectId,
|
projectId,
|
||||||
secretPath: defaultSecretPath = "/",
|
secretPath: defaultSecretPath = "/",
|
||||||
secrets: inputSecrets,
|
secrets: inputSecrets,
|
||||||
mode: updateMode
|
mode: updateMode,
|
||||||
}: TUpdateManySecretDTO) => {
|
tx: providedTx,
|
||||||
|
commitChanges
|
||||||
|
}: TUpdateManySecretDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
|
||||||
const { permission } = await permissionService.getProjectPermission({
|
const { permission } = await permissionService.getProjectPermission({
|
||||||
actor,
|
actor,
|
||||||
actorId,
|
actorId,
|
||||||
@@ -1671,18 +1681,20 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
const { encryptor: secretManagerEncryptor, decryptor: secretManagerDecryptor } =
|
const { encryptor: secretManagerEncryptor, decryptor: secretManagerDecryptor } =
|
||||||
await kmsService.createCipherPairWithDataKey({ type: KmsDataKey.SecretManager, projectId });
|
await kmsService.createCipherPairWithDataKey({ type: KmsDataKey.SecretManager, projectId });
|
||||||
|
|
||||||
const updatedSecrets: Array<
|
// Function to execute the bulk update operation
|
||||||
TSecretsV2 & {
|
const executeBulkUpdate = async (tx: Knex) => {
|
||||||
secretPath: string;
|
const updatedSecrets: Array<
|
||||||
tags: {
|
TSecretsV2 & {
|
||||||
id: string;
|
secretPath: string;
|
||||||
slug: string;
|
tags: {
|
||||||
color?: string | null;
|
id: string;
|
||||||
name: string;
|
slug: string;
|
||||||
}[];
|
color?: string | null;
|
||||||
}
|
name: string;
|
||||||
> = [];
|
}[];
|
||||||
await secretDAL.transaction(async (tx) => {
|
}
|
||||||
|
> = [];
|
||||||
|
|
||||||
for await (const folder of folders) {
|
for await (const folder of folders) {
|
||||||
if (!folder) throw new NotFoundError({ message: "Folder not found" });
|
if (!folder) throw new NotFoundError({ message: "Folder not found" });
|
||||||
|
|
||||||
@@ -1801,7 +1813,7 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
{
|
{
|
||||||
operator: "eq",
|
operator: "eq",
|
||||||
field: `${TableName.SecretV2}.key` as "key",
|
field: `${TableName.SecretV2}.key` as "key",
|
||||||
value: el.secretKey
|
value: el.newSecretName as string
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
operator: "eq",
|
operator: "eq",
|
||||||
@@ -1855,6 +1867,7 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
orgId: actorOrgId,
|
orgId: actorOrgId,
|
||||||
folderCommitService,
|
folderCommitService,
|
||||||
tx,
|
tx,
|
||||||
|
commitChanges,
|
||||||
inputSecrets: secretsToUpdate.map((el) => {
|
inputSecrets: secretsToUpdate.map((el) => {
|
||||||
const originalSecret = secretsToUpdateInDBGroupedByKey[el.secretKey][0];
|
const originalSecret = secretsToUpdateInDBGroupedByKey[el.secretKey][0];
|
||||||
const encryptedValue =
|
const encryptedValue =
|
||||||
@@ -1934,7 +1947,13 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
updatedSecrets.push(...bulkInsertedSecrets.map((el) => ({ ...el, secretPath: folder.path })));
|
updatedSecrets.push(...bulkInsertedSecrets.map((el) => ({ ...el, secretPath: folder.path })));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
});
|
|
||||||
|
return updatedSecrets;
|
||||||
|
};
|
||||||
|
|
||||||
|
const updatedSecrets = providedTx
|
||||||
|
? await executeBulkUpdate(providedTx)
|
||||||
|
: await secretDAL.transaction(executeBulkUpdate);
|
||||||
|
|
||||||
await secretDAL.invalidateSecretCacheByProjectId(projectId);
|
await secretDAL.invalidateSecretCacheByProjectId(projectId);
|
||||||
await Promise.allSettled(folders.map((el) => (el?.id ? snapshotService.performSnapshot(el.id) : undefined)));
|
await Promise.allSettled(folders.map((el) => (el?.id ? snapshotService.performSnapshot(el.id) : undefined)));
|
||||||
@@ -1991,8 +2010,10 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
actor,
|
actor,
|
||||||
actorId,
|
actorId,
|
||||||
actorAuthMethod,
|
actorAuthMethod,
|
||||||
actorOrgId
|
actorOrgId,
|
||||||
}: TDeleteManySecretDTO) => {
|
tx: providedTx,
|
||||||
|
commitChanges
|
||||||
|
}: TDeleteManySecretDTO & { tx?: Knex; commitChanges?: TCreateCommitChangeDTO[] }) => {
|
||||||
const { permission } = await permissionService.getProjectPermission({
|
const { permission } = await permissionService.getProjectPermission({
|
||||||
actor,
|
actor,
|
||||||
actorId,
|
actorId,
|
||||||
@@ -2051,24 +2072,29 @@ export const secretV2BridgeServiceFactory = ({
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const executeBulkDelete = async (tx: Knex) => {
|
||||||
|
return fnSecretBulkDelete({
|
||||||
|
secretDAL,
|
||||||
|
secretQueueService,
|
||||||
|
folderCommitService,
|
||||||
|
secretVersionDAL,
|
||||||
|
inputSecrets: inputSecrets.map(({ type, secretKey }) => ({
|
||||||
|
secretKey,
|
||||||
|
type: type || SecretType.Shared
|
||||||
|
})),
|
||||||
|
projectId,
|
||||||
|
folderId,
|
||||||
|
actorId,
|
||||||
|
actorType: actor,
|
||||||
|
commitChanges,
|
||||||
|
tx
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const secretsDeleted = await secretDAL.transaction(async (tx) =>
|
const secretsDeleted = providedTx
|
||||||
fnSecretBulkDelete({
|
? await executeBulkDelete(providedTx)
|
||||||
secretDAL,
|
: await secretDAL.transaction(executeBulkDelete);
|
||||||
secretQueueService,
|
|
||||||
folderCommitService,
|
|
||||||
secretVersionDAL,
|
|
||||||
inputSecrets: inputSecrets.map(({ type, secretKey }) => ({
|
|
||||||
secretKey,
|
|
||||||
type: type || SecretType.Shared
|
|
||||||
})),
|
|
||||||
projectId,
|
|
||||||
folderId,
|
|
||||||
actorId,
|
|
||||||
actorType: actor,
|
|
||||||
tx
|
|
||||||
})
|
|
||||||
);
|
|
||||||
|
|
||||||
await secretDAL.invalidateSecretCacheByProjectId(projectId);
|
await secretDAL.invalidateSecretCacheByProjectId(projectId);
|
||||||
await snapshotService.performSnapshot(folderId);
|
await snapshotService.performSnapshot(folderId);
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ import { SecretsOrderBy } from "@app/services/secret/secret-types";
|
|||||||
import { TSecretFolderDALFactory } from "@app/services/secret-folder/secret-folder-dal";
|
import { TSecretFolderDALFactory } from "@app/services/secret-folder/secret-folder-dal";
|
||||||
import { TSecretTagDALFactory } from "@app/services/secret-tag/secret-tag-dal";
|
import { TSecretTagDALFactory } from "@app/services/secret-tag/secret-tag-dal";
|
||||||
|
|
||||||
import { TFolderCommitServiceFactory } from "../folder-commit/folder-commit-service";
|
import { TCreateCommitChangeDTO, TFolderCommitServiceFactory } from "../folder-commit/folder-commit-service";
|
||||||
import { TResourceMetadataDALFactory } from "../resource-metadata/resource-metadata-dal";
|
import { TResourceMetadataDALFactory } from "../resource-metadata/resource-metadata-dal";
|
||||||
import { ResourceMetadataDTO } from "../resource-metadata/resource-metadata-schema";
|
import { ResourceMetadataDTO } from "../resource-metadata/resource-metadata-schema";
|
||||||
import { TSecretV2BridgeDALFactory } from "./secret-v2-bridge-dal";
|
import { TSecretV2BridgeDALFactory } from "./secret-v2-bridge-dal";
|
||||||
@@ -167,6 +167,7 @@ export type TFnSecretBulkInsert = {
|
|||||||
folderId: string;
|
folderId: string;
|
||||||
orgId: string;
|
orgId: string;
|
||||||
tx?: Knex;
|
tx?: Knex;
|
||||||
|
commitChanges?: TCreateCommitChangeDTO[];
|
||||||
inputSecrets: Array<
|
inputSecrets: Array<
|
||||||
Omit<TSecretsV2Insert, "folderId"> & {
|
Omit<TSecretsV2Insert, "folderId"> & {
|
||||||
tagIds?: string[];
|
tagIds?: string[];
|
||||||
@@ -214,6 +215,7 @@ export type TFnSecretBulkUpdate = {
|
|||||||
actorId?: string;
|
actorId?: string;
|
||||||
};
|
};
|
||||||
tx?: Knex;
|
tx?: Knex;
|
||||||
|
commitChanges?: TCreateCommitChangeDTO[];
|
||||||
};
|
};
|
||||||
|
|
||||||
export type TFnSecretBulkDelete = {
|
export type TFnSecretBulkDelete = {
|
||||||
@@ -223,6 +225,7 @@ export type TFnSecretBulkDelete = {
|
|||||||
actorId: string;
|
actorId: string;
|
||||||
actorType?: string;
|
actorType?: string;
|
||||||
tx?: Knex;
|
tx?: Knex;
|
||||||
|
commitChanges?: TCreateCommitChangeDTO[];
|
||||||
secretDAL: Pick<TSecretV2BridgeDALFactory, "deleteMany">;
|
secretDAL: Pick<TSecretV2BridgeDALFactory, "deleteMany">;
|
||||||
secretQueueService: {
|
secretQueueService: {
|
||||||
removeSecretReminder: (data: TRemoveSecretReminderDTO, tx?: Knex) => Promise<void>;
|
removeSecretReminder: (data: TRemoveSecretReminderDTO, tx?: Knex) => Promise<void>;
|
||||||
|
|||||||
@@ -544,3 +544,33 @@ export enum SecretProtectionType {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export type TStartSecretsV2MigrationDTO = TProjectPermission;
|
export type TStartSecretsV2MigrationDTO = TProjectPermission;
|
||||||
|
|
||||||
|
export type TProcessNewCommitRawDTO = {
|
||||||
|
secrets: {
|
||||||
|
create?: {
|
||||||
|
secretKey: string;
|
||||||
|
secretValue: string;
|
||||||
|
secretComment?: string;
|
||||||
|
skipMultilineEncoding?: boolean;
|
||||||
|
tagIds?: string[];
|
||||||
|
secretMetadata?: ResourceMetadataDTO;
|
||||||
|
metadata?: { source?: string };
|
||||||
|
}[];
|
||||||
|
update?: {
|
||||||
|
secretKey: string;
|
||||||
|
newSecretKey?: string;
|
||||||
|
secretValue?: string;
|
||||||
|
secretComment?: string;
|
||||||
|
skipMultilineEncoding?: boolean;
|
||||||
|
tagIds?: string[];
|
||||||
|
secretMetadata?: ResourceMetadataDTO;
|
||||||
|
metadata?: { source?: string };
|
||||||
|
}[];
|
||||||
|
delete?: { secretKey: string }[];
|
||||||
|
};
|
||||||
|
folders: {
|
||||||
|
create?: { folderName: string; description?: string }[];
|
||||||
|
update?: { folderName: string; description?: string; id: string }[];
|
||||||
|
delete?: { folderName: string; id: string }[];
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|||||||
@@ -9,6 +9,8 @@ export type TSecretFolder = {
|
|||||||
name: string;
|
name: string;
|
||||||
description?: string;
|
description?: string;
|
||||||
parentId?: string | null;
|
parentId?: string | null;
|
||||||
|
isPending?: boolean;
|
||||||
|
pendingAction?: string;
|
||||||
};
|
};
|
||||||
|
|
||||||
export type TSecretFolderWithPath = TSecretFolder & { path: string };
|
export type TSecretFolderWithPath = TSecretFolder & { path: string };
|
||||||
|
|||||||
@@ -2,6 +2,10 @@ import { MutationOptions, useMutation, useQueryClient } from "@tanstack/react-qu
|
|||||||
|
|
||||||
import { apiRequest } from "@app/config/request";
|
import { apiRequest } from "@app/config/request";
|
||||||
import { dashboardKeys } from "@app/hooks/api/dashboard/queries";
|
import { dashboardKeys } from "@app/hooks/api/dashboard/queries";
|
||||||
|
import {
|
||||||
|
PendingChanges,
|
||||||
|
PendingSecretUpdate
|
||||||
|
} from "@app/pages/secret-manager/SecretDashboardPage/SecretMainPage.store";
|
||||||
|
|
||||||
import { commitKeys } from "../folderCommits/queries";
|
import { commitKeys } from "../folderCommits/queries";
|
||||||
import { secretApprovalRequestKeys } from "../secretApprovalRequest/queries";
|
import { secretApprovalRequestKeys } from "../secretApprovalRequest/queries";
|
||||||
@@ -420,3 +424,100 @@ export const useBackfillSecretReference = () =>
|
|||||||
return data.message;
|
return data.message;
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
export const useCreateCommit = () => {
|
||||||
|
const queryClient = useQueryClient();
|
||||||
|
return useMutation<
|
||||||
|
object,
|
||||||
|
object,
|
||||||
|
{
|
||||||
|
workspaceId: string;
|
||||||
|
environment: string;
|
||||||
|
secretPath: string;
|
||||||
|
pendingChanges: PendingChanges;
|
||||||
|
message: string;
|
||||||
|
}
|
||||||
|
>({
|
||||||
|
mutationFn: async ({ workspaceId, environment, secretPath, pendingChanges, message }) => {
|
||||||
|
const transformedSecretUpdates = pendingChanges.secrets
|
||||||
|
.filter((change) => change.type === "update")
|
||||||
|
.map((change: PendingSecretUpdate) => {
|
||||||
|
const updatePayload: any = {
|
||||||
|
secretKey: change.secretKey
|
||||||
|
};
|
||||||
|
|
||||||
|
// Only include fields that actually changed
|
||||||
|
if (change.newSecretName) {
|
||||||
|
updatePayload.newSecretName = change.newSecretName;
|
||||||
|
}
|
||||||
|
if (change.secretValue !== undefined) {
|
||||||
|
updatePayload.secretValue = change.secretValue;
|
||||||
|
}
|
||||||
|
if (change.secretComment !== undefined) {
|
||||||
|
updatePayload.secretComment = change.secretComment;
|
||||||
|
}
|
||||||
|
if (change.skipMultilineEncoding !== undefined) {
|
||||||
|
updatePayload.skipMultilineEncoding = change.skipMultilineEncoding;
|
||||||
|
}
|
||||||
|
if (change.tags) {
|
||||||
|
updatePayload.tagIds = change.tags.map((tag) => tag.id);
|
||||||
|
}
|
||||||
|
if (change.secretMetadata) {
|
||||||
|
updatePayload.secretMetadata = change.secretMetadata;
|
||||||
|
}
|
||||||
|
|
||||||
|
return updatePayload;
|
||||||
|
});
|
||||||
|
const { data } = await apiRequest.post("/api/v1/pit/batch/commit", {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
changes: {
|
||||||
|
secrets: {
|
||||||
|
create:
|
||||||
|
pendingChanges.secrets
|
||||||
|
.filter((change) => change.type === "create")
|
||||||
|
.map((change) => ({
|
||||||
|
secretKey: change.secretKey,
|
||||||
|
secretValue: change.secretValue,
|
||||||
|
secretComment: change.secretComment,
|
||||||
|
skipMultilineEncoding: change.skipMultilineEncoding,
|
||||||
|
tagIds: change.tags?.map((tag) => tag.id),
|
||||||
|
secretMetadata: change.secretMetadata
|
||||||
|
})) || [],
|
||||||
|
update: transformedSecretUpdates,
|
||||||
|
delete: pendingChanges.secrets.filter((change) => change.type === "delete") || []
|
||||||
|
},
|
||||||
|
folders: {
|
||||||
|
create: pendingChanges.folders.filter((change) => change.type === "create") || [],
|
||||||
|
update: pendingChanges.folders.filter((change) => change.type === "update") || [],
|
||||||
|
delete: pendingChanges.folders.filter((change) => change.type === "delete") || []
|
||||||
|
}
|
||||||
|
},
|
||||||
|
message
|
||||||
|
});
|
||||||
|
return data;
|
||||||
|
},
|
||||||
|
onSuccess: (_, { workspaceId, environment, secretPath }) => {
|
||||||
|
queryClient.invalidateQueries({
|
||||||
|
queryKey: dashboardKeys.getDashboardSecrets({ projectId: workspaceId, secretPath })
|
||||||
|
});
|
||||||
|
queryClient.invalidateQueries({
|
||||||
|
queryKey: secretKeys.getProjectSecret({ workspaceId, environment, secretPath })
|
||||||
|
});
|
||||||
|
queryClient.invalidateQueries({
|
||||||
|
queryKey: secretSnapshotKeys.list({ environment, workspaceId, directory: secretPath })
|
||||||
|
});
|
||||||
|
queryClient.invalidateQueries({
|
||||||
|
queryKey: secretSnapshotKeys.count({ environment, workspaceId, directory: secretPath })
|
||||||
|
});
|
||||||
|
queryClient.invalidateQueries({
|
||||||
|
queryKey: commitKeys.count({ workspaceId, environment, directory: secretPath })
|
||||||
|
});
|
||||||
|
queryClient.invalidateQueries({
|
||||||
|
queryKey: commitKeys.history({ workspaceId, environment, directory: secretPath })
|
||||||
|
});
|
||||||
|
queryClient.invalidateQueries({ queryKey: secretApprovalRequestKeys.count({ workspaceId }) });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|||||||
@@ -66,6 +66,8 @@ export type SecretV3RawSanitized = {
|
|||||||
isRotatedSecret?: boolean;
|
isRotatedSecret?: boolean;
|
||||||
secretReminderRecipients?: SecretReminderRecipient[];
|
secretReminderRecipients?: SecretReminderRecipient[];
|
||||||
rotationId?: string;
|
rotationId?: string;
|
||||||
|
isPending?: boolean;
|
||||||
|
pendingAction?: "create" | "update" | "delete";
|
||||||
};
|
};
|
||||||
|
|
||||||
export type SecretV3Raw = {
|
export type SecretV3Raw = {
|
||||||
|
|||||||
+1
-1
@@ -72,7 +72,7 @@ export const generateCommitText = (commits: { op: CommitType }[] = [], isReplica
|
|||||||
if (score[CommitType.DELETE])
|
if (score[CommitType.DELETE])
|
||||||
text.push(
|
text.push(
|
||||||
<span className="deleted-commit">
|
<span className="deleted-commit">
|
||||||
{Boolean(text.length) && "and"}
|
{Boolean(text.length) && " and "}
|
||||||
{score[CommitType.DELETE]} Secret{score[CommitType.DELETE] !== 1 && "s"}
|
{score[CommitType.DELETE]} Secret{score[CommitType.DELETE] !== 1 && "s"}
|
||||||
<span className="text-red-600"> Deleted</span>
|
<span className="text-red-600"> Deleted</span>
|
||||||
</span>
|
</span>
|
||||||
|
|||||||
@@ -1,3 +1,4 @@
|
|||||||
|
/* eslint-disable no-case-declarations */
|
||||||
import { useCallback, useEffect, useMemo, useState } from "react";
|
import { useCallback, useEffect, useMemo, useState } from "react";
|
||||||
import { Helmet } from "react-helmet";
|
import { Helmet } from "react-helmet";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
@@ -46,12 +47,14 @@ import { useGetProjectSecretsDetails } from "@app/hooks/api/dashboard";
|
|||||||
import { DashboardSecretsOrderBy } from "@app/hooks/api/dashboard/types";
|
import { DashboardSecretsOrderBy } from "@app/hooks/api/dashboard/types";
|
||||||
import { useGetFolderCommitsCount } from "@app/hooks/api/folderCommits";
|
import { useGetFolderCommitsCount } from "@app/hooks/api/folderCommits";
|
||||||
import { OrderByDirection } from "@app/hooks/api/generic/types";
|
import { OrderByDirection } from "@app/hooks/api/generic/types";
|
||||||
|
import { useCreateCommit } from "@app/hooks/api/secrets/mutations";
|
||||||
import { hasSecretReadValueOrDescribePermission } from "@app/lib/fn/permission";
|
import { hasSecretReadValueOrDescribePermission } from "@app/lib/fn/permission";
|
||||||
import { SecretRotationListView } from "@app/pages/secret-manager/SecretDashboardPage/components/SecretRotationListView";
|
import { SecretRotationListView } from "@app/pages/secret-manager/SecretDashboardPage/components/SecretRotationListView";
|
||||||
|
|
||||||
import { SecretTableResourceCount } from "../OverviewPage/components/SecretTableResourceCount";
|
import { SecretTableResourceCount } from "../OverviewPage/components/SecretTableResourceCount";
|
||||||
import { SecretV2MigrationSection } from "../OverviewPage/components/SecretV2MigrationSection";
|
import { SecretV2MigrationSection } from "../OverviewPage/components/SecretV2MigrationSection";
|
||||||
import { ActionBar } from "./components/ActionBar";
|
import { ActionBar } from "./components/ActionBar";
|
||||||
|
import { CommitForm } from "./components/CommitForm";
|
||||||
import { CreateSecretForm } from "./components/CreateSecretForm";
|
import { CreateSecretForm } from "./components/CreateSecretForm";
|
||||||
import { DynamicSecretListView } from "./components/DynamicSecretListView";
|
import { DynamicSecretListView } from "./components/DynamicSecretListView";
|
||||||
import { FolderListView } from "./components/FolderListView";
|
import { FolderListView } from "./components/FolderListView";
|
||||||
@@ -61,8 +64,11 @@ import { SecretImportListView } from "./components/SecretImportListView";
|
|||||||
import { SecretListView, SecretNoAccessListView } from "./components/SecretListView";
|
import { SecretListView, SecretNoAccessListView } from "./components/SecretListView";
|
||||||
import { SnapshotView } from "./components/SnapshotView";
|
import { SnapshotView } from "./components/SnapshotView";
|
||||||
import {
|
import {
|
||||||
|
PendingChanges,
|
||||||
PopUpNames,
|
PopUpNames,
|
||||||
StoreProvider,
|
StoreProvider,
|
||||||
|
useBatchMode,
|
||||||
|
useBatchModeActions,
|
||||||
usePopUpAction,
|
usePopUpAction,
|
||||||
usePopUpState,
|
usePopUpState,
|
||||||
useSelectedSecretActions,
|
useSelectedSecretActions,
|
||||||
@@ -90,8 +96,11 @@ const Page = () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
const { permission } = useProjectPermission();
|
const { permission } = useProjectPermission();
|
||||||
|
const { mutateAsync: createCommit } = useCreateCommit();
|
||||||
|
|
||||||
const [isVisible, setIsVisible] = useState(false);
|
const [isVisible, setIsVisible] = useState(false);
|
||||||
|
const { isBatchMode, pendingChanges } = useBatchMode();
|
||||||
|
const { loadPendingChanges, setExistingKeys } = useBatchModeActions();
|
||||||
|
|
||||||
const {
|
const {
|
||||||
offset,
|
offset,
|
||||||
@@ -121,6 +130,22 @@ const Page = () => {
|
|||||||
const projectSlug = currentWorkspace?.slug || "";
|
const projectSlug = currentWorkspace?.slug || "";
|
||||||
const secretPath = (routerQueryParams.secretPath as string) || "/";
|
const secretPath = (routerQueryParams.secretPath as string) || "/";
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (isBatchMode && workspaceId && environment && secretPath) {
|
||||||
|
loadPendingChanges({ workspaceId, environment, secretPath });
|
||||||
|
}
|
||||||
|
}, [isBatchMode, workspaceId, environment, secretPath, loadPendingChanges]);
|
||||||
|
|
||||||
|
const handleCreateCommit = (changes: PendingChanges, message: string) => {
|
||||||
|
createCommit({
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
pendingChanges: changes,
|
||||||
|
message
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
const canReadSecret = hasSecretReadValueOrDescribePermission(
|
const canReadSecret = hasSecretReadValueOrDescribePermission(
|
||||||
permission,
|
permission,
|
||||||
ProjectPermissionSecretActions.DescribeSecret,
|
ProjectPermissionSecretActions.DescribeSecret,
|
||||||
@@ -350,6 +375,16 @@ const Page = () => {
|
|||||||
noAccessSecretCount
|
noAccessSecretCount
|
||||||
);
|
);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (data && isBatchMode) {
|
||||||
|
const existingSecretKeys = [...(secrets?.map((s) => s.key) || [])];
|
||||||
|
|
||||||
|
const existingFolderNames = folders?.map((f) => f.name) || [];
|
||||||
|
|
||||||
|
setExistingKeys(existingSecretKeys, existingFolderNames);
|
||||||
|
}
|
||||||
|
}, [data, isBatchMode, setExistingKeys, secrets, importedSecrets, folders]);
|
||||||
|
|
||||||
const handleSortToggle = () =>
|
const handleSortToggle = () =>
|
||||||
setOrderDirection((state) =>
|
setOrderDirection((state) =>
|
||||||
state === OrderByDirection.ASC ? OrderByDirection.DESC : OrderByDirection.ASC
|
state === OrderByDirection.ASC ? OrderByDirection.DESC : OrderByDirection.ASC
|
||||||
@@ -476,6 +511,134 @@ const Page = () => {
|
|||||||
setFilter(defaultFilterState);
|
setFilter(defaultFilterState);
|
||||||
setDebouncedSearchFilter("");
|
setDebouncedSearchFilter("");
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const getMergedSecretsWithPending = () => {
|
||||||
|
if (!isBatchMode || pendingChanges.secrets.length === 0) {
|
||||||
|
return secrets;
|
||||||
|
}
|
||||||
|
|
||||||
|
const mergedSecrets = [...(secrets || [])];
|
||||||
|
|
||||||
|
pendingChanges.secrets.forEach((change) => {
|
||||||
|
switch (change.type) {
|
||||||
|
case "create":
|
||||||
|
mergedSecrets.unshift({
|
||||||
|
id: change.id,
|
||||||
|
key: change.secretKey,
|
||||||
|
value: change.secretValue,
|
||||||
|
comment: change.secretComment || "",
|
||||||
|
skipMultilineEncoding: change.skipMultilineEncoding || false,
|
||||||
|
tags: change.tags?.map((tag) => ({ id: tag.id, slug: tag.slug })) || [],
|
||||||
|
secretMetadata: change.secretMetadata || [],
|
||||||
|
createdAt: new Date().toISOString(),
|
||||||
|
updatedAt: new Date().toISOString(),
|
||||||
|
version: 1,
|
||||||
|
isPending: true,
|
||||||
|
pendingAction: "create"
|
||||||
|
} as any);
|
||||||
|
break;
|
||||||
|
|
||||||
|
case "update":
|
||||||
|
const updateIndex = mergedSecrets.findIndex((s) => s.key === change.secretKey);
|
||||||
|
if (updateIndex >= 0) {
|
||||||
|
mergedSecrets[updateIndex] = {
|
||||||
|
...mergedSecrets[updateIndex],
|
||||||
|
key: change.newSecretName || change.secretKey,
|
||||||
|
value:
|
||||||
|
change.secretValue !== undefined
|
||||||
|
? change.secretValue
|
||||||
|
: mergedSecrets[updateIndex].value,
|
||||||
|
comment:
|
||||||
|
change.secretComment !== undefined
|
||||||
|
? change.secretComment
|
||||||
|
: mergedSecrets[updateIndex].comment,
|
||||||
|
skipMultilineEncoding:
|
||||||
|
change.skipMultilineEncoding !== undefined
|
||||||
|
? change.skipMultilineEncoding
|
||||||
|
: mergedSecrets[updateIndex].skipMultilineEncoding,
|
||||||
|
secretMetadata: change.secretMetadata || mergedSecrets[updateIndex].secretMetadata,
|
||||||
|
isPending: true,
|
||||||
|
pendingAction: "update"
|
||||||
|
};
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
case "delete":
|
||||||
|
const deleteIndex = mergedSecrets.findIndex((s) => s.key === change.secretKey);
|
||||||
|
if (deleteIndex >= 0) {
|
||||||
|
mergedSecrets[deleteIndex] = {
|
||||||
|
...mergedSecrets[deleteIndex],
|
||||||
|
isPending: true,
|
||||||
|
pendingAction: "delete"
|
||||||
|
};
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
default:
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
return mergedSecrets;
|
||||||
|
};
|
||||||
|
|
||||||
|
const getMergedFoldersWithPending = () => {
|
||||||
|
if (!isBatchMode || pendingChanges.folders.length === 0) {
|
||||||
|
return folders;
|
||||||
|
}
|
||||||
|
|
||||||
|
const mergedFolders = [...(folders || [])];
|
||||||
|
|
||||||
|
pendingChanges.folders.forEach((change) => {
|
||||||
|
switch (change.type) {
|
||||||
|
case "create":
|
||||||
|
mergedFolders.unshift({
|
||||||
|
id: change.id,
|
||||||
|
name: change.folderName,
|
||||||
|
description: change.description,
|
||||||
|
parentId: null,
|
||||||
|
isPending: true,
|
||||||
|
pendingAction: "create"
|
||||||
|
} as any);
|
||||||
|
break;
|
||||||
|
|
||||||
|
case "update":
|
||||||
|
const updateIndex = mergedFolders.findIndex((f) => f.id === change.id);
|
||||||
|
if (updateIndex >= 0) {
|
||||||
|
mergedFolders[updateIndex] = {
|
||||||
|
...mergedFolders[updateIndex],
|
||||||
|
name: change.folderName,
|
||||||
|
description:
|
||||||
|
change.description !== undefined
|
||||||
|
? change.description
|
||||||
|
: mergedFolders[updateIndex].description,
|
||||||
|
isPending: true,
|
||||||
|
pendingAction: "update"
|
||||||
|
};
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
case "delete":
|
||||||
|
const deleteIndex = mergedFolders.findIndex((f) => f.id === change.id);
|
||||||
|
if (deleteIndex >= 0) {
|
||||||
|
mergedFolders[deleteIndex] = {
|
||||||
|
...mergedFolders[deleteIndex],
|
||||||
|
isPending: true,
|
||||||
|
pendingAction: "delete"
|
||||||
|
};
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
|
default:
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
return mergedFolders;
|
||||||
|
};
|
||||||
|
|
||||||
|
const mergedSecrets = getMergedSecretsWithPending();
|
||||||
|
const mergedFolders = getMergedFoldersWithPending();
|
||||||
return (
|
return (
|
||||||
<div className="container mx-auto flex max-w-7xl flex-col text-mineshaft-50 dark:[color-scheme:dark]">
|
<div className="container mx-auto flex max-w-7xl flex-col text-mineshaft-50 dark:[color-scheme:dark]">
|
||||||
<SecretV2MigrationSection />
|
<SecretV2MigrationSection />
|
||||||
@@ -487,6 +650,7 @@ const Page = () => {
|
|||||||
projectSlug={projectSlug}
|
projectSlug={projectSlug}
|
||||||
secretPath={secretPath}
|
secretPath={secretPath}
|
||||||
isVisible={isVisible}
|
isVisible={isVisible}
|
||||||
|
isBatchMode={isBatchMode}
|
||||||
filter={filter}
|
filter={filter}
|
||||||
tags={tags}
|
tags={tags}
|
||||||
onVisibilityToggle={handleToggleVisibility}
|
onVisibilityToggle={handleToggleVisibility}
|
||||||
@@ -559,9 +723,9 @@ const Page = () => {
|
|||||||
importedSecrets={importedSecrets}
|
importedSecrets={importedSecrets}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
{Boolean(folders?.length) && (
|
{Boolean(mergedFolders?.length) && (
|
||||||
<FolderListView
|
<FolderListView
|
||||||
folders={folders}
|
folders={mergedFolders}
|
||||||
environment={environment}
|
environment={environment}
|
||||||
workspaceId={workspaceId}
|
workspaceId={workspaceId}
|
||||||
secretPath={secretPath}
|
secretPath={secretPath}
|
||||||
@@ -579,9 +743,9 @@ const Page = () => {
|
|||||||
{canReadSecretRotations && Boolean(secretRotations?.length) && (
|
{canReadSecretRotations && Boolean(secretRotations?.length) && (
|
||||||
<SecretRotationListView secretRotations={secretRotations} />
|
<SecretRotationListView secretRotations={secretRotations} />
|
||||||
)}
|
)}
|
||||||
{canReadSecret && Boolean(secrets?.length) && (
|
{canReadSecret && Boolean(mergedSecrets?.length) && (
|
||||||
<SecretListView
|
<SecretListView
|
||||||
secrets={secrets}
|
secrets={mergedSecrets}
|
||||||
tags={tags}
|
tags={tags}
|
||||||
isVisible={isVisible}
|
isVisible={isVisible}
|
||||||
environment={environment}
|
environment={environment}
|
||||||
@@ -592,6 +756,17 @@ const Page = () => {
|
|||||||
usedBySecretSyncs={usedBySecretSyncs}
|
usedBySecretSyncs={usedBySecretSyncs}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
|
{(pendingChanges.secrets.length > 0 || pendingChanges.folders.length > 0) && (
|
||||||
|
<CommitForm
|
||||||
|
onCommit={async (changes, commitMessage) => {
|
||||||
|
await handleCreateCommit(changes, commitMessage);
|
||||||
|
}}
|
||||||
|
environment={environment}
|
||||||
|
workspaceId={workspaceId}
|
||||||
|
secretPath={secretPath}
|
||||||
|
isCommitting={false}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
{noAccessSecretCount > 0 && <SecretNoAccessListView count={noAccessSecretCount} />}
|
{noAccessSecretCount > 0 && <SecretNoAccessListView count={noAccessSecretCount} />}
|
||||||
{!canReadSecret &&
|
{!canReadSecret &&
|
||||||
!canReadDynamicSecret &&
|
!canReadDynamicSecret &&
|
||||||
@@ -633,6 +808,7 @@ const Page = () => {
|
|||||||
secretPath={secretPath}
|
secretPath={secretPath}
|
||||||
autoCapitalize={currentWorkspace?.autoCapitalization}
|
autoCapitalize={currentWorkspace?.autoCapitalization}
|
||||||
isProtectedBranch={isProtectedBranch}
|
isProtectedBranch={isProtectedBranch}
|
||||||
|
isBatchMode={isBatchMode}
|
||||||
/>
|
/>
|
||||||
</ModalContent>
|
</ModalContent>
|
||||||
</Modal>
|
</Modal>
|
||||||
|
|||||||
@@ -1,3 +1,4 @@
|
|||||||
|
/* eslint-disable no-nested-ternary */
|
||||||
import { createContext, ReactNode, useContext, useEffect, useRef } from "react";
|
import { createContext, ReactNode, useContext, useEffect, useRef } from "react";
|
||||||
import { useRouter } from "@tanstack/react-router";
|
import { useRouter } from "@tanstack/react-router";
|
||||||
import { createStore, StateCreator, StoreApi, useStore } from "zustand";
|
import { createStore, StateCreator, StoreApi, useStore } from "zustand";
|
||||||
@@ -8,6 +9,158 @@ import { SecretV3RawSanitized } from "@app/hooks/api/secrets/types";
|
|||||||
// akhilmhdh: Don't remove this file if ur thinking why use zustand just for selected selects state
|
// akhilmhdh: Don't remove this file if ur thinking why use zustand just for selected selects state
|
||||||
// This is first step and the whole secret crud will be moved to this global page scope state
|
// This is first step and the whole secret crud will be moved to this global page scope state
|
||||||
// this will allow more stuff like undo grouping stuffs etc
|
// this will allow more stuff like undo grouping stuffs etc
|
||||||
|
|
||||||
|
// Base interface for all pending changes
|
||||||
|
export interface BasePendingChange {
|
||||||
|
id: string;
|
||||||
|
timestamp: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Secret-related change types
|
||||||
|
export interface PendingSecretCreate extends BasePendingChange {
|
||||||
|
resourceType: "secret";
|
||||||
|
type: "create";
|
||||||
|
secretKey: string;
|
||||||
|
secretValue: string;
|
||||||
|
secretComment?: string;
|
||||||
|
skipMultilineEncoding?: boolean;
|
||||||
|
tags?: { id: string; slug: string }[];
|
||||||
|
secretMetadata?: { key: string; value: string }[];
|
||||||
|
originalKey?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface PendingSecretUpdate extends BasePendingChange {
|
||||||
|
resourceType: "secret";
|
||||||
|
type: "update";
|
||||||
|
secretKey: string;
|
||||||
|
newSecretName?: string;
|
||||||
|
originalValue?: string;
|
||||||
|
secretValue?: string;
|
||||||
|
originalComment?: string;
|
||||||
|
secretComment?: string;
|
||||||
|
originalSkipMultilineEncoding?: boolean;
|
||||||
|
skipMultilineEncoding?: boolean;
|
||||||
|
originalTags?: { id: string; slug: string }[];
|
||||||
|
tags?: { id: string; slug: string }[];
|
||||||
|
originalSecretMetadata?: { key: string; value: string }[];
|
||||||
|
secretMetadata?: { key: string; value: string }[];
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface PendingSecretDelete extends BasePendingChange {
|
||||||
|
resourceType: "secret";
|
||||||
|
type: "delete";
|
||||||
|
secretKey: string;
|
||||||
|
secretValue: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Folder-related change types
|
||||||
|
export interface PendingFolderCreate extends BasePendingChange {
|
||||||
|
resourceType: "folder";
|
||||||
|
type: "create";
|
||||||
|
id: string;
|
||||||
|
folderName: string;
|
||||||
|
description?: string;
|
||||||
|
parentPath: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface PendingFolderUpdate extends BasePendingChange {
|
||||||
|
resourceType: "folder";
|
||||||
|
type: "update";
|
||||||
|
originalFolderName: string;
|
||||||
|
folderName: string;
|
||||||
|
id: string;
|
||||||
|
originalDescription?: string;
|
||||||
|
description?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface PendingFolderDelete extends BasePendingChange {
|
||||||
|
resourceType: "folder";
|
||||||
|
type: "delete";
|
||||||
|
id: string;
|
||||||
|
folderName: string;
|
||||||
|
folderPath: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Union types for each resource
|
||||||
|
export type PendingSecretChange = PendingSecretCreate | PendingSecretUpdate | PendingSecretDelete;
|
||||||
|
export type PendingFolderChange = PendingFolderCreate | PendingFolderUpdate | PendingFolderDelete;
|
||||||
|
export type PendingChange = PendingSecretChange | PendingFolderChange;
|
||||||
|
|
||||||
|
// Grouped changes for better processing
|
||||||
|
export interface PendingChanges {
|
||||||
|
secrets: PendingSecretChange[];
|
||||||
|
folders: PendingFolderChange[];
|
||||||
|
}
|
||||||
|
|
||||||
|
// Context interface for batch operations
|
||||||
|
export interface BatchContext {
|
||||||
|
workspaceId: string;
|
||||||
|
environment: string;
|
||||||
|
secretPath: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
const STORAGE_KEY = "infisical_pending_changes";
|
||||||
|
|
||||||
|
const generateContextKey = (workspaceId: string, environment: string, secretPath: string) => {
|
||||||
|
return `${workspaceId}_${environment}_${secretPath}`;
|
||||||
|
};
|
||||||
|
|
||||||
|
const savePendingChangesToStorage = (
|
||||||
|
changes: PendingChanges,
|
||||||
|
workspaceId: string,
|
||||||
|
environment: string,
|
||||||
|
secretPath: string
|
||||||
|
) => {
|
||||||
|
const key = `${STORAGE_KEY}_${generateContextKey(workspaceId, environment, secretPath)}`;
|
||||||
|
try {
|
||||||
|
localStorage.setItem(key, JSON.stringify(changes));
|
||||||
|
} catch (error) {
|
||||||
|
console.warn("Failed to save pending changes to localStorage:", error);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const loadPendingChangesFromStorage = (
|
||||||
|
workspaceId: string,
|
||||||
|
environment: string,
|
||||||
|
secretPath: string
|
||||||
|
): PendingChanges => {
|
||||||
|
const key = `${STORAGE_KEY}_${generateContextKey(workspaceId, environment, secretPath)}`;
|
||||||
|
const stored = localStorage.getItem(key);
|
||||||
|
if (!stored) return { secrets: [], folders: [] };
|
||||||
|
|
||||||
|
try {
|
||||||
|
const parsed = JSON.parse(stored);
|
||||||
|
if (Array.isArray(parsed)) {
|
||||||
|
return {
|
||||||
|
secrets: parsed.filter(
|
||||||
|
(change: any) => !change.resourceType || change.resourceType === "secret"
|
||||||
|
),
|
||||||
|
folders: []
|
||||||
|
};
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
secrets: parsed.secrets || [],
|
||||||
|
folders: parsed.folders || []
|
||||||
|
};
|
||||||
|
} catch (error) {
|
||||||
|
console.warn("Failed to parse pending changes from localStorage:", error);
|
||||||
|
return { secrets: [], folders: [] };
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const clearPendingChangesFromStorage = (
|
||||||
|
workspaceId: string,
|
||||||
|
environment: string,
|
||||||
|
secretPath: string
|
||||||
|
) => {
|
||||||
|
const key = `${STORAGE_KEY}_${generateContextKey(workspaceId, environment, secretPath)}`;
|
||||||
|
try {
|
||||||
|
localStorage.removeItem(key);
|
||||||
|
} catch (error) {
|
||||||
|
console.warn("Failed to clear pending changes from localStorage:", error);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
type SelectedSecretState = {
|
type SelectedSecretState = {
|
||||||
selectedSecret: Record<string, SecretV3RawSanitized>;
|
selectedSecret: Record<string, SecretV3RawSanitized>;
|
||||||
action: {
|
action: {
|
||||||
@@ -16,14 +169,16 @@ type SelectedSecretState = {
|
|||||||
set: (secrets: Record<string, SecretV3RawSanitized>) => void;
|
set: (secrets: Record<string, SecretV3RawSanitized>) => void;
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
const createSelectedSecretStore: StateCreator<SelectedSecretState> = (set) => ({
|
|
||||||
|
const createSelectedSecretStore: StateCreator<CombinedState, [], [], SelectedSecretState> = (
|
||||||
|
set
|
||||||
|
) => ({
|
||||||
selectedSecret: {},
|
selectedSecret: {},
|
||||||
action: {
|
action: {
|
||||||
toggle: (secret) =>
|
toggle: (secret) =>
|
||||||
set((state) => {
|
set((state) => {
|
||||||
const isChecked = Boolean(state.selectedSecret?.[secret.id]);
|
const isChecked = Boolean(state.selectedSecret?.[secret.id]);
|
||||||
const newChecks = { ...state.selectedSecret };
|
const newChecks = { ...state.selectedSecret };
|
||||||
// remove selection if its present else add it
|
|
||||||
if (isChecked) delete newChecks[secret.id];
|
if (isChecked) delete newChecks[secret.id];
|
||||||
else newChecks[secret.id] = secret;
|
else newChecks[secret.id] = secret;
|
||||||
return { selectedSecret: newChecks };
|
return { selectedSecret: newChecks };
|
||||||
@@ -33,6 +188,332 @@ const createSelectedSecretStore: StateCreator<SelectedSecretState> = (set) => ({
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const cleanupRevertedFields = (update: PendingSecretUpdate): PendingSecretUpdate => {
|
||||||
|
const cleaned = { ...update };
|
||||||
|
|
||||||
|
if (cleaned.secretValue === cleaned.originalValue) {
|
||||||
|
cleaned.secretValue = undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (cleaned.secretComment === cleaned.originalComment) {
|
||||||
|
cleaned.secretComment = undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (cleaned.skipMultilineEncoding === cleaned.originalSkipMultilineEncoding) {
|
||||||
|
cleaned.skipMultilineEncoding = undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
// For arrays, compare stringified versions
|
||||||
|
if (JSON.stringify(cleaned.tags) === JSON.stringify(cleaned.originalTags)) {
|
||||||
|
cleaned.tags = undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (JSON.stringify(cleaned.secretMetadata) === JSON.stringify(cleaned.originalSecretMetadata)) {
|
||||||
|
cleaned.secretMetadata = undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
// If the new name is the same as original key, remove it
|
||||||
|
if (cleaned.newSecretName === cleaned.secretKey) {
|
||||||
|
cleaned.newSecretName = undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
return cleaned;
|
||||||
|
};
|
||||||
|
|
||||||
|
type BatchModeState = {
|
||||||
|
isBatchMode: boolean;
|
||||||
|
pendingChanges: PendingChanges;
|
||||||
|
existingSecretKeys: Set<string>;
|
||||||
|
existingFolderNames: Set<string>;
|
||||||
|
currentContext: BatchContext | null;
|
||||||
|
batchActions: {
|
||||||
|
addPendingChange: (change: PendingChange, context: BatchContext) => void;
|
||||||
|
loadPendingChanges: (context: BatchContext) => void;
|
||||||
|
clearAllPendingChanges: (context: BatchContext) => void;
|
||||||
|
setExistingKeys: (secretKeys: string[], folderNames: string[]) => void;
|
||||||
|
getTotalPendingChangesCount: () => number;
|
||||||
|
removePendingChange: (changeId: string, resourceType: string, context: BatchContext) => void;
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
const createBatchModeStore: StateCreator<CombinedState, [], [], BatchModeState> = (set, get) => ({
|
||||||
|
isBatchMode: true, // Always enabled by default
|
||||||
|
pendingChanges: { secrets: [], folders: [] },
|
||||||
|
currentContext: null,
|
||||||
|
existingSecretKeys: new Set<string>(),
|
||||||
|
existingFolderNames: new Set<string>(),
|
||||||
|
batchActions: {
|
||||||
|
addPendingChange: (change: PendingChange, context: BatchContext) =>
|
||||||
|
set((state) => {
|
||||||
|
const newChanges = { ...state.pendingChanges };
|
||||||
|
|
||||||
|
if (change.resourceType === "folder") {
|
||||||
|
if (
|
||||||
|
change.type === "create" &&
|
||||||
|
(state.existingFolderNames.has(change.folderName) ||
|
||||||
|
newChanges.folders.some((f) => f.folderName === change.folderName))
|
||||||
|
) {
|
||||||
|
return { pendingChanges: newChanges };
|
||||||
|
}
|
||||||
|
if (
|
||||||
|
change.type === "update" &&
|
||||||
|
change.folderName !== change.originalFolderName &&
|
||||||
|
(state.existingFolderNames.has(change.folderName) ||
|
||||||
|
newChanges.folders.some((f) => f.folderName === change.folderName))
|
||||||
|
) {
|
||||||
|
return { pendingChanges: newChanges };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (change.resourceType === "secret") {
|
||||||
|
if (
|
||||||
|
change.type === "create" &&
|
||||||
|
(state.existingSecretKeys.has(change.secretKey) ||
|
||||||
|
newChanges.secrets.some((s) => s.secretKey === change.secretKey))
|
||||||
|
) {
|
||||||
|
return { pendingChanges: newChanges };
|
||||||
|
}
|
||||||
|
if (
|
||||||
|
change.type === "update" &&
|
||||||
|
change.newSecretName &&
|
||||||
|
change.newSecretName !== change.secretKey &&
|
||||||
|
(state.existingSecretKeys.has(change.newSecretName) ||
|
||||||
|
newChanges.secrets.some(
|
||||||
|
(s) =>
|
||||||
|
(s.secretKey === change.newSecretName ||
|
||||||
|
(s.type === "update" && s.newSecretName === change.newSecretName)) &&
|
||||||
|
s.id !== change.id
|
||||||
|
))
|
||||||
|
) {
|
||||||
|
return { pendingChanges: newChanges };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (change.resourceType === "secret") {
|
||||||
|
const secretChanges = [...newChanges.secrets];
|
||||||
|
|
||||||
|
if (change.type === "create") {
|
||||||
|
const existingCreateIndex = secretChanges.findIndex(
|
||||||
|
(c) =>
|
||||||
|
c.type === "create" &&
|
||||||
|
(c.secretKey === change.secretKey || c.secretKey === change.originalKey)
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingCreateIndex >= 0) {
|
||||||
|
secretChanges[existingCreateIndex] = {
|
||||||
|
...secretChanges[existingCreateIndex],
|
||||||
|
...change,
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
secretChanges.push(change);
|
||||||
|
}
|
||||||
|
} else if (change.type === "update") {
|
||||||
|
const existingCreateIndex = secretChanges.findIndex(
|
||||||
|
(c) => c.type === "create" && c.id === change.id
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingCreateIndex >= 0) {
|
||||||
|
const existingCreate = secretChanges[existingCreateIndex] as PendingSecretCreate;
|
||||||
|
secretChanges[existingCreateIndex] = {
|
||||||
|
...existingCreate,
|
||||||
|
secretKey: change.newSecretName || change.secretKey || existingCreate.secretKey,
|
||||||
|
secretValue:
|
||||||
|
change.secretValue !== undefined
|
||||||
|
? change.secretValue
|
||||||
|
: existingCreate.secretValue,
|
||||||
|
secretComment:
|
||||||
|
change.secretComment !== undefined
|
||||||
|
? change.secretComment
|
||||||
|
: existingCreate.secretComment,
|
||||||
|
skipMultilineEncoding:
|
||||||
|
change.skipMultilineEncoding !== undefined
|
||||||
|
? change.skipMultilineEncoding
|
||||||
|
: existingCreate.skipMultilineEncoding,
|
||||||
|
tags: change.tags !== undefined ? change.tags : existingCreate.tags,
|
||||||
|
secretMetadata:
|
||||||
|
change.secretMetadata !== undefined
|
||||||
|
? change.secretMetadata
|
||||||
|
: existingCreate.secretMetadata,
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
const existingUpdateIndex = secretChanges.findIndex(
|
||||||
|
(c) => c.type === "update" && c.id === change.id
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingUpdateIndex >= 0) {
|
||||||
|
const existingUpdate = secretChanges[existingUpdateIndex] as PendingSecretUpdate;
|
||||||
|
|
||||||
|
const improvedUpdate: PendingSecretUpdate = {
|
||||||
|
...existingUpdate,
|
||||||
|
secretKey: existingUpdate.secretKey,
|
||||||
|
originalValue: existingUpdate.originalValue,
|
||||||
|
originalComment: existingUpdate.originalComment,
|
||||||
|
originalSkipMultilineEncoding: existingUpdate.originalSkipMultilineEncoding,
|
||||||
|
originalTags: existingUpdate.originalTags,
|
||||||
|
originalSecretMetadata: existingUpdate.originalSecretMetadata,
|
||||||
|
|
||||||
|
newSecretName:
|
||||||
|
change.newSecretName !== undefined
|
||||||
|
? change.newSecretName
|
||||||
|
: existingUpdate.newSecretName,
|
||||||
|
secretValue:
|
||||||
|
change.secretValue !== undefined
|
||||||
|
? change.secretValue
|
||||||
|
: existingUpdate.secretValue,
|
||||||
|
secretComment:
|
||||||
|
change.secretComment !== undefined
|
||||||
|
? change.secretComment
|
||||||
|
: existingUpdate.secretComment,
|
||||||
|
skipMultilineEncoding:
|
||||||
|
change.skipMultilineEncoding !== undefined
|
||||||
|
? change.skipMultilineEncoding
|
||||||
|
: existingUpdate.skipMultilineEncoding,
|
||||||
|
tags: change.tags !== undefined ? change.tags : existingUpdate.tags,
|
||||||
|
secretMetadata:
|
||||||
|
change.secretMetadata !== undefined
|
||||||
|
? change.secretMetadata
|
||||||
|
: existingUpdate.secretMetadata,
|
||||||
|
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
|
||||||
|
const cleanedUpdate = cleanupRevertedFields(improvedUpdate);
|
||||||
|
|
||||||
|
secretChanges[existingUpdateIndex] = cleanedUpdate;
|
||||||
|
} else {
|
||||||
|
secretChanges.push(change);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
secretChanges.push(change);
|
||||||
|
}
|
||||||
|
|
||||||
|
newChanges.secrets = secretChanges;
|
||||||
|
} else if (change.resourceType === "folder") {
|
||||||
|
const folderChanges = [...newChanges.folders];
|
||||||
|
|
||||||
|
if (change.type === "create") {
|
||||||
|
const existingCreateIndex = folderChanges.findIndex(
|
||||||
|
(c) => c.type === "create" && c.folderName === change.folderName
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingCreateIndex >= 0) {
|
||||||
|
folderChanges[existingCreateIndex] = {
|
||||||
|
...folderChanges[existingCreateIndex],
|
||||||
|
...change,
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
folderChanges.push(change);
|
||||||
|
}
|
||||||
|
} else if (change.type === "update") {
|
||||||
|
const existingCreateIndex = folderChanges.findIndex(
|
||||||
|
(c) => c.type === "create" && c.folderName === change.originalFolderName
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingCreateIndex >= 0) {
|
||||||
|
const existingCreate = folderChanges[existingCreateIndex] as PendingFolderCreate;
|
||||||
|
folderChanges[existingCreateIndex] = {
|
||||||
|
...existingCreate,
|
||||||
|
folderName: change.folderName || existingCreate.folderName,
|
||||||
|
description:
|
||||||
|
change.description !== undefined
|
||||||
|
? change.description
|
||||||
|
: existingCreate.description,
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
const existingUpdateIndex = folderChanges.findIndex(
|
||||||
|
(c) => c.type === "update" && c.id === change.id
|
||||||
|
);
|
||||||
|
|
||||||
|
if (existingUpdateIndex >= 0) {
|
||||||
|
const existingUpdate = folderChanges[existingUpdateIndex] as PendingFolderUpdate;
|
||||||
|
|
||||||
|
folderChanges[existingUpdateIndex] = {
|
||||||
|
...existingUpdate,
|
||||||
|
originalFolderName: existingUpdate.originalFolderName,
|
||||||
|
originalDescription: existingUpdate.originalDescription,
|
||||||
|
|
||||||
|
folderName:
|
||||||
|
change.folderName !== undefined ? change.folderName : existingUpdate.folderName,
|
||||||
|
description:
|
||||||
|
change.description !== undefined
|
||||||
|
? change.description
|
||||||
|
: existingUpdate.description,
|
||||||
|
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
folderChanges.push(change);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
folderChanges.push(change);
|
||||||
|
}
|
||||||
|
|
||||||
|
newChanges.folders = folderChanges;
|
||||||
|
}
|
||||||
|
|
||||||
|
savePendingChangesToStorage(
|
||||||
|
newChanges,
|
||||||
|
context.workspaceId,
|
||||||
|
context.environment,
|
||||||
|
context.secretPath
|
||||||
|
);
|
||||||
|
return { pendingChanges: newChanges };
|
||||||
|
}),
|
||||||
|
|
||||||
|
removePendingChange: (changeId: string, resourceType: string, context: BatchContext) =>
|
||||||
|
set((state) => {
|
||||||
|
const newChanges = { ...state.pendingChanges };
|
||||||
|
|
||||||
|
if (resourceType === "secret") {
|
||||||
|
newChanges.secrets = newChanges.secrets.filter((c) => c.id !== changeId);
|
||||||
|
} else if (resourceType === "folder") {
|
||||||
|
newChanges.folders = newChanges.folders.filter((c) => c.id !== changeId);
|
||||||
|
}
|
||||||
|
|
||||||
|
savePendingChangesToStorage(
|
||||||
|
newChanges,
|
||||||
|
context.workspaceId,
|
||||||
|
context.environment,
|
||||||
|
context.secretPath
|
||||||
|
);
|
||||||
|
return { pendingChanges: newChanges };
|
||||||
|
}),
|
||||||
|
|
||||||
|
loadPendingChanges: (context) => {
|
||||||
|
const changes = loadPendingChangesFromStorage(
|
||||||
|
context.workspaceId,
|
||||||
|
context.environment,
|
||||||
|
context.secretPath
|
||||||
|
);
|
||||||
|
set({ pendingChanges: changes });
|
||||||
|
},
|
||||||
|
|
||||||
|
clearAllPendingChanges: (context) => {
|
||||||
|
clearPendingChangesFromStorage(context.workspaceId, context.environment, context.secretPath);
|
||||||
|
set({
|
||||||
|
pendingChanges: { secrets: [], folders: [] }
|
||||||
|
});
|
||||||
|
},
|
||||||
|
|
||||||
|
setExistingKeys: (secretKeys, folderNames) =>
|
||||||
|
set({
|
||||||
|
existingSecretKeys: new Set(secretKeys),
|
||||||
|
existingFolderNames: new Set(folderNames)
|
||||||
|
}),
|
||||||
|
|
||||||
|
getTotalPendingChangesCount: () => {
|
||||||
|
const state = get();
|
||||||
|
return state.pendingChanges.secrets.length + state.pendingChanges.folders.length;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
export enum PopUpNames {
|
export enum PopUpNames {
|
||||||
CreateSecretForm = "create-secret-form"
|
CreateSecretForm = "create-secret-form"
|
||||||
}
|
}
|
||||||
@@ -58,13 +539,14 @@ const createPopUpStore: StateCreator<PopUpState> = (set) => ({
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
type CombinedState = SelectedSecretState & PopUpState;
|
type CombinedState = SelectedSecretState & PopUpState & BatchModeState;
|
||||||
const StoreContext = createContext<StoreApi<CombinedState> | null>(null);
|
const StoreContext = createContext<StoreApi<CombinedState> | null>(null);
|
||||||
export const StoreProvider = ({ children }: { children: ReactNode }) => {
|
export const StoreProvider = ({ children }: { children: ReactNode }) => {
|
||||||
const storeRef = useRef<StoreApi<CombinedState>>(
|
const storeRef = useRef<StoreApi<CombinedState>>(
|
||||||
createStore<CombinedState>((...a) => ({
|
createStore<CombinedState>((...a) => ({
|
||||||
...createSelectedSecretStore(...a),
|
...createSelectedSecretStore(...a),
|
||||||
...createPopUpStore(...a)
|
...createPopUpStore(...a),
|
||||||
|
...createBatchModeStore(...a)
|
||||||
}))
|
}))
|
||||||
);
|
);
|
||||||
const router = useRouter();
|
const router = useRouter();
|
||||||
@@ -99,3 +581,17 @@ export const useSelectedSecretActions = () => useStoreContext(useShallow((state)
|
|||||||
export const usePopUpState = (id: PopUpNames) =>
|
export const usePopUpState = (id: PopUpNames) =>
|
||||||
useStoreContext(useShallow((state) => state.popUp?.[id] || { isOpen: false }));
|
useStoreContext(useShallow((state) => state.popUp?.[id] || { isOpen: false }));
|
||||||
export const usePopUpAction = () => useStoreContext(useShallow((state) => state.popUpActions));
|
export const usePopUpAction = () => useStoreContext(useShallow((state) => state.popUpActions));
|
||||||
|
|
||||||
|
export const useBatchMode = () =>
|
||||||
|
useStoreContext(
|
||||||
|
useShallow((state) => ({
|
||||||
|
isBatchMode: state.isBatchMode,
|
||||||
|
pendingChanges: state.pendingChanges,
|
||||||
|
currentContext: state.currentContext,
|
||||||
|
totalChangesCount: state.batchActions.getTotalPendingChangesCount(),
|
||||||
|
secretChangesCount: state.pendingChanges.secrets.length,
|
||||||
|
folderChangesCount: state.pendingChanges.folders.length
|
||||||
|
}))
|
||||||
|
);
|
||||||
|
|
||||||
|
export const useBatchModeActions = () => useStoreContext(useShallow((state) => state.batchActions));
|
||||||
|
|||||||
+27
@@ -79,7 +79,9 @@ import { ApiErrorTypes, SecretType, TApiErrors, WsTag } from "@app/hooks/api/typ
|
|||||||
import { SecretSearchInput } from "@app/pages/secret-manager/OverviewPage/components/SecretSearchInput";
|
import { SecretSearchInput } from "@app/pages/secret-manager/OverviewPage/components/SecretSearchInput";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
|
PendingFolderCreate,
|
||||||
PopUpNames,
|
PopUpNames,
|
||||||
|
useBatchModeActions,
|
||||||
usePopUpAction,
|
usePopUpAction,
|
||||||
useSelectedSecretActions,
|
useSelectedSecretActions,
|
||||||
useSelectedSecrets
|
useSelectedSecrets
|
||||||
@@ -109,6 +111,7 @@ type Props = {
|
|||||||
filter: Filter;
|
filter: Filter;
|
||||||
tags?: WsTag[];
|
tags?: WsTag[];
|
||||||
isVisible?: boolean;
|
isVisible?: boolean;
|
||||||
|
isBatchMode?: boolean;
|
||||||
snapshotCount: number;
|
snapshotCount: number;
|
||||||
isSnapshotCountLoading?: boolean;
|
isSnapshotCountLoading?: boolean;
|
||||||
protectedBranchPolicyName?: string;
|
protectedBranchPolicyName?: string;
|
||||||
@@ -137,6 +140,7 @@ export const ActionBar = ({
|
|||||||
filter,
|
filter,
|
||||||
tags = [],
|
tags = [],
|
||||||
isVisible,
|
isVisible,
|
||||||
|
isBatchMode,
|
||||||
snapshotCount,
|
snapshotCount,
|
||||||
isSnapshotCountLoading,
|
isSnapshotCountLoading,
|
||||||
onSearchChange,
|
onSearchChange,
|
||||||
@@ -174,6 +178,7 @@ export const ActionBar = ({
|
|||||||
options: { onSuccess: undefined }
|
options: { onSuccess: undefined }
|
||||||
});
|
});
|
||||||
const queryClient = useQueryClient();
|
const queryClient = useQueryClient();
|
||||||
|
const { addPendingChange } = useBatchModeActions();
|
||||||
|
|
||||||
const selectedSecrets = useSelectedSecrets();
|
const selectedSecrets = useSelectedSecrets();
|
||||||
const { reset: resetSelectedSecret } = useSelectedSecretActions();
|
const { reset: resetSelectedSecret } = useSelectedSecretActions();
|
||||||
@@ -183,6 +188,28 @@ export const ActionBar = ({
|
|||||||
|
|
||||||
const handleFolderCreate = async (folderName: string, description: string | null) => {
|
const handleFolderCreate = async (folderName: string, description: string | null) => {
|
||||||
try {
|
try {
|
||||||
|
if (isBatchMode) {
|
||||||
|
const folderId = `${folderName}`;
|
||||||
|
const pendingFolderCreate: PendingFolderCreate = {
|
||||||
|
id: folderId,
|
||||||
|
resourceType: "folder",
|
||||||
|
type: "create",
|
||||||
|
folderName,
|
||||||
|
description: description || undefined,
|
||||||
|
parentPath: secretPath,
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(pendingFolderCreate, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
|
||||||
|
handlePopUpClose("addFolder");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
await createFolder({
|
await createFolder({
|
||||||
name: folderName,
|
name: folderName,
|
||||||
path: secretPath,
|
path: secretPath,
|
||||||
|
|||||||
+7
-2
@@ -8,7 +8,12 @@ import { TextArea } from "@app/components/v2/TextArea/TextArea";
|
|||||||
|
|
||||||
type Props = {
|
type Props = {
|
||||||
onCreateFolder?: (folderName: string, description: string | null) => Promise<void>;
|
onCreateFolder?: (folderName: string, description: string | null) => Promise<void>;
|
||||||
onUpdateFolder?: (folderName: string, description: string | null) => Promise<void>;
|
onUpdateFolder?: (
|
||||||
|
folderName: string,
|
||||||
|
description: string | null,
|
||||||
|
oldFolderName?: string,
|
||||||
|
oldFolderDescription?: string
|
||||||
|
) => Promise<void>;
|
||||||
isEdit?: boolean;
|
isEdit?: boolean;
|
||||||
defaultFolderName?: string;
|
defaultFolderName?: string;
|
||||||
defaultDescription?: string;
|
defaultDescription?: string;
|
||||||
@@ -69,7 +74,7 @@ export const FolderForm = ({
|
|||||||
const descriptionShaped = description && description.trim() !== "" ? description : null;
|
const descriptionShaped = description && description.trim() !== "" ? description : null;
|
||||||
|
|
||||||
if (isEdit) {
|
if (isEdit) {
|
||||||
await onUpdateFolder?.(name, descriptionShaped);
|
await onUpdateFolder?.(name, descriptionShaped, defaultFolderName, defaultDescription);
|
||||||
} else {
|
} else {
|
||||||
await onCreateFolder?.(name, descriptionShaped);
|
await onCreateFolder?.(name, descriptionShaped);
|
||||||
}
|
}
|
||||||
|
|||||||
+595
@@ -0,0 +1,595 @@
|
|||||||
|
/* eslint-disable jsx-a11y/label-has-associated-control */
|
||||||
|
import React, { useState } from "react";
|
||||||
|
import { faCodeCommit, faFolder, faKey } from "@fortawesome/free-solid-svg-icons";
|
||||||
|
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
|
||||||
|
|
||||||
|
import {
|
||||||
|
Badge,
|
||||||
|
Button,
|
||||||
|
FontAwesomeSymbol,
|
||||||
|
IconButton,
|
||||||
|
Input,
|
||||||
|
Modal,
|
||||||
|
ModalContent
|
||||||
|
} from "@app/components/v2";
|
||||||
|
|
||||||
|
import {
|
||||||
|
PendingChange,
|
||||||
|
PendingChanges,
|
||||||
|
useBatchMode,
|
||||||
|
useBatchModeActions
|
||||||
|
} from "../../SecretMainPage.store";
|
||||||
|
import { FontAwesomeSpriteName } from "../SecretListView/SecretListView.utils";
|
||||||
|
|
||||||
|
interface CommitFormProps {
|
||||||
|
onCommit: (changes: PendingChanges, commitMessage: string) => Promise<void>;
|
||||||
|
isCommitting?: boolean;
|
||||||
|
environment: string;
|
||||||
|
workspaceId: string;
|
||||||
|
secretPath: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
interface ChangeTableProps {
|
||||||
|
change: PendingChange;
|
||||||
|
environment: string;
|
||||||
|
workspaceId: string;
|
||||||
|
secretPath: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
const TagsList: React.FC<{ tags?: { id: string; slug: string }[]; className?: string }> = ({
|
||||||
|
tags,
|
||||||
|
className = ""
|
||||||
|
}) => {
|
||||||
|
if (!tags || tags.length === 0) {
|
||||||
|
return <span className={`italic text-mineshaft-400 ${className}`}>(no tags)</span>;
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className={`flex flex-wrap gap-1 ${className}`}>
|
||||||
|
{tags.map((tag) => (
|
||||||
|
<Badge key={tag.id} variant="primary" className="text-xs">
|
||||||
|
{tag.slug}
|
||||||
|
</Badge>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
const MetadataList: React.FC<{
|
||||||
|
metadata?: { key: string; value: string }[];
|
||||||
|
className?: string;
|
||||||
|
}> = ({ metadata, className = "" }) => {
|
||||||
|
if (!metadata || metadata.length === 0) {
|
||||||
|
return <span className={`italic text-mineshaft-400 ${className}`}>(no metadata)</span>;
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className={`space-y-1 ${className}`}>
|
||||||
|
{metadata.map((item) => (
|
||||||
|
<div key={item.key} className="flex items-center gap-2 text-xs">
|
||||||
|
<span className="font-medium text-mineshaft-300">{item.key}:</span>
|
||||||
|
<span className="font-mono text-mineshaft-100">{item.value}</span>
|
||||||
|
</div>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
const ComparisonTableRow: React.FC<{
|
||||||
|
label: string;
|
||||||
|
previousValue: React.ReactNode;
|
||||||
|
newValue: React.ReactNode;
|
||||||
|
hideIfSame?: boolean;
|
||||||
|
}> = ({ label, previousValue, newValue, hideIfSame = false }) => {
|
||||||
|
const isSame = hideIfSame && String(previousValue) === String(newValue);
|
||||||
|
|
||||||
|
if (isSame) return null;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<tr className="border-b border-mineshaft-700 last:border-b-0">
|
||||||
|
<td className="w-24 py-3 pl-4 align-top font-medium text-mineshaft-300">{label}:</td>
|
||||||
|
<td className="w-1/2 px-3 py-3 align-top">
|
||||||
|
<div className="text-red-400 opacity-80">{previousValue}</div>
|
||||||
|
</td>
|
||||||
|
<td className="w-1/2 py-3 pr-4 align-top">
|
||||||
|
<div className="text-green-400">{newValue}</div>
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
const ChangeTable: React.FC<ChangeTableProps> = ({
|
||||||
|
change,
|
||||||
|
environment,
|
||||||
|
workspaceId,
|
||||||
|
secretPath
|
||||||
|
}) => {
|
||||||
|
const getChangeBadge = (type: PendingChange["type"]) => {
|
||||||
|
switch (type) {
|
||||||
|
case "create":
|
||||||
|
return <Badge variant="success">Created</Badge>;
|
||||||
|
case "update":
|
||||||
|
return <Badge variant="primary">Updated</Badge>;
|
||||||
|
case "delete":
|
||||||
|
return <Badge variant="danger">Deleted</Badge>;
|
||||||
|
default:
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const renderSecretChanges = () => {
|
||||||
|
if (change.resourceType !== "secret") return null;
|
||||||
|
|
||||||
|
if (change.type === "create") {
|
||||||
|
return (
|
||||||
|
<div className="mt-3 overflow-hidden rounded-md border border-mineshaft-700 bg-mineshaft-900">
|
||||||
|
<table className="w-full text-sm">
|
||||||
|
<tbody>
|
||||||
|
<tr className="border-b border-mineshaft-700">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Key:</td>
|
||||||
|
<td className="px-3 py-3 font-mono text-mineshaft-100" colSpan={2}>
|
||||||
|
{change.secretKey}
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
<tr className="border-b border-mineshaft-700">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Value:</td>
|
||||||
|
<td className="px-3 py-3" colSpan={2}>
|
||||||
|
<div className="max-w-md break-all px-2 py-1 font-mono text-xs text-mineshaft-100">
|
||||||
|
{change.secretValue || (
|
||||||
|
<span className="italic text-mineshaft-400">(empty)</span>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
{change.secretComment !== undefined && change.secretComment !== "" && (
|
||||||
|
<tr className="border-b border-mineshaft-700">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Comment:</td>
|
||||||
|
<td className="px-3 py-3 text-mineshaft-100" colSpan={2}>
|
||||||
|
{change.secretComment}
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
)}
|
||||||
|
{change.tags && change.tags.length > 0 && (
|
||||||
|
<tr className="border-b border-mineshaft-700">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Tags:</td>
|
||||||
|
<td className="px-3 py-3" colSpan={2}>
|
||||||
|
<TagsList tags={change.tags} />
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
)}
|
||||||
|
{change.secretMetadata && change.secretMetadata.length > 0 && (
|
||||||
|
<tr className="border-b border-mineshaft-700 last:border-b-0">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Metadata:</td>
|
||||||
|
<td className="px-3 py-3" colSpan={2}>
|
||||||
|
<MetadataList metadata={change.secretMetadata} />
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
)}
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (change.type === "update") {
|
||||||
|
const hasKeyChange = change.newSecretName && change.secretKey !== change.newSecretName;
|
||||||
|
const hasValueChange = change.secretValue !== change.originalValue;
|
||||||
|
const hasCommentChange = change.secretComment !== change.originalComment;
|
||||||
|
const hasMultilineChange =
|
||||||
|
change.skipMultilineEncoding !== change.originalSkipMultilineEncoding;
|
||||||
|
const hasTagsChange = JSON.stringify(change.tags) !== JSON.stringify(change.originalTags);
|
||||||
|
const hasMetadataChange =
|
||||||
|
JSON.stringify(change.secretMetadata) !== JSON.stringify(change.originalSecretMetadata);
|
||||||
|
|
||||||
|
const hasChanges = [
|
||||||
|
hasKeyChange,
|
||||||
|
hasValueChange,
|
||||||
|
hasCommentChange,
|
||||||
|
hasMultilineChange,
|
||||||
|
hasTagsChange,
|
||||||
|
hasMetadataChange
|
||||||
|
].some(Boolean);
|
||||||
|
|
||||||
|
if (!hasChanges) return null;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className="mt-3 overflow-hidden rounded-md border border-mineshaft-700 bg-mineshaft-900">
|
||||||
|
<table className="w-full text-sm">
|
||||||
|
<tbody>
|
||||||
|
{hasKeyChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Key"
|
||||||
|
previousValue={<span className="font-mono">{change.secretKey}</span>}
|
||||||
|
newValue={<span className="font-mono">{change.newSecretName}</span>}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
{hasValueChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Value"
|
||||||
|
previousValue={
|
||||||
|
<div className="max-w-md break-all rounded">
|
||||||
|
{change.originalValue || <span className="italic">(empty)</span>}
|
||||||
|
</div>
|
||||||
|
}
|
||||||
|
newValue={
|
||||||
|
<div className="max-w-md break-all rounded">
|
||||||
|
{change.secretValue || <span className="italic">(empty)</span>}
|
||||||
|
</div>
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
{hasCommentChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Comment"
|
||||||
|
previousValue={change.originalComment || <span className="italic">(empty)</span>}
|
||||||
|
newValue={change.secretComment || <span className="italic">(empty)</span>}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
{hasMultilineChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Multiline"
|
||||||
|
previousValue={change.originalSkipMultilineEncoding ? "Enabled" : "Disabled"}
|
||||||
|
newValue={change.skipMultilineEncoding ? "Enabled" : "Disabled"}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
{hasTagsChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Tags"
|
||||||
|
previousValue={<TagsList tags={change.originalTags} />}
|
||||||
|
newValue={<TagsList tags={change.tags} />}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
{hasMetadataChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Metadata"
|
||||||
|
previousValue={<MetadataList metadata={change.originalSecretMetadata} />}
|
||||||
|
newValue={<MetadataList metadata={change.secretMetadata} />}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (change.type === "delete") {
|
||||||
|
return (
|
||||||
|
<div className="mt-3 overflow-hidden rounded-md border border-red-700 bg-red-900/20">
|
||||||
|
<table className="w-full text-sm">
|
||||||
|
<thead>
|
||||||
|
<tr className="border-b border-red-600 bg-red-800/30">
|
||||||
|
<th className="w-24 py-2 pl-4 text-left text-xs font-medium text-red-300">Field</th>
|
||||||
|
<th className="px-3 py-2 text-left text-xs font-medium text-red-300">
|
||||||
|
Deleted Value
|
||||||
|
</th>
|
||||||
|
<th className="w-8" />
|
||||||
|
</tr>
|
||||||
|
</thead>
|
||||||
|
<tbody>
|
||||||
|
<tr className="border-b border-red-700">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-red-300">Key:</td>
|
||||||
|
<td className="px-3 py-3 font-mono text-red-100 line-through" colSpan={2}>
|
||||||
|
{change.secretKey}
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
<tr className="border-b border-red-700 last:border-b-0">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-red-300">Value:</td>
|
||||||
|
<td className="px-3 py-3" colSpan={2}>
|
||||||
|
<div className="max-w-md break-all rounded bg-red-800/50 px-2 py-1 font-mono text-xs text-red-100 line-through">
|
||||||
|
{change.secretValue || <span className="italic">(empty)</span>}
|
||||||
|
</div>
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
const renderFolderChanges = () => {
|
||||||
|
if (change.resourceType !== "folder") return null;
|
||||||
|
|
||||||
|
if (change.type === "create") {
|
||||||
|
return (
|
||||||
|
<div className="mt-3 overflow-hidden rounded-md border border-mineshaft-700 bg-mineshaft-900">
|
||||||
|
<table className="w-full text-sm">
|
||||||
|
<tbody>
|
||||||
|
<tr className="border-b border-mineshaft-700">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Name:</td>
|
||||||
|
<td className="px-3 py-3 font-mono text-mineshaft-100" colSpan={2}>
|
||||||
|
{change.folderName}
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
{change.description !== undefined && change.description !== "" && (
|
||||||
|
<tr className="border-b border-mineshaft-700 last:border-b-0">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-mineshaft-300">Description:</td>
|
||||||
|
<td className="px-3 py-3 text-mineshaft-100" colSpan={2}>
|
||||||
|
{change.description}
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
)}
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (change.type === "update") {
|
||||||
|
const hasNameChange = change.folderName !== change.originalFolderName;
|
||||||
|
const hasDescriptionChange = change.description !== change.originalDescription;
|
||||||
|
|
||||||
|
const hasChanges = [hasNameChange, hasDescriptionChange].some(Boolean);
|
||||||
|
|
||||||
|
if (!hasChanges) return null;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className="mt-3 overflow-hidden rounded-md border border-mineshaft-700 bg-mineshaft-900">
|
||||||
|
<table className="w-full text-sm">
|
||||||
|
<tbody>
|
||||||
|
{hasNameChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Name"
|
||||||
|
previousValue={<span className="font-mono">{change.originalFolderName}</span>}
|
||||||
|
newValue={<span className="font-mono">{change.folderName}</span>}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
{hasDescriptionChange && (
|
||||||
|
<ComparisonTableRow
|
||||||
|
label="Description"
|
||||||
|
previousValue={
|
||||||
|
change.originalDescription || <span className="italic">(empty)</span>
|
||||||
|
}
|
||||||
|
newValue={change.description || <span className="italic">(empty)</span>}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (change.type === "delete") {
|
||||||
|
return (
|
||||||
|
<div className="mt-3 overflow-hidden rounded-md border border-red-700 bg-red-900/20">
|
||||||
|
<table className="w-full text-sm">
|
||||||
|
<thead>
|
||||||
|
<tr className="border-b border-red-600 bg-red-800/30">
|
||||||
|
<th className="w-24 py-2 pl-4 text-left text-xs font-medium text-red-300">Field</th>
|
||||||
|
<th className="px-3 py-2 text-left text-xs font-medium text-red-300">
|
||||||
|
Deleted Value
|
||||||
|
</th>
|
||||||
|
<th className="w-8" />
|
||||||
|
</tr>
|
||||||
|
</thead>
|
||||||
|
<tbody>
|
||||||
|
<tr className="border-b border-red-700 last:border-b-0">
|
||||||
|
<td className="w-24 py-3 pl-4 font-medium text-red-300">Name:</td>
|
||||||
|
<td className="px-3 py-3 font-mono text-red-100 line-through" colSpan={2}>
|
||||||
|
{change.folderName}
|
||||||
|
</td>
|
||||||
|
</tr>
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
const getChangeName = () => {
|
||||||
|
if (change.resourceType === "secret") {
|
||||||
|
return change.type === "update" ? change.newSecretName || change.secretKey : change.secretKey;
|
||||||
|
}
|
||||||
|
if (change.resourceType === "folder") {
|
||||||
|
return change.type === "update" ? change.originalFolderName : change.folderName;
|
||||||
|
}
|
||||||
|
return "Unknown";
|
||||||
|
};
|
||||||
|
|
||||||
|
const { removePendingChange } = useBatchModeActions();
|
||||||
|
|
||||||
|
const handleDeletePending = (changeType: string, id: string) => {
|
||||||
|
removePendingChange(id, changeType, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className="py-2 shadow-sm">
|
||||||
|
<div className="flex items-center justify-between">
|
||||||
|
<div className="flex items-center gap-3">
|
||||||
|
<span className="font-medium text-mineshaft-100">{getChangeName()}</span>
|
||||||
|
{getChangeBadge(change.type)}
|
||||||
|
</div>
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="delete-change"
|
||||||
|
variant="plain"
|
||||||
|
colorSchema="danger"
|
||||||
|
size="sm"
|
||||||
|
onClick={() => handleDeletePending(change.resourceType, change.id)}
|
||||||
|
>
|
||||||
|
<FontAwesomeSymbol symbolName={FontAwesomeSpriteName.Close} className="h-4 w-4" />
|
||||||
|
</IconButton>
|
||||||
|
</div>
|
||||||
|
{change.resourceType === "secret" ? renderSecretChanges() : renderFolderChanges()}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
export const CommitForm: React.FC<CommitFormProps> = ({
|
||||||
|
onCommit,
|
||||||
|
isCommitting = false,
|
||||||
|
environment,
|
||||||
|
workspaceId,
|
||||||
|
secretPath
|
||||||
|
}) => {
|
||||||
|
const { isBatchMode, pendingChanges, totalChangesCount } = useBatchMode();
|
||||||
|
|
||||||
|
const [isModalOpen, setIsModalOpen] = useState(false);
|
||||||
|
const [commitMessage, setCommitMessage] = useState("");
|
||||||
|
const { clearAllPendingChanges } = useBatchModeActions();
|
||||||
|
|
||||||
|
if (!isBatchMode || totalChangesCount === 0) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
const handleCommit = async () => {
|
||||||
|
if (!commitMessage.trim()) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
try {
|
||||||
|
await onCommit(pendingChanges, commitMessage);
|
||||||
|
clearAllPendingChanges({
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
setIsModalOpen(false);
|
||||||
|
setCommitMessage("");
|
||||||
|
} catch (error) {
|
||||||
|
console.error("Failed to commit changes:", error);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
return (
|
||||||
|
<>
|
||||||
|
{/* Floating Panel */}
|
||||||
|
{!isModalOpen && (
|
||||||
|
<div className="fixed bottom-4 z-40 w-80 self-center rounded-lg border border-mineshaft-600 bg-mineshaft-800 shadow-2xl">
|
||||||
|
<div className="flex w-full justify-center border-b border-mineshaft-600 px-4 py-3">
|
||||||
|
<div className="flex w-full items-center justify-between">
|
||||||
|
<div className="flex items-center gap-2">
|
||||||
|
<FontAwesomeIcon icon={faCodeCommit} className="text-primary" />
|
||||||
|
<span className="font-medium text-mineshaft-100">Ready to Commit</span>
|
||||||
|
</div>
|
||||||
|
<Badge variant="primary" className="text-xs">
|
||||||
|
{totalChangesCount} change{totalChangesCount !== 1 ? "s" : ""}
|
||||||
|
</Badge>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div className="p-3">
|
||||||
|
<Button
|
||||||
|
onClick={() => setIsModalOpen(true)}
|
||||||
|
className="w-full"
|
||||||
|
isDisabled={totalChangesCount === 0}
|
||||||
|
colorSchema="secondary"
|
||||||
|
>
|
||||||
|
Review & Commit
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{/* Commit Modal */}
|
||||||
|
<Modal isOpen={isModalOpen} onOpenChange={setIsModalOpen}>
|
||||||
|
<ModalContent
|
||||||
|
title={
|
||||||
|
<div className="flex items-center gap-2">
|
||||||
|
<FontAwesomeIcon icon={faCodeCommit} className="text-primary" />
|
||||||
|
Commit Changes
|
||||||
|
<Badge variant="primary" className="ml-2">
|
||||||
|
{totalChangesCount} change{totalChangesCount !== 1 ? "s" : ""}
|
||||||
|
</Badge>
|
||||||
|
</div>
|
||||||
|
}
|
||||||
|
className="max-h-[90vh] max-w-5xl"
|
||||||
|
>
|
||||||
|
<div className="space-y-6">
|
||||||
|
<p className="text-mineshaft-300">
|
||||||
|
Write a commit message and review the changes you're about to commit.
|
||||||
|
</p>
|
||||||
|
|
||||||
|
{/* Changes List */}
|
||||||
|
<div className="space-y-6">
|
||||||
|
<div className="max-h-96 space-y-4 overflow-y-auto pr-2">
|
||||||
|
{/* Folder Changes */}
|
||||||
|
{pendingChanges.folders.length > 0 && (
|
||||||
|
<div>
|
||||||
|
<h4 className="mb-4 flex items-center gap-2 border-b border-mineshaft-700 pb-2 text-sm font-semibold text-mineshaft-200">
|
||||||
|
<FontAwesomeIcon icon={faFolder} className="text-mineshaft-300" />
|
||||||
|
Folders ({pendingChanges.folders.length})
|
||||||
|
</h4>
|
||||||
|
<div className="space-y-3">
|
||||||
|
{pendingChanges.folders.map((change) => (
|
||||||
|
<ChangeTable
|
||||||
|
key={change.id}
|
||||||
|
change={change}
|
||||||
|
environment={environment}
|
||||||
|
workspaceId={workspaceId}
|
||||||
|
secretPath={secretPath}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{/* Secret Changes */}
|
||||||
|
{pendingChanges.secrets.length > 0 && (
|
||||||
|
<div>
|
||||||
|
<h4 className="mb-4 flex items-center gap-2 border-b border-mineshaft-700 pb-2 text-sm font-semibold text-mineshaft-200">
|
||||||
|
<FontAwesomeIcon icon={faKey} className="text-mineshaft-300" />
|
||||||
|
Secrets ({pendingChanges.secrets.length})
|
||||||
|
</h4>
|
||||||
|
<div className="space-y-3">
|
||||||
|
{pendingChanges.secrets.map((change) => (
|
||||||
|
<ChangeTable
|
||||||
|
key={change.id}
|
||||||
|
change={change}
|
||||||
|
environment={environment}
|
||||||
|
workspaceId={workspaceId}
|
||||||
|
secretPath={secretPath}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
{/* Commit Message */}
|
||||||
|
<div>
|
||||||
|
<label className="mb-2 block text-sm font-medium text-mineshaft-200">
|
||||||
|
Commit Message <span className="text-red-400">*</span>
|
||||||
|
</label>
|
||||||
|
<Input
|
||||||
|
value={commitMessage}
|
||||||
|
onChange={(e) => setCommitMessage(e.target.value)}
|
||||||
|
placeholder="Describe your changes..."
|
||||||
|
className="w-full"
|
||||||
|
required
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
{/* Action Buttons */}
|
||||||
|
<div className="flex justify-end gap-3 border-t border-mineshaft-600 pt-4">
|
||||||
|
<Button
|
||||||
|
variant="outline_bg"
|
||||||
|
onClick={() => setIsModalOpen(false)}
|
||||||
|
isDisabled={isCommitting}
|
||||||
|
>
|
||||||
|
Cancel
|
||||||
|
</Button>
|
||||||
|
<Button
|
||||||
|
onClick={handleCommit}
|
||||||
|
isLoading={isCommitting}
|
||||||
|
isDisabled={isCommitting || !commitMessage.trim()}
|
||||||
|
leftIcon={<FontAwesomeIcon icon={faCodeCommit} />}
|
||||||
|
colorSchema="primary"
|
||||||
|
>
|
||||||
|
{isCommitting ? "Committing..." : "Commit Changes"}
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</ModalContent>
|
||||||
|
</Modal>
|
||||||
|
</>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
export { CommitForm } from "./CommitForm";
|
||||||
+30
-2
@@ -14,7 +14,12 @@ import { getKeyValue } from "@app/helpers/parseEnvVar";
|
|||||||
import { useCreateSecretV3, useCreateWsTag, useGetWsTags } from "@app/hooks/api";
|
import { useCreateSecretV3, useCreateWsTag, useGetWsTags } from "@app/hooks/api";
|
||||||
import { SecretType } from "@app/hooks/api/types";
|
import { SecretType } from "@app/hooks/api/types";
|
||||||
|
|
||||||
import { PopUpNames, usePopUpAction } from "../../SecretMainPage.store";
|
import {
|
||||||
|
PendingSecretCreate,
|
||||||
|
PopUpNames,
|
||||||
|
useBatchModeActions,
|
||||||
|
usePopUpAction
|
||||||
|
} from "../../SecretMainPage.store";
|
||||||
|
|
||||||
const typeSchema = z.object({
|
const typeSchema = z.object({
|
||||||
key: z.string().trim().min(1, { message: "Secret key is required" }),
|
key: z.string().trim().min(1, { message: "Secret key is required" }),
|
||||||
@@ -31,6 +36,7 @@ type Props = {
|
|||||||
// modal props
|
// modal props
|
||||||
autoCapitalize?: boolean;
|
autoCapitalize?: boolean;
|
||||||
isProtectedBranch?: boolean;
|
isProtectedBranch?: boolean;
|
||||||
|
isBatchMode?: boolean;
|
||||||
};
|
};
|
||||||
|
|
||||||
export const CreateSecretForm = ({
|
export const CreateSecretForm = ({
|
||||||
@@ -38,7 +44,8 @@ export const CreateSecretForm = ({
|
|||||||
workspaceId,
|
workspaceId,
|
||||||
secretPath = "/",
|
secretPath = "/",
|
||||||
autoCapitalize = true,
|
autoCapitalize = true,
|
||||||
isProtectedBranch = false
|
isProtectedBranch = false,
|
||||||
|
isBatchMode = false
|
||||||
}: Props) => {
|
}: Props) => {
|
||||||
const {
|
const {
|
||||||
register,
|
register,
|
||||||
@@ -53,6 +60,7 @@ export const CreateSecretForm = ({
|
|||||||
|
|
||||||
const { mutateAsync: createSecretV3 } = useCreateSecretV3();
|
const { mutateAsync: createSecretV3 } = useCreateSecretV3();
|
||||||
const createWsTag = useCreateWsTag();
|
const createWsTag = useCreateWsTag();
|
||||||
|
const { addPendingChange } = useBatchModeActions();
|
||||||
|
|
||||||
const { permission } = useProjectPermission();
|
const { permission } = useProjectPermission();
|
||||||
const canReadTags = permission.can(ProjectPermissionActions.Read, ProjectPermissionSub.Tags);
|
const canReadTags = permission.can(ProjectPermissionActions.Read, ProjectPermissionSub.Tags);
|
||||||
@@ -85,6 +93,26 @@ export const CreateSecretForm = ({
|
|||||||
|
|
||||||
const handleFormSubmit = async ({ key, value, tags }: TFormSchema) => {
|
const handleFormSubmit = async ({ key, value, tags }: TFormSchema) => {
|
||||||
try {
|
try {
|
||||||
|
if (isBatchMode) {
|
||||||
|
const pendingSecretCreate: PendingSecretCreate = {
|
||||||
|
id: key,
|
||||||
|
type: "create",
|
||||||
|
secretKey: key,
|
||||||
|
secretValue: value || "",
|
||||||
|
secretComment: "",
|
||||||
|
tags: tags?.map((el) => ({ id: el.value, slug: el.label })),
|
||||||
|
timestamp: Date.now(),
|
||||||
|
resourceType: "secret"
|
||||||
|
};
|
||||||
|
addPendingChange(pendingSecretCreate, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
closePopUp(PopUpNames.CreateSecretForm);
|
||||||
|
reset();
|
||||||
|
return;
|
||||||
|
}
|
||||||
await createSecretV3({
|
await createSecretV3({
|
||||||
environment,
|
environment,
|
||||||
workspaceId,
|
workspaceId,
|
||||||
|
|||||||
+171
-49
@@ -2,6 +2,7 @@ import { subject } from "@casl/ability";
|
|||||||
import { faClose, faFolder, faInfoCircle, faPencilSquare } from "@fortawesome/free-solid-svg-icons";
|
import { faClose, faFolder, faInfoCircle, faPencilSquare } from "@fortawesome/free-solid-svg-icons";
|
||||||
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
|
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
|
||||||
import { useNavigate, useSearch } from "@tanstack/react-router";
|
import { useNavigate, useSearch } from "@tanstack/react-router";
|
||||||
|
import { twMerge } from "tailwind-merge";
|
||||||
|
|
||||||
import { createNotification } from "@app/components/notifications";
|
import { createNotification } from "@app/components/notifications";
|
||||||
import { ProjectPermissionCan } from "@app/components/permissions";
|
import { ProjectPermissionCan } from "@app/components/permissions";
|
||||||
@@ -13,6 +14,13 @@ import { usePopUp } from "@app/hooks";
|
|||||||
import { useDeleteFolder, useUpdateFolder } from "@app/hooks/api";
|
import { useDeleteFolder, useUpdateFolder } from "@app/hooks/api";
|
||||||
import { TSecretFolder } from "@app/hooks/api/secretFolders/types";
|
import { TSecretFolder } from "@app/hooks/api/secretFolders/types";
|
||||||
|
|
||||||
|
import {
|
||||||
|
PendingFolderCreate,
|
||||||
|
PendingFolderDelete,
|
||||||
|
PendingFolderUpdate,
|
||||||
|
useBatchMode,
|
||||||
|
useBatchModeActions
|
||||||
|
} from "../../SecretMainPage.store";
|
||||||
import { FolderForm } from "../ActionBar/FolderForm";
|
import { FolderForm } from "../ActionBar/FolderForm";
|
||||||
|
|
||||||
type Props = {
|
type Props = {
|
||||||
@@ -42,10 +50,60 @@ export const FolderListView = ({
|
|||||||
|
|
||||||
const { mutateAsync: updateFolder } = useUpdateFolder();
|
const { mutateAsync: updateFolder } = useUpdateFolder();
|
||||||
const { mutateAsync: deleteFolder } = useDeleteFolder();
|
const { mutateAsync: deleteFolder } = useDeleteFolder();
|
||||||
|
const { isBatchMode } = useBatchMode();
|
||||||
|
const { addPendingChange, removePendingChange } = useBatchModeActions();
|
||||||
|
|
||||||
const handleFolderUpdate = async (newFolderName: string, newFolderDescription: string | null) => {
|
const handleFolderUpdate = async (
|
||||||
|
newFolderName: string,
|
||||||
|
newFolderDescription: string | null,
|
||||||
|
oldFolderName?: string,
|
||||||
|
oldFolderDescription?: string
|
||||||
|
) => {
|
||||||
try {
|
try {
|
||||||
const { id: folderId } = popUp.updateFolder.data as TSecretFolder;
|
const { id: folderId, pendingAction, isPending } = popUp.updateFolder.data as TSecretFolder;
|
||||||
|
|
||||||
|
if (isBatchMode) {
|
||||||
|
const isEditingPendingCreation = isPending && pendingAction === "create";
|
||||||
|
|
||||||
|
if (isEditingPendingCreation) {
|
||||||
|
const updatedCreate: PendingFolderCreate = {
|
||||||
|
id: folderId,
|
||||||
|
type: "create",
|
||||||
|
folderName: newFolderName,
|
||||||
|
description: newFolderDescription || undefined,
|
||||||
|
parentPath: secretPath,
|
||||||
|
timestamp: Date.now(),
|
||||||
|
resourceType: "folder"
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(updatedCreate, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
const updateChange: PendingFolderUpdate = {
|
||||||
|
id: folderId,
|
||||||
|
type: "update",
|
||||||
|
originalFolderName: oldFolderName || "",
|
||||||
|
folderName: newFolderName,
|
||||||
|
originalDescription: oldFolderDescription,
|
||||||
|
description: newFolderDescription || undefined,
|
||||||
|
timestamp: Date.now(),
|
||||||
|
resourceType: "folder"
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(updateChange, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
handlePopUpClose("updateFolder");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
await updateFolder({
|
await updateFolder({
|
||||||
folderId,
|
folderId,
|
||||||
name: newFolderName,
|
name: newFolderName,
|
||||||
@@ -68,15 +126,45 @@ export const FolderListView = ({
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const handleDeletePending = (id: string) => {
|
||||||
|
removePendingChange(id, "folder", {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
const handleFolderDelete = async () => {
|
const handleFolderDelete = async () => {
|
||||||
try {
|
try {
|
||||||
const { id: folderId } = popUp.deleteFolder.data as TSecretFolder;
|
const folderData = popUp.deleteFolder?.data as TSecretFolder;
|
||||||
|
|
||||||
|
if (isBatchMode) {
|
||||||
|
const pendingFolderDelete: PendingFolderDelete = {
|
||||||
|
id: folderData.id,
|
||||||
|
folderName: folderData.name,
|
||||||
|
folderPath: secretPath,
|
||||||
|
resourceType: "folder",
|
||||||
|
type: "delete",
|
||||||
|
timestamp: Date.now()
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(pendingFolderDelete, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
|
||||||
|
handlePopUpClose("deleteFolder");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
await deleteFolder({
|
await deleteFolder({
|
||||||
folderId,
|
folderId: folderData.id,
|
||||||
path: secretPath,
|
path: secretPath,
|
||||||
environment,
|
environment,
|
||||||
projectId: workspaceId
|
projectId: workspaceId
|
||||||
});
|
});
|
||||||
|
|
||||||
handlePopUpClose("deleteFolder");
|
handlePopUpClose("deleteFolder");
|
||||||
createNotification({
|
createNotification({
|
||||||
type: "success",
|
type: "success",
|
||||||
@@ -91,7 +179,10 @@ export const FolderListView = ({
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const handleFolderClick = (name: string) => {
|
const handleFolderClick = (name: string, isPending?: boolean) => {
|
||||||
|
if (isPending) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
const path = `${secretPathQueryparam === "/" ? "" : secretPathQueryparam}/${name}`;
|
const path = `${secretPathQueryparam === "/" ? "" : secretPathQueryparam}/${name}`;
|
||||||
navigate({
|
navigate({
|
||||||
search: (el) => ({ ...el, secretPath: path })
|
search: (el) => ({ ...el, secretPath: path })
|
||||||
@@ -100,10 +191,16 @@ export const FolderListView = ({
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
{folders.map(({ name, id, description }) => (
|
{folders.map(({ name, id, description, pendingAction, isPending }) => (
|
||||||
<div
|
<div
|
||||||
key={id}
|
key={id}
|
||||||
className="group flex cursor-pointer border-b border-mineshaft-600 hover:bg-mineshaft-700"
|
className={twMerge(
|
||||||
|
"group flex cursor-pointer border-b border-mineshaft-600 hover:bg-mineshaft-700",
|
||||||
|
isPending && "bg-mineshaft-700/60",
|
||||||
|
pendingAction === "delete" && "border-l-2 border-l-red-600/75",
|
||||||
|
pendingAction === "update" && "border-l-2 border-l-yellow-600/75",
|
||||||
|
pendingAction === "create" && "border-l-2 border-l-green-600/75"
|
||||||
|
)}
|
||||||
>
|
>
|
||||||
<div className="flex w-11 items-center px-5 py-3 text-yellow-700">
|
<div className="flex w-11 items-center px-5 py-3 text-yellow-700">
|
||||||
<FontAwesomeIcon icon={faFolder} />
|
<FontAwesomeIcon icon={faFolder} />
|
||||||
@@ -113,9 +210,9 @@ export const FolderListView = ({
|
|||||||
role="button"
|
role="button"
|
||||||
tabIndex={0}
|
tabIndex={0}
|
||||||
onKeyDown={(evt) => {
|
onKeyDown={(evt) => {
|
||||||
if (evt.key === "Enter") handleFolderClick(name);
|
if (evt.key === "Enter") handleFolderClick(name, isPending);
|
||||||
}}
|
}}
|
||||||
onClick={() => handleFolderClick(name)}
|
onClick={() => handleFolderClick(name, isPending)}
|
||||||
>
|
>
|
||||||
{name}
|
{name}
|
||||||
{description && (
|
{description && (
|
||||||
@@ -128,46 +225,71 @@ export const FolderListView = ({
|
|||||||
</Tooltip>
|
</Tooltip>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
<div className="flex items-center space-x-4 border-l border-mineshaft-600 px-3 py-3">
|
{isPending ? (
|
||||||
<ProjectPermissionCan
|
<div className="flex items-center space-x-4 border-l border-mineshaft-600 px-3 py-3">
|
||||||
I={ProjectPermissionActions.Edit}
|
<IconButton
|
||||||
a={subject(ProjectPermissionSub.SecretFolders, { environment, secretPath })}
|
ariaLabel="edit-folder"
|
||||||
renderTooltip
|
variant="plain"
|
||||||
allowedLabel="Edit"
|
size="sm"
|
||||||
>
|
className="p-0 opacity-0 group-hover:opacity-100"
|
||||||
{(isAllowed) => (
|
isDisabled
|
||||||
<IconButton
|
onClick={() => {}}
|
||||||
ariaLabel="edit-folder"
|
>
|
||||||
variant="plain"
|
<FontAwesomeIcon icon={faPencilSquare} size="lg" />
|
||||||
size="sm"
|
</IconButton>
|
||||||
className="p-0 opacity-0 group-hover:opacity-100"
|
|
||||||
onClick={() => handlePopUpOpen("updateFolder", { id, name, description })}
|
<IconButton
|
||||||
isDisabled={!isAllowed}
|
ariaLabel="delete-folder"
|
||||||
>
|
variant="plain"
|
||||||
<FontAwesomeIcon icon={faPencilSquare} size="lg" />
|
size="md"
|
||||||
</IconButton>
|
className="p-0 opacity-0 group-hover:opacity-100"
|
||||||
)}
|
onClick={() => handleDeletePending(id)}
|
||||||
</ProjectPermissionCan>
|
>
|
||||||
<ProjectPermissionCan
|
<FontAwesomeIcon icon={faClose} size="lg" />
|
||||||
I={ProjectPermissionActions.Delete}
|
</IconButton>
|
||||||
a={subject(ProjectPermissionSub.SecretFolders, { environment, secretPath })}
|
</div>
|
||||||
renderTooltip
|
) : (
|
||||||
allowedLabel="Delete"
|
<div className="flex items-center space-x-4 border-l border-mineshaft-600 px-3 py-3">
|
||||||
>
|
<ProjectPermissionCan
|
||||||
{(isAllowed) => (
|
I={ProjectPermissionActions.Edit}
|
||||||
<IconButton
|
a={subject(ProjectPermissionSub.SecretFolders, { environment, secretPath })}
|
||||||
ariaLabel="delete-folder"
|
renderTooltip
|
||||||
variant="plain"
|
allowedLabel="Edit"
|
||||||
size="md"
|
>
|
||||||
className="p-0 opacity-0 group-hover:opacity-100"
|
{(isAllowed) => (
|
||||||
onClick={() => handlePopUpOpen("deleteFolder", { id, name })}
|
<IconButton
|
||||||
isDisabled={!isAllowed}
|
ariaLabel="edit-folder"
|
||||||
>
|
variant="plain"
|
||||||
<FontAwesomeIcon icon={faClose} size="lg" />
|
size="sm"
|
||||||
</IconButton>
|
className="p-0 opacity-0 group-hover:opacity-100"
|
||||||
)}
|
onClick={() => handlePopUpOpen("updateFolder", { id, name, description })}
|
||||||
</ProjectPermissionCan>
|
isDisabled={!isAllowed}
|
||||||
</div>
|
>
|
||||||
|
<FontAwesomeIcon icon={faPencilSquare} size="lg" />
|
||||||
|
</IconButton>
|
||||||
|
)}
|
||||||
|
</ProjectPermissionCan>
|
||||||
|
<ProjectPermissionCan
|
||||||
|
I={ProjectPermissionActions.Delete}
|
||||||
|
a={subject(ProjectPermissionSub.SecretFolders, { environment, secretPath })}
|
||||||
|
renderTooltip
|
||||||
|
allowedLabel="Delete"
|
||||||
|
>
|
||||||
|
{(isAllowed) => (
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="delete-folder"
|
||||||
|
variant="plain"
|
||||||
|
size="md"
|
||||||
|
className="p-0 opacity-0 group-hover:opacity-100"
|
||||||
|
onClick={() => handlePopUpOpen("deleteFolder", { id, name })}
|
||||||
|
isDisabled={!isAllowed}
|
||||||
|
>
|
||||||
|
<FontAwesomeIcon icon={faClose} size="lg" />
|
||||||
|
</IconButton>
|
||||||
|
)}
|
||||||
|
</ProjectPermissionCan>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
))}
|
))}
|
||||||
<Modal
|
<Modal
|
||||||
|
|||||||
+336
-273
@@ -57,6 +57,7 @@ import {
|
|||||||
TFormSchema
|
TFormSchema
|
||||||
} from "./SecretListView.utils";
|
} from "./SecretListView.utils";
|
||||||
import { CollapsibleSecretImports } from "./CollapsibleSecretImports";
|
import { CollapsibleSecretImports } from "./CollapsibleSecretImports";
|
||||||
|
import { useBatchModeActions } from "../../SecretMainPage.store";
|
||||||
|
|
||||||
export const HIDDEN_SECRET_VALUE = "******";
|
export const HIDDEN_SECRET_VALUE = "******";
|
||||||
export const HIDDEN_SECRET_VALUE_API_MASK = "<hidden-by-infisical>";
|
export const HIDDEN_SECRET_VALUE_API_MASK = "<hidden-by-infisical>";
|
||||||
@@ -86,6 +87,8 @@ type Props = {
|
|||||||
isImported: boolean;
|
isImported: boolean;
|
||||||
}[];
|
}[];
|
||||||
}[];
|
}[];
|
||||||
|
isPending?: boolean;
|
||||||
|
pendingAction?: "create" | "update" | "delete";
|
||||||
};
|
};
|
||||||
|
|
||||||
export const SecretItem = memo(
|
export const SecretItem = memo(
|
||||||
@@ -102,7 +105,9 @@ export const SecretItem = memo(
|
|||||||
environment,
|
environment,
|
||||||
secretPath,
|
secretPath,
|
||||||
handleSecretShare,
|
handleSecretShare,
|
||||||
importedBy
|
importedBy,
|
||||||
|
isPending,
|
||||||
|
pendingAction
|
||||||
}: Props) => {
|
}: Props) => {
|
||||||
const { handlePopUpOpen, handlePopUpToggle, handlePopUpClose, popUp } = usePopUp([
|
const { handlePopUpOpen, handlePopUpToggle, handlePopUpClose, popUp } = usePopUp([
|
||||||
"editSecret"
|
"editSecret"
|
||||||
@@ -110,6 +115,15 @@ export const SecretItem = memo(
|
|||||||
const { currentWorkspace } = useWorkspace();
|
const { currentWorkspace } = useWorkspace();
|
||||||
const { permission } = useProjectPermission();
|
const { permission } = useProjectPermission();
|
||||||
const { isRotatedSecret } = secret;
|
const { isRotatedSecret } = secret;
|
||||||
|
const { removePendingChange } = useBatchModeActions();
|
||||||
|
|
||||||
|
const handleDeletePending = (pendingSecret: SecretV3RawSanitized) => {
|
||||||
|
removePendingChange(pendingSecret.id, "secret", {
|
||||||
|
workspaceId: currentWorkspace.id,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
const canEditSecretValue = permission.can(
|
const canEditSecretValue = permission.can(
|
||||||
ProjectPermissionSecretActions.Edit,
|
ProjectPermissionSecretActions.Edit,
|
||||||
@@ -273,14 +287,19 @@ export const SecretItem = memo(
|
|||||||
className={twMerge(
|
className={twMerge(
|
||||||
"border-b border-mineshaft-600 bg-mineshaft-800 shadow-none hover:bg-mineshaft-700",
|
"border-b border-mineshaft-600 bg-mineshaft-800 shadow-none hover:bg-mineshaft-700",
|
||||||
isDirty && "border-primary-400/50",
|
isDirty && "border-primary-400/50",
|
||||||
isRotatedSecret && "bg-mineshaft-700/60"
|
isRotatedSecret && "bg-mineshaft-700/60",
|
||||||
|
isPending && "bg-mineshaft-700/60",
|
||||||
|
pendingAction === "delete" && "border-l-2 border-l-red-600/75",
|
||||||
|
pendingAction === "update" && "border-l-2 border-l-yellow-600/75",
|
||||||
|
pendingAction === "create" && "border-l-2 border-l-green-600/75"
|
||||||
)}
|
)}
|
||||||
>
|
>
|
||||||
<div className="group flex">
|
<div className="group flex">
|
||||||
<div
|
<div
|
||||||
className={twMerge(
|
className={twMerge(
|
||||||
"flex h-11 w-11 items-center justify-center px-4 py-3 text-mineshaft-300",
|
"flex h-11 w-11 items-center justify-center px-4 py-3 text-mineshaft-300",
|
||||||
isDirty && "text-primary"
|
isDirty && "text-primary",
|
||||||
|
isPending && "ml-[-2px]"
|
||||||
)}
|
)}
|
||||||
>
|
>
|
||||||
{secret.isRotatedSecret ? (
|
{secret.isRotatedSecret ? (
|
||||||
@@ -364,7 +383,9 @@ export const SecretItem = memo(
|
|||||||
control={control}
|
control={control}
|
||||||
render={({ field }) => (
|
render={({ field }) => (
|
||||||
<InfisicalSecretInput
|
<InfisicalSecretInput
|
||||||
isReadOnly={isReadOnly || isRotatedSecret}
|
isReadOnly={
|
||||||
|
isReadOnly || isRotatedSecret || (isPending && pendingAction !== "update")
|
||||||
|
}
|
||||||
key="secret-value"
|
key="secret-value"
|
||||||
isVisible={isVisible && !secretValueHidden}
|
isVisible={isVisible && !secretValueHidden}
|
||||||
canEditButNotView={secretValueHidden && !isOverriden}
|
canEditButNotView={secretValueHidden && !isOverriden}
|
||||||
@@ -377,275 +398,160 @@ export const SecretItem = memo(
|
|||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
<div
|
{pendingAction !== "create" && pendingAction !== "delete" && (
|
||||||
key="actions"
|
<div
|
||||||
className="flex h-full flex-shrink-0 self-start transition-all group-hover:gap-x-2"
|
key="actions"
|
||||||
>
|
className="flex h-full flex-shrink-0 self-start transition-all group-hover:gap-x-2"
|
||||||
<Tooltip content="Copy secret">
|
|
||||||
<IconButton
|
|
||||||
isDisabled={secret.secretValueHidden}
|
|
||||||
ariaLabel="copy-value"
|
|
||||||
variant="plain"
|
|
||||||
size="sm"
|
|
||||||
className="w-0 overflow-hidden p-0 group-hover:w-5"
|
|
||||||
onClick={copyTokenToClipboard}
|
|
||||||
>
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
className="h-3.5 w-3"
|
|
||||||
symbolName={
|
|
||||||
isSecValueCopied
|
|
||||||
? FontAwesomeSpriteName.Check
|
|
||||||
: FontAwesomeSpriteName.ClipboardCopy
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
</IconButton>
|
|
||||||
</Tooltip>
|
|
||||||
<ProjectPermissionCan
|
|
||||||
I={ProjectPermissionActions.Edit}
|
|
||||||
a={subject(ProjectPermissionSub.Secrets, {
|
|
||||||
environment,
|
|
||||||
secretPath,
|
|
||||||
secretName,
|
|
||||||
secretTags: selectedTagSlugs
|
|
||||||
})}
|
|
||||||
>
|
>
|
||||||
{(isAllowed) => (
|
<Tooltip content="Copy secret">
|
||||||
<Modal>
|
|
||||||
<ModalTrigger asChild>
|
|
||||||
<IconButton
|
|
||||||
className="w-0 overflow-hidden p-0 group-hover:w-5"
|
|
||||||
variant="plain"
|
|
||||||
size="md"
|
|
||||||
ariaLabel="reference-tree"
|
|
||||||
isDisabled={!isAllowed || !hasSecretReference(secret?.value)}
|
|
||||||
>
|
|
||||||
<Tooltip
|
|
||||||
content={
|
|
||||||
hasSecretReference(secret?.value)
|
|
||||||
? "Secret Reference Tree"
|
|
||||||
: "Secret does not contain references"
|
|
||||||
}
|
|
||||||
>
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
className="h-3.5 w-3.5"
|
|
||||||
symbolName={FontAwesomeSpriteName.SecretReferenceTree}
|
|
||||||
/>
|
|
||||||
</Tooltip>
|
|
||||||
</IconButton>
|
|
||||||
</ModalTrigger>
|
|
||||||
<ModalContent
|
|
||||||
title="Secret Reference Details"
|
|
||||||
subTitle="Visual breakdown of secrets referenced by this secret."
|
|
||||||
onOpenAutoFocus={(e) => e.preventDefault()} // prevents secret input from displaying value on open
|
|
||||||
>
|
|
||||||
<SecretReferenceTree
|
|
||||||
secretPath={secretPath}
|
|
||||||
environment={environment}
|
|
||||||
secretKey={secret?.key}
|
|
||||||
/>
|
|
||||||
</ModalContent>
|
|
||||||
</Modal>
|
|
||||||
)}
|
|
||||||
</ProjectPermissionCan>
|
|
||||||
<DropdownMenu>
|
|
||||||
<ProjectPermissionCan
|
|
||||||
I={ProjectPermissionActions.Edit}
|
|
||||||
a={subject(ProjectPermissionSub.Secrets, {
|
|
||||||
environment,
|
|
||||||
secretPath,
|
|
||||||
secretName,
|
|
||||||
secretTags: selectedTagSlugs
|
|
||||||
})}
|
|
||||||
>
|
|
||||||
{(isAllowed) => (
|
|
||||||
<DropdownMenuTrigger asChild disabled={!isAllowed}>
|
|
||||||
<IconButton
|
|
||||||
ariaLabel="tags"
|
|
||||||
variant="plain"
|
|
||||||
size="sm"
|
|
||||||
className={twMerge(
|
|
||||||
"w-0 overflow-hidden p-0 group-hover:w-5 data-[state=open]:w-5",
|
|
||||||
hasTagsApplied && "w-5 text-primary"
|
|
||||||
)}
|
|
||||||
isDisabled={!isAllowed}
|
|
||||||
>
|
|
||||||
<Tooltip content="Tags">
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
className="h-3.5 w-3.5"
|
|
||||||
symbolName={FontAwesomeSpriteName.Tags}
|
|
||||||
/>
|
|
||||||
</Tooltip>
|
|
||||||
</IconButton>
|
|
||||||
</DropdownMenuTrigger>
|
|
||||||
)}
|
|
||||||
</ProjectPermissionCan>
|
|
||||||
<DropdownMenuContent align="end">
|
|
||||||
<DropdownMenuLabel>Add tags to this secret</DropdownMenuLabel>
|
|
||||||
{tags.map((tag) => {
|
|
||||||
const { id: tagId, slug, color } = tag;
|
|
||||||
|
|
||||||
const isTagSelected = selectedTagsGroupById?.[tagId];
|
|
||||||
return (
|
|
||||||
<DropdownMenuItem
|
|
||||||
onClick={() => handleTagSelect(tag)}
|
|
||||||
key={`${secret.id}-${tagId}`}
|
|
||||||
icon={
|
|
||||||
isTagSelected && (
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
symbolName={FontAwesomeSpriteName.CheckedCircle}
|
|
||||||
className="h-3 w-3"
|
|
||||||
/>
|
|
||||||
)
|
|
||||||
}
|
|
||||||
iconPos="right"
|
|
||||||
>
|
|
||||||
<div className="flex items-center">
|
|
||||||
<div
|
|
||||||
className="mr-2 h-2 w-2 rounded-full"
|
|
||||||
style={{ background: color || "#bec2c8" }}
|
|
||||||
/>
|
|
||||||
{slug}
|
|
||||||
</div>
|
|
||||||
</DropdownMenuItem>
|
|
||||||
);
|
|
||||||
})}
|
|
||||||
<DropdownMenuItem className="px-1.5" asChild>
|
|
||||||
<Button
|
|
||||||
size="xs"
|
|
||||||
className="w-full"
|
|
||||||
colorSchema="primary"
|
|
||||||
variant="outline_bg"
|
|
||||||
leftIcon={
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
symbolName={FontAwesomeSpriteName.Tags}
|
|
||||||
className="h-3 w-3"
|
|
||||||
/>
|
|
||||||
}
|
|
||||||
onClick={onCreateTag}
|
|
||||||
>
|
|
||||||
Create a tag
|
|
||||||
</Button>
|
|
||||||
</DropdownMenuItem>
|
|
||||||
</DropdownMenuContent>
|
|
||||||
</DropdownMenu>
|
|
||||||
<ProjectPermissionCan
|
|
||||||
I={ProjectPermissionActions.Edit}
|
|
||||||
a={subject(ProjectPermissionSub.Secrets, {
|
|
||||||
environment,
|
|
||||||
secretPath,
|
|
||||||
secretName,
|
|
||||||
secretTags: selectedTagSlugs
|
|
||||||
})}
|
|
||||||
renderTooltip
|
|
||||||
allowedLabel="Override"
|
|
||||||
>
|
|
||||||
{(isAllowed) => (
|
|
||||||
<IconButton
|
<IconButton
|
||||||
ariaLabel="override-value"
|
isDisabled={secret.secretValueHidden}
|
||||||
isDisabled={!isAllowed}
|
ariaLabel="copy-value"
|
||||||
variant="plain"
|
variant="plain"
|
||||||
size="sm"
|
size="sm"
|
||||||
onClick={handleOverrideClick}
|
className="w-0 overflow-hidden p-0 group-hover:w-5"
|
||||||
className={twMerge(
|
onClick={copyTokenToClipboard}
|
||||||
"w-0 overflow-hidden p-0 group-hover:w-5",
|
|
||||||
isOverriden && "w-5 text-primary"
|
|
||||||
)}
|
|
||||||
>
|
>
|
||||||
<FontAwesomeSymbol
|
<FontAwesomeSymbol
|
||||||
symbolName={FontAwesomeSpriteName.Override}
|
className="h-3.5 w-3"
|
||||||
className="h-3.5 w-3.5"
|
symbolName={
|
||||||
/>
|
isSecValueCopied
|
||||||
</IconButton>
|
? FontAwesomeSpriteName.Check
|
||||||
)}
|
: FontAwesomeSpriteName.ClipboardCopy
|
||||||
</ProjectPermissionCan>
|
}
|
||||||
<Popover>
|
|
||||||
<ProjectPermissionCan
|
|
||||||
I={ProjectPermissionActions.Edit}
|
|
||||||
a={subject(ProjectPermissionSub.Secrets, {
|
|
||||||
environment,
|
|
||||||
secretPath,
|
|
||||||
secretName,
|
|
||||||
secretTags: selectedTagSlugs
|
|
||||||
})}
|
|
||||||
>
|
|
||||||
{(isAllowed) => (
|
|
||||||
<PopoverTrigger asChild disabled={!isAllowed}>
|
|
||||||
<IconButton
|
|
||||||
className={twMerge(
|
|
||||||
"w-0 overflow-hidden p-0 group-hover:w-5",
|
|
||||||
hasComment && "w-5 text-primary"
|
|
||||||
)}
|
|
||||||
variant="plain"
|
|
||||||
size="md"
|
|
||||||
ariaLabel="add-comment"
|
|
||||||
isDisabled={!isAllowed}
|
|
||||||
>
|
|
||||||
<Tooltip content="Comment">
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
className="h-3.5 w-3.5"
|
|
||||||
symbolName={FontAwesomeSpriteName.Comment}
|
|
||||||
/>
|
|
||||||
</Tooltip>
|
|
||||||
</IconButton>
|
|
||||||
</PopoverTrigger>
|
|
||||||
)}
|
|
||||||
</ProjectPermissionCan>
|
|
||||||
<IconButton
|
|
||||||
isDisabled={secret.secretValueHidden || !currentWorkspace.secretSharing}
|
|
||||||
className="w-0 overflow-hidden p-0 group-hover:w-5"
|
|
||||||
variant="plain"
|
|
||||||
size="md"
|
|
||||||
ariaLabel="share-secret"
|
|
||||||
onClick={handleSecretShare}
|
|
||||||
>
|
|
||||||
<Tooltip content="Share Secret">
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
className="h-3.5 w-3.5"
|
|
||||||
symbolName={FontAwesomeSpriteName.ShareSecret}
|
|
||||||
/>
|
|
||||||
</Tooltip>
|
|
||||||
</IconButton>
|
|
||||||
<PopoverContent
|
|
||||||
className="w-auto border border-mineshaft-600 bg-mineshaft-800 p-2 drop-shadow-2xl"
|
|
||||||
sticky="always"
|
|
||||||
>
|
|
||||||
<FormControl label="Comment" className="mb-0">
|
|
||||||
<TextArea
|
|
||||||
className="border border-mineshaft-600 text-sm"
|
|
||||||
rows={8}
|
|
||||||
cols={30}
|
|
||||||
{...register("comment")}
|
|
||||||
/>
|
|
||||||
</FormControl>
|
|
||||||
</PopoverContent>
|
|
||||||
</Popover>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<AnimatePresence mode="wait">
|
|
||||||
{!isDirty ? (
|
|
||||||
<motion.div
|
|
||||||
key="options"
|
|
||||||
className="flex h-10 flex-shrink-0 items-center space-x-4 px-[0.64rem]"
|
|
||||||
initial={{ x: 0, opacity: 0 }}
|
|
||||||
animate={{ x: 0, opacity: 1 }}
|
|
||||||
exit={{ x: 10, opacity: 0 }}
|
|
||||||
>
|
|
||||||
<Tooltip content="More">
|
|
||||||
<IconButton
|
|
||||||
ariaLabel="more"
|
|
||||||
variant="plain"
|
|
||||||
size="md"
|
|
||||||
className="h-5 w-4 p-0 opacity-0 group-hover:opacity-100"
|
|
||||||
onClick={() => onDetailViewSecret(secret)}
|
|
||||||
>
|
|
||||||
<FontAwesomeSymbol
|
|
||||||
symbolName={FontAwesomeSpriteName.More}
|
|
||||||
className="h-5 w-4"
|
|
||||||
/>
|
/>
|
||||||
</IconButton>
|
</IconButton>
|
||||||
</Tooltip>
|
</Tooltip>
|
||||||
<ProjectPermissionCan
|
<ProjectPermissionCan
|
||||||
I={ProjectPermissionActions.Delete}
|
I={ProjectPermissionActions.Edit}
|
||||||
|
a={subject(ProjectPermissionSub.Secrets, {
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
secretName,
|
||||||
|
secretTags: selectedTagSlugs
|
||||||
|
})}
|
||||||
|
>
|
||||||
|
{(isAllowed) => (
|
||||||
|
<Modal>
|
||||||
|
<ModalTrigger asChild>
|
||||||
|
<IconButton
|
||||||
|
className="w-0 overflow-hidden p-0 group-hover:w-5"
|
||||||
|
variant="plain"
|
||||||
|
size="md"
|
||||||
|
ariaLabel="reference-tree"
|
||||||
|
isDisabled={!isAllowed || !hasSecretReference(secret?.value)}
|
||||||
|
>
|
||||||
|
<Tooltip
|
||||||
|
content={
|
||||||
|
hasSecretReference(secret?.value)
|
||||||
|
? "Secret Reference Tree"
|
||||||
|
: "Secret does not contain references"
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
className="h-3.5 w-3.5"
|
||||||
|
symbolName={FontAwesomeSpriteName.SecretReferenceTree}
|
||||||
|
/>
|
||||||
|
</Tooltip>
|
||||||
|
</IconButton>
|
||||||
|
</ModalTrigger>
|
||||||
|
<ModalContent
|
||||||
|
title="Secret Reference Details"
|
||||||
|
subTitle="Visual breakdown of secrets referenced by this secret."
|
||||||
|
onOpenAutoFocus={(e) => e.preventDefault()} // prevents secret input from displaying value on open
|
||||||
|
>
|
||||||
|
<SecretReferenceTree
|
||||||
|
secretPath={secretPath}
|
||||||
|
environment={environment}
|
||||||
|
secretKey={secret?.key}
|
||||||
|
/>
|
||||||
|
</ModalContent>
|
||||||
|
</Modal>
|
||||||
|
)}
|
||||||
|
</ProjectPermissionCan>
|
||||||
|
<DropdownMenu>
|
||||||
|
<ProjectPermissionCan
|
||||||
|
I={ProjectPermissionActions.Edit}
|
||||||
|
a={subject(ProjectPermissionSub.Secrets, {
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
secretName,
|
||||||
|
secretTags: selectedTagSlugs
|
||||||
|
})}
|
||||||
|
>
|
||||||
|
{(isAllowed) => (
|
||||||
|
<DropdownMenuTrigger asChild disabled={!isAllowed}>
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="tags"
|
||||||
|
variant="plain"
|
||||||
|
size="sm"
|
||||||
|
className={twMerge(
|
||||||
|
"w-0 overflow-hidden p-0 group-hover:w-5 data-[state=open]:w-5",
|
||||||
|
hasTagsApplied && "w-5 text-primary"
|
||||||
|
)}
|
||||||
|
isDisabled={!isAllowed}
|
||||||
|
>
|
||||||
|
<Tooltip content="Tags">
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
className="h-3.5 w-3.5"
|
||||||
|
symbolName={FontAwesomeSpriteName.Tags}
|
||||||
|
/>
|
||||||
|
</Tooltip>
|
||||||
|
</IconButton>
|
||||||
|
</DropdownMenuTrigger>
|
||||||
|
)}
|
||||||
|
</ProjectPermissionCan>
|
||||||
|
<DropdownMenuContent align="end">
|
||||||
|
<DropdownMenuLabel>Add tags to this secret</DropdownMenuLabel>
|
||||||
|
{tags.map((tag) => {
|
||||||
|
const { id: tagId, slug, color } = tag;
|
||||||
|
|
||||||
|
const isTagSelected = selectedTagsGroupById?.[tagId];
|
||||||
|
return (
|
||||||
|
<DropdownMenuItem
|
||||||
|
onClick={() => handleTagSelect(tag)}
|
||||||
|
key={`${secret.id}-${tagId}`}
|
||||||
|
icon={
|
||||||
|
isTagSelected && (
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
symbolName={FontAwesomeSpriteName.CheckedCircle}
|
||||||
|
className="h-3 w-3"
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
}
|
||||||
|
iconPos="right"
|
||||||
|
>
|
||||||
|
<div className="flex items-center">
|
||||||
|
<div
|
||||||
|
className="mr-2 h-2 w-2 rounded-full"
|
||||||
|
style={{ background: color || "#bec2c8" }}
|
||||||
|
/>
|
||||||
|
{slug}
|
||||||
|
</div>
|
||||||
|
</DropdownMenuItem>
|
||||||
|
);
|
||||||
|
})}
|
||||||
|
<DropdownMenuItem className="px-1.5" asChild>
|
||||||
|
<Button
|
||||||
|
size="xs"
|
||||||
|
className="w-full"
|
||||||
|
colorSchema="primary"
|
||||||
|
variant="outline_bg"
|
||||||
|
leftIcon={
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
symbolName={FontAwesomeSpriteName.Tags}
|
||||||
|
className="h-3 w-3"
|
||||||
|
/>
|
||||||
|
}
|
||||||
|
onClick={onCreateTag}
|
||||||
|
>
|
||||||
|
Create a tag
|
||||||
|
</Button>
|
||||||
|
</DropdownMenuItem>
|
||||||
|
</DropdownMenuContent>
|
||||||
|
</DropdownMenu>
|
||||||
|
<ProjectPermissionCan
|
||||||
|
I={ProjectPermissionActions.Edit}
|
||||||
a={subject(ProjectPermissionSub.Secrets, {
|
a={subject(ProjectPermissionSub.Secrets, {
|
||||||
environment,
|
environment,
|
||||||
secretPath,
|
secretPath,
|
||||||
@@ -653,26 +559,183 @@ export const SecretItem = memo(
|
|||||||
secretTags: selectedTagSlugs
|
secretTags: selectedTagSlugs
|
||||||
})}
|
})}
|
||||||
renderTooltip
|
renderTooltip
|
||||||
allowedLabel={isRotatedSecret ? "Cannot Delete Rotated Secret" : "Delete"} // just using label for isRotatedSecret, disabled below
|
allowedLabel="Override"
|
||||||
>
|
>
|
||||||
{(isAllowed) => (
|
{(isAllowed) => (
|
||||||
<IconButton
|
<IconButton
|
||||||
ariaLabel="delete-value"
|
ariaLabel="override-value"
|
||||||
|
isDisabled={!isAllowed}
|
||||||
variant="plain"
|
variant="plain"
|
||||||
colorSchema="danger"
|
size="sm"
|
||||||
size="md"
|
onClick={handleOverrideClick}
|
||||||
className="p-0 opacity-0 group-hover:opacity-100"
|
className={twMerge(
|
||||||
onClick={() => onDeleteSecret(secret)}
|
"w-0 overflow-hidden p-0 group-hover:w-5",
|
||||||
isDisabled={!isAllowed || isRotatedSecret}
|
isOverriden && "w-5 text-primary"
|
||||||
|
)}
|
||||||
>
|
>
|
||||||
<FontAwesomeSymbol
|
<FontAwesomeSymbol
|
||||||
symbolName={FontAwesomeSpriteName.Close}
|
symbolName={FontAwesomeSpriteName.Override}
|
||||||
className="h-5 w-4"
|
className="h-3.5 w-3.5"
|
||||||
/>
|
/>
|
||||||
</IconButton>
|
</IconButton>
|
||||||
)}
|
)}
|
||||||
</ProjectPermissionCan>
|
</ProjectPermissionCan>
|
||||||
</motion.div>
|
<Popover>
|
||||||
|
<ProjectPermissionCan
|
||||||
|
I={ProjectPermissionActions.Edit}
|
||||||
|
a={subject(ProjectPermissionSub.Secrets, {
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
secretName,
|
||||||
|
secretTags: selectedTagSlugs
|
||||||
|
})}
|
||||||
|
>
|
||||||
|
{(isAllowed) => (
|
||||||
|
<PopoverTrigger asChild disabled={!isAllowed}>
|
||||||
|
<IconButton
|
||||||
|
className={twMerge(
|
||||||
|
"w-0 overflow-hidden p-0 group-hover:w-5",
|
||||||
|
hasComment && "w-5 text-primary"
|
||||||
|
)}
|
||||||
|
variant="plain"
|
||||||
|
size="md"
|
||||||
|
ariaLabel="add-comment"
|
||||||
|
isDisabled={!isAllowed}
|
||||||
|
>
|
||||||
|
<Tooltip content="Comment">
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
className="h-3.5 w-3.5"
|
||||||
|
symbolName={FontAwesomeSpriteName.Comment}
|
||||||
|
/>
|
||||||
|
</Tooltip>
|
||||||
|
</IconButton>
|
||||||
|
</PopoverTrigger>
|
||||||
|
)}
|
||||||
|
</ProjectPermissionCan>
|
||||||
|
<IconButton
|
||||||
|
isDisabled={secret.secretValueHidden || !currentWorkspace.secretSharing}
|
||||||
|
className="w-0 overflow-hidden p-0 group-hover:w-5"
|
||||||
|
variant="plain"
|
||||||
|
size="md"
|
||||||
|
ariaLabel="share-secret"
|
||||||
|
onClick={handleSecretShare}
|
||||||
|
>
|
||||||
|
<Tooltip content="Share Secret">
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
className="h-3.5 w-3.5"
|
||||||
|
symbolName={FontAwesomeSpriteName.ShareSecret}
|
||||||
|
/>
|
||||||
|
</Tooltip>
|
||||||
|
</IconButton>
|
||||||
|
<PopoverContent
|
||||||
|
className="w-auto border border-mineshaft-600 bg-mineshaft-800 p-2 drop-shadow-2xl"
|
||||||
|
sticky="always"
|
||||||
|
>
|
||||||
|
<FormControl label="Comment" className="mb-0">
|
||||||
|
<TextArea
|
||||||
|
className="border border-mineshaft-600 text-sm"
|
||||||
|
rows={8}
|
||||||
|
cols={30}
|
||||||
|
{...register("comment")}
|
||||||
|
/>
|
||||||
|
</FormControl>
|
||||||
|
</PopoverContent>
|
||||||
|
</Popover>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
<AnimatePresence mode="wait">
|
||||||
|
{!isDirty ? (
|
||||||
|
isPending ? (
|
||||||
|
<motion.div
|
||||||
|
key="options"
|
||||||
|
className="flex h-10 flex-shrink-0 items-center space-x-4 px-[0.64rem]"
|
||||||
|
initial={{ x: 0, opacity: 0 }}
|
||||||
|
animate={{ x: 0, opacity: 1 }}
|
||||||
|
exit={{ x: 10, opacity: 0 }}
|
||||||
|
>
|
||||||
|
<Tooltip content="More">
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="more"
|
||||||
|
variant="plain"
|
||||||
|
size="md"
|
||||||
|
className="h-5 w-4 p-0 opacity-0 group-hover:opacity-100"
|
||||||
|
onClick={() => onDetailViewSecret(secret)}
|
||||||
|
isDisabled={pendingAction !== "update"}
|
||||||
|
>
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
symbolName={FontAwesomeSpriteName.More}
|
||||||
|
className="h-5 w-4"
|
||||||
|
/>
|
||||||
|
</IconButton>
|
||||||
|
</Tooltip>
|
||||||
|
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="delete-value"
|
||||||
|
variant="plain"
|
||||||
|
colorSchema="danger"
|
||||||
|
size="md"
|
||||||
|
className="p-0 opacity-0 group-hover:opacity-100"
|
||||||
|
onClick={() => handleDeletePending(secret)}
|
||||||
|
>
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
symbolName={FontAwesomeSpriteName.Close}
|
||||||
|
className="h-5 w-4"
|
||||||
|
/>
|
||||||
|
</IconButton>
|
||||||
|
</motion.div>
|
||||||
|
) : (
|
||||||
|
<motion.div
|
||||||
|
key="options"
|
||||||
|
className="flex h-10 flex-shrink-0 items-center space-x-4 px-[0.64rem]"
|
||||||
|
initial={{ x: 0, opacity: 0 }}
|
||||||
|
animate={{ x: 0, opacity: 1 }}
|
||||||
|
exit={{ x: 10, opacity: 0 }}
|
||||||
|
>
|
||||||
|
<Tooltip content="More">
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="more"
|
||||||
|
variant="plain"
|
||||||
|
size="md"
|
||||||
|
className="h-5 w-4 p-0 opacity-0 group-hover:opacity-100"
|
||||||
|
onClick={() => onDetailViewSecret(secret)}
|
||||||
|
>
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
symbolName={FontAwesomeSpriteName.More}
|
||||||
|
className="h-5 w-4"
|
||||||
|
/>
|
||||||
|
</IconButton>
|
||||||
|
</Tooltip>
|
||||||
|
<ProjectPermissionCan
|
||||||
|
I={ProjectPermissionActions.Delete}
|
||||||
|
a={subject(ProjectPermissionSub.Secrets, {
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
secretName,
|
||||||
|
secretTags: selectedTagSlugs
|
||||||
|
})}
|
||||||
|
renderTooltip
|
||||||
|
allowedLabel={isRotatedSecret ? "Cannot Delete Rotated Secret" : "Delete"} // just using label for isRotatedSecret, disabled below
|
||||||
|
>
|
||||||
|
{(isAllowed) => (
|
||||||
|
<IconButton
|
||||||
|
ariaLabel="delete-value"
|
||||||
|
variant="plain"
|
||||||
|
colorSchema="danger"
|
||||||
|
size="md"
|
||||||
|
className="p-0 opacity-0 group-hover:opacity-100"
|
||||||
|
onClick={() => onDeleteSecret(secret)}
|
||||||
|
isDisabled={!isAllowed || isRotatedSecret}
|
||||||
|
>
|
||||||
|
<FontAwesomeSymbol
|
||||||
|
symbolName={FontAwesomeSpriteName.Close}
|
||||||
|
className="h-5 w-4"
|
||||||
|
/>
|
||||||
|
</IconButton>
|
||||||
|
)}
|
||||||
|
</ProjectPermissionCan>
|
||||||
|
</motion.div>
|
||||||
|
)
|
||||||
) : (
|
) : (
|
||||||
<motion.div
|
<motion.div
|
||||||
key="options-save"
|
key="options-save"
|
||||||
|
|||||||
+175
-15
@@ -17,7 +17,16 @@ import { secretSnapshotKeys } from "@app/hooks/api/secretSnapshots/queries";
|
|||||||
import { WsTag } from "@app/hooks/api/types";
|
import { WsTag } from "@app/hooks/api/types";
|
||||||
import { AddShareSecretModal } from "@app/pages/organization/SecretSharingPage/components/ShareSecret/AddShareSecretModal";
|
import { AddShareSecretModal } from "@app/pages/organization/SecretSharingPage/components/ShareSecret/AddShareSecretModal";
|
||||||
|
|
||||||
import { useSelectedSecretActions, useSelectedSecrets } from "../../SecretMainPage.store";
|
import {
|
||||||
|
PendingSecretChange,
|
||||||
|
PendingSecretCreate,
|
||||||
|
PendingSecretDelete,
|
||||||
|
PendingSecretUpdate,
|
||||||
|
useBatchMode,
|
||||||
|
useBatchModeActions,
|
||||||
|
useSelectedSecretActions,
|
||||||
|
useSelectedSecrets
|
||||||
|
} from "../../SecretMainPage.store";
|
||||||
import { CollapsibleSecretImports } from "./CollapsibleSecretImports";
|
import { CollapsibleSecretImports } from "./CollapsibleSecretImports";
|
||||||
import { SecretDetailSidebar } from "./SecretDetailSidebar";
|
import { SecretDetailSidebar } from "./SecretDetailSidebar";
|
||||||
import { HIDDEN_SECRET_VALUE, HIDDEN_SECRET_VALUE_API_MASK, SecretItem } from "./SecretItem";
|
import { HIDDEN_SECRET_VALUE, HIDDEN_SECRET_VALUE_API_MASK, SecretItem } from "./SecretItem";
|
||||||
@@ -63,22 +72,19 @@ export const SecretListView = ({
|
|||||||
|
|
||||||
// strip of side effect queries
|
// strip of side effect queries
|
||||||
const { mutateAsync: createSecretV3 } = useCreateSecretV3({
|
const { mutateAsync: createSecretV3 } = useCreateSecretV3({
|
||||||
options: {
|
options: { onSuccess: undefined }
|
||||||
onSuccess: undefined
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
const { mutateAsync: updateSecretV3 } = useUpdateSecretV3({
|
const { mutateAsync: updateSecretV3 } = useUpdateSecretV3({
|
||||||
options: {
|
options: { onSuccess: undefined }
|
||||||
onSuccess: undefined
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
const { mutateAsync: deleteSecretV3 } = useDeleteSecretV3({
|
const { mutateAsync: deleteSecretV3 } = useDeleteSecretV3({
|
||||||
options: {
|
options: { onSuccess: undefined }
|
||||||
onSuccess: undefined
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
|
|
||||||
const selectedSecrets = useSelectedSecrets();
|
const selectedSecrets = useSelectedSecrets();
|
||||||
const { toggle: toggleSelectedSecret } = useSelectedSecretActions();
|
const { toggle: toggleSelectedSecret } = useSelectedSecretActions();
|
||||||
|
const { isBatchMode, pendingChanges } = useBatchMode();
|
||||||
|
const { addPendingChange } = useBatchModeActions();
|
||||||
|
|
||||||
const handleSecretOperation = async (
|
const handleSecretOperation = async (
|
||||||
operation: "create" | "update" | "delete",
|
operation: "create" | "update" | "delete",
|
||||||
@@ -170,11 +176,56 @@ export const SecretListView = ({
|
|||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
function getTrueOriginalSecret(
|
||||||
|
currentSecret: SecretV3RawSanitized,
|
||||||
|
pendingSecrets: PendingSecretChange[]
|
||||||
|
): Omit<SecretV3RawSanitized, "tags"> & {
|
||||||
|
tags?: { id: string; slug: string }[];
|
||||||
|
} {
|
||||||
|
// Find if there's already a pending change for this secret
|
||||||
|
const existingChange = pendingSecrets.find((change) => change.id === currentSecret.id);
|
||||||
|
|
||||||
|
if (!existingChange || existingChange.type === "create") {
|
||||||
|
// If no existing change or it's a creation, current secret is the original
|
||||||
|
return {
|
||||||
|
...currentSecret,
|
||||||
|
tags: currentSecret.tags?.map((tag) => ({
|
||||||
|
id: tag.id,
|
||||||
|
slug: tag.slug
|
||||||
|
}))
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
if (existingChange.type === "update") {
|
||||||
|
// If there's an existing update, reconstruct the original from the stored original values
|
||||||
|
return {
|
||||||
|
...currentSecret,
|
||||||
|
key: existingChange.secretKey, // Original key
|
||||||
|
value: existingChange.originalValue || currentSecret.value,
|
||||||
|
comment: existingChange.originalComment || currentSecret.comment,
|
||||||
|
skipMultilineEncoding:
|
||||||
|
existingChange.originalSkipMultilineEncoding ?? currentSecret.skipMultilineEncoding,
|
||||||
|
tags:
|
||||||
|
existingChange.originalTags?.map((tag) => ({
|
||||||
|
id: tag.id,
|
||||||
|
slug: tag.slug
|
||||||
|
})) || currentSecret.tags,
|
||||||
|
secretMetadata: existingChange.originalSecretMetadata || currentSecret.secretMetadata
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
...currentSecret,
|
||||||
|
tags: currentSecret.tags?.map((tag) => ({ id: tag.id, slug: tag.slug }))
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// Improved handleSaveSecret function
|
||||||
const handleSaveSecret = useCallback(
|
const handleSaveSecret = useCallback(
|
||||||
async (
|
async (
|
||||||
orgSecret: SecretV3RawSanitized,
|
orgSecret: SecretV3RawSanitized,
|
||||||
modSecret: Omit<SecretV3RawSanitized, "tags"> & {
|
modSecret: Omit<SecretV3RawSanitized, "tags"> & {
|
||||||
tags?: { id: string }[];
|
tags?: { id: string; name?: string }[];
|
||||||
secretMetadata?: { key: string; value: string }[];
|
secretMetadata?: { key: string; value: string }[];
|
||||||
},
|
},
|
||||||
cb?: () => void
|
cb?: () => void
|
||||||
@@ -192,7 +243,9 @@ export const SecretListView = ({
|
|||||||
reminderNote,
|
reminderNote,
|
||||||
reminderRecipients,
|
reminderRecipients,
|
||||||
secretMetadata,
|
secretMetadata,
|
||||||
isReminderEvent
|
isReminderEvent,
|
||||||
|
isPending,
|
||||||
|
pendingAction
|
||||||
} = modSecret;
|
} = modSecret;
|
||||||
const hasKeyChanged = oldKey !== key && key;
|
const hasKeyChanged = oldKey !== key && key;
|
||||||
|
|
||||||
@@ -246,6 +299,79 @@ export const SecretListView = ({
|
|||||||
|
|
||||||
// shared secret change
|
// shared secret change
|
||||||
if (!isSharedSecUnchanged && !personalAction) {
|
if (!isSharedSecUnchanged && !personalAction) {
|
||||||
|
if (isBatchMode) {
|
||||||
|
const isEditingPendingCreation = isPending && pendingAction === "create";
|
||||||
|
|
||||||
|
if (isEditingPendingCreation) {
|
||||||
|
const updatedCreate: PendingSecretCreate = {
|
||||||
|
id: orgSecret.id,
|
||||||
|
type: "create",
|
||||||
|
secretKey: key,
|
||||||
|
secretValue: value || "",
|
||||||
|
secretComment: comment || "",
|
||||||
|
skipMultilineEncoding: modSecret.skipMultilineEncoding || false,
|
||||||
|
tags: tags?.map((tag) => ({ id: tag.id, slug: tag.name || "" })) || [],
|
||||||
|
secretMetadata: secretMetadata || [],
|
||||||
|
timestamp: Date.now(),
|
||||||
|
resourceType: "secret",
|
||||||
|
originalKey: oldKey
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(updatedCreate, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
const trueOriginalSecret = getTrueOriginalSecret(orgSecret, pendingChanges.secrets);
|
||||||
|
|
||||||
|
const updateChange: PendingSecretUpdate = {
|
||||||
|
id: orgSecret.id,
|
||||||
|
type: "update",
|
||||||
|
secretKey: trueOriginalSecret.key,
|
||||||
|
...(key !== trueOriginalSecret.key && { newSecretName: key }),
|
||||||
|
...(value !== trueOriginalSecret.value && {
|
||||||
|
originalValue: trueOriginalSecret.value,
|
||||||
|
secretValue: value
|
||||||
|
}),
|
||||||
|
...(comment !== trueOriginalSecret.comment && {
|
||||||
|
originalComment: trueOriginalSecret.comment,
|
||||||
|
secretComment: comment
|
||||||
|
}),
|
||||||
|
...(modSecret.skipMultilineEncoding !==
|
||||||
|
trueOriginalSecret.skipMultilineEncoding && {
|
||||||
|
originalSkipMultilineEncoding: trueOriginalSecret.skipMultilineEncoding,
|
||||||
|
skipMultilineEncoding: modSecret.skipMultilineEncoding
|
||||||
|
}),
|
||||||
|
...(!isSameTags && {
|
||||||
|
originalTags:
|
||||||
|
trueOriginalSecret.tags?.map((tag) => ({ id: tag.id, slug: tag.slug })) || [],
|
||||||
|
tags: tags?.map((tag) => ({ id: tag.id, slug: tag.name || "" })) || []
|
||||||
|
}),
|
||||||
|
...(JSON.stringify(secretMetadata) !==
|
||||||
|
JSON.stringify(trueOriginalSecret.secretMetadata) && {
|
||||||
|
originalSecretMetadata: trueOriginalSecret.secretMetadata || [],
|
||||||
|
secretMetadata: secretMetadata || []
|
||||||
|
}),
|
||||||
|
|
||||||
|
timestamp: Date.now(),
|
||||||
|
resourceType: "secret"
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(updateChange, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!isReminderEvent) {
|
||||||
|
handlePopUpClose("secretDetail");
|
||||||
|
}
|
||||||
|
if (cb) cb();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
await handleSecretOperation("update", SecretType.Shared, oldKey, {
|
await handleSecretOperation("update", SecretType.Shared, oldKey, {
|
||||||
value,
|
value,
|
||||||
tags: tagIds,
|
tags: tagIds,
|
||||||
@@ -314,12 +440,41 @@ export const SecretListView = ({
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
[environment, secretPath, isProtectedBranch]
|
[
|
||||||
|
environment,
|
||||||
|
secretPath,
|
||||||
|
isProtectedBranch,
|
||||||
|
isBatchMode,
|
||||||
|
workspaceId,
|
||||||
|
addPendingChange,
|
||||||
|
pendingChanges.secrets
|
||||||
|
]
|
||||||
);
|
);
|
||||||
|
|
||||||
const handleSecretDelete = useCallback(async () => {
|
const handleSecretDelete = useCallback(async () => {
|
||||||
const { key, id: secretId } = popUp.deleteSecret?.data as SecretV3RawSanitized;
|
const { key, id: secretId, value } = popUp.deleteSecret?.data as SecretV3RawSanitized;
|
||||||
try {
|
try {
|
||||||
|
if (isBatchMode) {
|
||||||
|
const deleteChange: PendingSecretDelete = {
|
||||||
|
id: `${secretId}`,
|
||||||
|
type: "delete",
|
||||||
|
secretKey: key,
|
||||||
|
secretValue: value || "",
|
||||||
|
timestamp: Date.now(),
|
||||||
|
resourceType: "secret"
|
||||||
|
};
|
||||||
|
|
||||||
|
addPendingChange(deleteChange, {
|
||||||
|
workspaceId,
|
||||||
|
environment,
|
||||||
|
secretPath
|
||||||
|
});
|
||||||
|
|
||||||
|
handlePopUpClose("deleteSecret");
|
||||||
|
handlePopUpClose("secretDetail");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
await handleSecretOperation("delete", SecretType.Shared, key, { secretId });
|
await handleSecretOperation("delete", SecretType.Shared, key, { secretId });
|
||||||
// wrap this in another function and then reuse
|
// wrap this in another function and then reuse
|
||||||
queryClient.invalidateQueries({
|
queryClient.invalidateQueries({
|
||||||
@@ -362,7 +517,10 @@ export const SecretListView = ({
|
|||||||
(popUp.deleteSecret?.data as SecretV3RawSanitized)?.key,
|
(popUp.deleteSecret?.data as SecretV3RawSanitized)?.key,
|
||||||
environment,
|
environment,
|
||||||
secretPath,
|
secretPath,
|
||||||
isProtectedBranch
|
isProtectedBranch,
|
||||||
|
isBatchMode,
|
||||||
|
workspaceId,
|
||||||
|
addPendingChange
|
||||||
]);
|
]);
|
||||||
|
|
||||||
// for optimization on minimise re-rendering of secret items
|
// for optimization on minimise re-rendering of secret items
|
||||||
@@ -401,6 +559,8 @@ export const SecretListView = ({
|
|||||||
value: secret.valueOverride ?? secret.value
|
value: secret.valueOverride ?? secret.value
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
isPending={secret.isPending}
|
||||||
|
pendingAction={secret.pendingAction}
|
||||||
/>
|
/>
|
||||||
))}
|
))}
|
||||||
<DeleteActionModal
|
<DeleteActionModal
|
||||||
|
|||||||
Reference in New Issue
Block a user