From 93fe9929b7dc32f0a953bd50f639657f810294de Mon Sep 17 00:00:00 2001
From: x032205 <x032205@gmail.com>
Date: Mon, 19 May 2025 15:22:24 -0400
Subject: [PATCH 1/2] fix secret rollback not tainting form

---
 .../SecretListView/SecretDetailSidebar.tsx    | 43 +++++++++++++------
 1 file changed, 31 insertions(+), 12 deletions(-)

diff --git a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
index 8eb55b81e..ff98653f7 100644
--- a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
+++ b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
@@ -94,8 +94,9 @@ export const SecretDetailSidebar = ({
   secretPath,
   handleSecretShare
 }: Props) => {
+  if (!secret) return <></>;
+
   const {
-    register,
     control,
     watch,
     handleSubmit,
@@ -103,10 +104,15 @@ export const SecretDetailSidebar = ({
     reset,
     formState: { isDirty, isSubmitting }
   } = useForm<TFormSchema>({
-    resolver: zodResolver(formSchema),
-    values: secret
+    resolver: zodResolver(formSchema)
   });
 
+  useEffect(() => {
+    if (secret) {
+      reset(secret);
+    }
+  }, [secret, reset]);
+
   const { handlePopUpToggle, popUp, handlePopUpOpen } = usePopUp([
     "secretAccessUpgradePlan"
   ] as const);
@@ -713,14 +719,25 @@ export const SecretDetailSidebar = ({
                   </FormControl>
                 </div>
               </div>
-              <FormControl label="Comments & Notes">
-                <TextArea
-                  className="border border-mineshaft-600 bg-bunker-800 text-sm"
-                  {...register("comment")}
-                  readOnly={isReadOnly}
-                  rows={5}
-                />
-              </FormControl>
+              <Controller
+                control={control}
+                name="comment"
+                render={({ field, fieldState: { error } }) => (
+                  <FormControl
+                    label="Comments & Notes"
+                    isError={Boolean(error?.message)}
+                    errorText={error?.message}
+                    className="mb-0"
+                  >
+                    <TextArea
+                      className="border border-mineshaft-600 bg-bunker-800 text-sm"
+                      readOnly={isReadOnly}
+                      rows={5}
+                      {...field}
+                    />
+                  </FormControl>
+                )}
+              />
               <FormControl>
                 {secretReminderRepeatDays && secretReminderRepeatDays > 0 ? (
                   <div className="flex items-center justify-between px-2">
@@ -921,7 +938,9 @@ export const SecretDetailSidebar = ({
                                 variant="outline_bg"
                                 size="sm"
                                 className="h-8 w-8 rounded-md"
-                                onClick={() => setValue("value", secretValue)}
+                                onClick={() =>
+                                  setValue("value", secretValue, { shouldDirty: true })
+                                }
                               >
                                 <FontAwesomeIcon icon={faArrowRotateRight} />
                               </IconButton>

From 979e9efbcbdd6c4b4f41d23a3812cb6bd02190b3 Mon Sep 17 00:00:00 2001
From: x032205 <x032205@gmail.com>
Date: Mon, 19 May 2025 15:52:50 -0400
Subject: [PATCH 2/2] fix lint issue

---
 .../SecretListView/SecretDetailSidebar.tsx           | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
index ff98653f7..d417821e4 100644
--- a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
+++ b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
@@ -94,8 +94,6 @@ export const SecretDetailSidebar = ({
   secretPath,
   handleSecretShare
 }: Props) => {
-  if (!secret) return <></>;
-
   const {
     control,
     watch,
@@ -104,15 +102,11 @@ export const SecretDetailSidebar = ({
     reset,
     formState: { isDirty, isSubmitting }
   } = useForm<TFormSchema>({
-    resolver: zodResolver(formSchema)
+    resolver: zodResolver(formSchema),
+    values: secret,
+    disabled: !secret
   });
 
-  useEffect(() => {
-    if (secret) {
-      reset(secret);
-    }
-  }, [secret, reset]);
-
   const { handlePopUpToggle, popUp, handlePopUpOpen } = usePopUp([
     "secretAccessUpgradePlan"
   ] as const);