Address PR comments

backend/src/services/pki-subscriber/pki-subscriber-service.ts

@@ -13,7 +13,6 @@ import {
 } from "@app/ee/services/permission/project-permission";
 import { getConfig } from "@app/lib/config/env";
 import { BadRequestError, NotFoundError } from "@app/lib/errors";
-import { logger } from "@app/lib/logger";
 import { ms } from "@app/lib/ms";
 import { TCertificateBodyDALFactory } from "@app/services/certificate/certificate-body-dal";
 import { TCertificateDALFactory } from "@app/services/certificate/certificate-dal";
@@ -39,6 +38,7 @@ import { TCertificateAuthoritySecretDALFactory } from "@app/services/certificate
 import { TKmsServiceFactory } from "@app/services/kms/kms-service";
 import { TPkiSubscriberDALFactory } from "@app/services/pki-subscriber/pki-subscriber-dal";
 import { TPkiSyncDALFactory } from "@app/services/pki-sync/pki-sync-dal";
+import { triggerAutoSyncForSubscriber } from "@app/services/pki-sync/pki-sync-fns";
 import { TPkiSyncQueueFactory } from "@app/services/pki-sync/pki-sync-queue";
 import { TProjectDALFactory } from "@app/services/project/project-dal";
 import { getProjectKmsCertificateKeyId } from "@app/services/project/project-fns";
@@ -106,28 +106,6 @@ export const pkiSubscriberServiceFactory = ({
   pkiSyncDAL,
   pkiSyncQueue
 }: TPkiSubscriberServiceFactoryDep) => {
-  /**
-   * Trigger auto sync for PKI syncs connected to a PKI subscriber when certificates are issued
-   */
-  const triggerAutoSyncForSubscriber = async (subscriberId: string) => {
-    try {
-      // Find all PKI syncs that are connected to this subscriber and have auto sync enabled
-      const pkiSyncs = await pkiSyncDAL.find({
-        subscriberId,
-        isAutoSyncEnabled: true
-      });
-
-      // Queue sync jobs for each auto sync enabled PKI sync
-      for (const pkiSync of pkiSyncs) {
-        await pkiSyncQueue.queuePkiSyncSyncCertificatesById({ syncId: pkiSync.id });
-      }
-    } catch (error) {
-      // Don't throw error to avoid breaking the main certificate operation
-      // Just log the auto sync failure
-      logger.error(error, `Failed to trigger auto sync for subscriber ${subscriberId}:`);
-    }
-  };
-
   const createSubscriber = async ({
     name,
     commonName,
@@ -446,7 +424,7 @@ export const pkiSubscriberServiceFactory = ({
       const result = await internalCaFns.issueCertificate(subscriber, ca);
 
       // Trigger auto sync for PKI syncs connected to this subscriber after certificate issuance
-      await triggerAutoSyncForSubscriber(subscriber.id);
+      await triggerAutoSyncForSubscriber(subscriber.id, { pkiSyncDAL, pkiSyncQueue });
 
       return result;
     }
@@ -707,7 +685,7 @@ export const pkiSubscriberServiceFactory = ({
     });
 
     // Trigger auto sync for PKI syncs connected to this subscriber after certificate signing
-    await triggerAutoSyncForSubscriber(subscriber.id);
+    await triggerAutoSyncForSubscriber(subscriber.id, { pkiSyncDAL, pkiSyncQueue });
 
     return {
       certificate: leafCert.toString("pem"),