awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 16:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update dynamic-secret-lease-queue.ts

Browse Source
This commit is contained in:
Daniel Hougaard
2025-11-25 15:47:09 -08:00
parent d85922c074
commit 28699023f5
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/dynamic-secret-lease/dynamic-secret-lease-queue.ts
+9 -3
View File
@@ -42,6 +42,8 @@ export type TDynamicSecretLeaseQueueServiceFactory = {
init: () => Promise<void>; init: () => Promise<void>;
}; };
const MAX_REVOCATION_RETRY_COUNT = 10;
export const dynamicSecretLeaseQueueServiceFactory = ({ export const dynamicSecretLeaseQueueServiceFactory = ({
queueService, queueService,
dynamicSecretDAL, dynamicSecretDAL,
@@ -96,7 +98,7 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
{ {
singletonKey: `${leaseId}-retry`, // avoid conflicts with scheduled revocation singletonKey: `${leaseId}-retry`, // avoid conflicts with scheduled revocation
retryDelay: retryDelaySeconds, retryDelay: retryDelaySeconds,
retryLimit: 10, // we dont want it to ever hit the limit, we want the expireInHours to take effect. retryLimit: MAX_REVOCATION_RETRY_COUNT, // we dont want it to ever hit the limit, we want the expireInHours to take effect.
expireInHours: 23 // if we set it to 24 hours, pgboss will complain that the expireIn is too high expireInHours: 23 // if we set it to 24 hours, pgboss will complain that the expireIn is too high
} }
); );
@@ -111,7 +113,8 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
}, },
{ {
jobId: `dynamic-secret-lease-revocation-failed-email-${dynamicSecretId}`, jobId: `dynamic-secret-lease-revocation-failed-email-${dynamicSecretId}`,
delay: 1000 * 60, // 1 minute delay: 1000 * 60 * 10, // 10 minute
attempts: 3,
backoff: { backoff: {
type: "exponential", type: "exponential",
delay: 1000 * 60 // 1 minute delay: 1000 * 60 // 1 minute
@@ -234,8 +237,10 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
await queueService.stopJobByIdPg(QueueName.DynamicSecretRevocation, jobId); await queueService.stopJobByIdPg(QueueName.DynamicSecretRevocation, jobId);
await queueService.stopRepeatableJobByJobId(QueueName.DynamicSecretRevocation, jobId); await queueService.stopRepeatableJobByJobId(QueueName.DynamicSecretRevocation, jobId);
await queueFailedRevocation(leaseId, dynamicSecretId); await queueFailedRevocation(leaseId, dynamicSecretId);
// if its the last attempt, and the error isn't a DisableRotationErrors error, send an email to the project admins (debounced)
} else if (isRetry && !(error instanceof DisableRotationErrors)) { } else if (isRetry && !(error instanceof DisableRotationErrors)) {
if (retryCount && retryCount === 10) { if (retryCount && retryCount === MAX_REVOCATION_RETRY_COUNT) {
await $queueDynamicSecretLeaseRevocationFailedEmail(leaseId, dynamicSecretId); await $queueDynamicSecretLeaseRevocationFailedEmail(leaseId, dynamicSecretId);
} }
} }
@@ -252,6 +257,7 @@ export const dynamicSecretLeaseQueueServiceFactory = ({
} }
}; };
// send alert email once all revocation attempts have failed
const $dynamicSecretLeaseRevocationFailedEmailJob = async (jobId: string, data: { leaseId: string }) => { const $dynamicSecretLeaseRevocationFailedEmailJob = async (jobId: string, data: { leaseId: string }) => {
try { try {
const appCfg = getConfig(); const appCfg = getConfig();