mirror of
https://github.com/awatertrevi/infisical.git
synced 2026-10-14 23:52:09 +00:00
Address PR comments for Azure Client Secret Rotation
This commit is contained in:
+2
-2
@@ -38,8 +38,8 @@ export const AzureClientSecretRotationParametersFields = () => {
|
||||
content={
|
||||
<>
|
||||
Ensure that your connection has the{" "}
|
||||
<span className="font-semibold">read_clients</span> permission and the application
|
||||
exists in the connection's audience.
|
||||
<span className="font-semibold">Application.ReadWrite.All</span> permission and
|
||||
the application exists in Azure.
|
||||
</>
|
||||
}
|
||||
>
|
||||
|
||||
@@ -23,7 +23,7 @@ export const SECRET_ROTATION_MAP: Record<
|
||||
[SecretRotation.AzureClientSecret]: {
|
||||
name: "Azure Client Secret",
|
||||
image: "Microsoft Azure.png",
|
||||
size: 35
|
||||
size: 65
|
||||
},
|
||||
[SecretRotation.LdapPassword]: {
|
||||
name: "LDAP Password",
|
||||
|
||||
@@ -11,6 +11,6 @@ export type TAzureClientSecretsConnection = TRootAppConnection & {
|
||||
method: AzureClientSecretsConnectionMethod.OAuth;
|
||||
credentials: {
|
||||
code: string;
|
||||
tenantId?: string;
|
||||
tenantId: string;
|
||||
};
|
||||
};
|
||||
|
||||
+2
-3
@@ -27,7 +27,7 @@ type Props = {
|
||||
const formSchema = genericAppConnectionFieldsSchema.extend({
|
||||
app: z.literal(AppConnection.AzureClientSecrets),
|
||||
method: z.nativeEnum(AzureClientSecretsConnectionMethod),
|
||||
tenantId: z.string().trim().optional()
|
||||
tenantId: z.string().trim()
|
||||
});
|
||||
|
||||
type FormData = z.infer<typeof formSchema>;
|
||||
@@ -97,10 +97,9 @@ export const AzureClientSecretsConnectionForm = ({ appConnection }: Props) => {
|
||||
control={control}
|
||||
render={({ field, fieldState: { error } }) => (
|
||||
<FormControl
|
||||
tooltipText="The active Directory (Entra ID) Tenant ID."
|
||||
tooltipText="The Active Directory (Entra ID) Tenant ID."
|
||||
isError={Boolean(error?.message)}
|
||||
label="Tenant ID"
|
||||
isOptional
|
||||
errorText={error?.message}
|
||||
>
|
||||
<Input {...field} placeholder="e4f34ea5-ad23-4291-8585-66d20d603cc8" />
|
||||
|
||||
Reference in New Issue
Block a user