From 2a8bd74e8800337a1b0181847a4d87bb8858a876 Mon Sep 17 00:00:00 2001
From: Daniel Hougaard <daniel@infisical.com>
Date: Thu, 20 Feb 2025 04:52:40 +0400
Subject: [PATCH] Update
 20250218020306_backfill-secret-permissions-with-readvalue.ts

---
 ...0218020306_backfill-secret-permissions-with-readvalue.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/backend/src/db/migrations/20250218020306_backfill-secret-permissions-with-readvalue.ts b/backend/src/db/migrations/20250218020306_backfill-secret-permissions-with-readvalue.ts
index 950f9ad37..216cf7ede 100644
--- a/backend/src/db/migrations/20250218020306_backfill-secret-permissions-with-readvalue.ts
+++ b/backend/src/db/migrations/20250218020306_backfill-secret-permissions-with-readvalue.ts
@@ -62,8 +62,10 @@ const $updatePermissionsDown = (permissions: unknown) => {
     const { subject, action } = parsedPermission;
 
     if (subject === ProjectPermissionSub.Secrets) {
-      if (action.includes(SecretActions.ReadValue)) {
-        action.splice(action.indexOf(SecretActions.ReadValue));
+      const readValueIndex = action.indexOf(SecretActions.ReadValue);
+
+      if (action.includes(SecretActions.ReadValue) && readValueIndex !== -1) {
+        action.splice(readValueIndex, 1);
         parsedPermissions[i] = { ...parsedPermission, action };
 
         shouldUpdate = true;