From f7d35e61f78b56c9b23f9d9664385cf90730ec37 Mon Sep 17 00:00:00 2001 From: x Date: Mon, 21 Apr 2025 19:40:20 -0400 Subject: [PATCH] removed low entropy password regexes that threw false positives --- .../utilities/checks/password/checkPassword.ts | 2 +- .../utilities/checks/password/passwordRegexes.ts | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/frontend/src/components/utilities/checks/password/checkPassword.ts b/frontend/src/components/utilities/checks/password/checkPassword.ts index 6e8acaaba..e641421c6 100644 --- a/frontend/src/components/utilities/checks/password/checkPassword.ts +++ b/frontend/src/components/utilities/checks/password/checkPassword.ts @@ -31,7 +31,7 @@ interface CheckPasswordParams { * - Contains at least 1 number (0-9) or special character (emojis included) * - Does not contain 3 repeat, consecutive characters * - Does not contain any escape characters/sequences - * - Does not contain PII and/or low entropy data (eg. email address, URL, phone number, DoB, SSN, driver's license, passport) + * - Does not contain PII and/or low entropy data (eg. email address, URL, SSN) * - Is not in a database of breached passwords * * The function returns whether or not the password [password] diff --git a/frontend/src/components/utilities/checks/password/passwordRegexes.ts b/frontend/src/components/utilities/checks/password/passwordRegexes.ts index 7a70aa8f8..1e2367b49 100644 --- a/frontend/src/components/utilities/checks/password/passwordRegexes.ts +++ b/frontend/src/components/utilities/checks/password/passwordRegexes.ts @@ -20,18 +20,6 @@ export const lowEntropyRegexes = [ // URL (incl. subdomains, paths, top-level domains & query params) /^(?:(?:https?|ftp):\/\/)?(?:\w+\.)?[a-zA-Z0-9.-]+\.(?:com|org|net|edu)(?:\/\S*)?(?:\?\S*)?$/, - // Date in various formats - /(\b\d{1,4}[-/.]?\d{1,2}[-/.]?\d{1,4}\b)|(\b\d{1,4}[-/.]?\w{3}[-/.]?\d{1,4}\b)/, - - // Phone numbers (generalized) - /(?:\+(?:[1-9]\d{0,2})\s?)?(?:\(\d{1,4}\)\s?)?(?:\d[-.\s]?){5,}\d/, - - // Passport numbers (generalized) - /\b(?:[A-Z0-9]{6,9}|[A-Z0-9]{8,9}|[A-Z0-9]{9}|[A-Z0-9]{10,11})\b/, - - // Driver's license numbers (generalized) - /\b(?:[A-Z0-9]{7,10}|[A-Z0-9]{10,11}|[A-Z0-9]{7,10})\b/, - // US social security number /\b\d{3}[-\s]?\d{2}[-\s]?\d{4}\b/ ];