misc: removed hacky approach

This commit is contained in:
Sheen Capadngan
2024-09-17 18:52:30 +08:00
parent dbb8617180
commit 335f3f7d37
2 changed files with 10 additions and 112 deletions
@@ -28,10 +28,7 @@ import {
} from "./group-project-types";
type TGroupProjectServiceFactoryDep = {
groupProjectDAL: Pick<
TGroupProjectDALFactory,
"findOne" | "transaction" | "create" | "delete" | "findByProjectId" | "findByGroupSlugAndProject"
>;
groupProjectDAL: Pick<TGroupProjectDALFactory, "findOne" | "transaction" | "create" | "delete" | "findByProjectId">;
groupProjectMembershipRoleDAL: Pick<
TGroupProjectMembershipRoleDALFactory,
"create" | "transaction" | "insertMany" | "delete"
@@ -401,9 +398,8 @@ export const groupProjectServiceFactory = ({
);
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.Groups);
const groupMembership = await groupProjectDAL.findByGroupSlugAndProject({
groupSlug,
projectId: project.id
const [groupMembership] = await groupProjectDAL.findByProjectId(project.id, {
groupSlug
});
return groupMembership;