From 3639a7fc18c5ad4e59bcc5a07c599e58433b697a Mon Sep 17 00:00:00 2001
From: Sheen Capadngan <sheensantoscapadngan@gmail.com>
Date: Mon, 27 May 2024 11:01:22 +0800
Subject: [PATCH] misc: migrated to native DAL method

---
 backend/src/services/auth/auth-login-service.ts |  2 +-
 backend/src/services/user/user-dal.ts           | 16 +---------------
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/backend/src/services/auth/auth-login-service.ts b/backend/src/services/auth/auth-login-service.ts
index a97e94145..cbf43b245 100644
--- a/backend/src/services/auth/auth-login-service.ts
+++ b/backend/src/services/auth/auth-login-service.ts
@@ -314,7 +314,7 @@ export const authLoginServiceFactory = ({
     try {
       const updatedUser = await userDAL.transaction(async (tx) => {
         const PROGRESSIVE_DELAY_INTERVAL = 3;
-        const user = await userDAL.incrementFailedMfaAttempt(userId, tx);
+        const user = await userDAL.updateById(userId, { $incr: { consecutiveFailedMfaAttempts: 1 } }, tx);
 
         if (!user) {
           throw new Error("User not found");
diff --git a/backend/src/services/user/user-dal.ts b/backend/src/services/user/user-dal.ts
index 7c73fc4f4..f2da0df0e 100644
--- a/backend/src/services/user/user-dal.ts
+++ b/backend/src/services/user/user-dal.ts
@@ -143,19 +143,6 @@ export const userDALFactory = (db: TDbClient) => {
     }
   };
 
-  const incrementFailedMfaAttempt = async (userId: string, tx?: Knex) => {
-    try {
-      const [user] = await (tx || db)(TableName.Users)
-        .where("id", userId)
-        .increment("consecutiveFailedMfaAttempts", 1)
-        .returning("*");
-
-      return user;
-    } catch (error) {
-      throw new DatabaseError({ error, name: "Increment Failed MFA Attempt" });
-    }
-  };
-
   return {
     ...userOrm,
     findUserByUsername,
@@ -168,7 +155,6 @@ export const userDALFactory = (db: TDbClient) => {
     upsertUserEncryptionKey,
     createUserEncryption,
     findOneUserAction,
-    createUserAction,
-    incrementFailedMfaAttempt
+    createUserAction
   };
 };