From 36c93f47d92581e86c362f532184a8afb80af28d Mon Sep 17 00:00:00 2001 From: x032205 Date: Thu, 12 Jun 2025 15:17:22 -0400 Subject: [PATCH] Review fixes --- .../oracledb-credentials-rotation-constants.ts | 4 ++-- .../platform/secret-rotation/oracledb-credentials.mdx | 10 +++++----- .../shared/SqlCredentialsRotationParametersFields.tsx | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/backend/src/ee/services/secret-rotation-v2/oracledb-credentials/oracledb-credentials-rotation-constants.ts b/backend/src/ee/services/secret-rotation-v2/oracledb-credentials/oracledb-credentials-rotation-constants.ts index 74957c693..dd685041c 100644 --- a/backend/src/ee/services/secret-rotation-v2/oracledb-credentials/oracledb-credentials-rotation-constants.ts +++ b/backend/src/ee/services/secret-rotation-v2/oracledb-credentials/oracledb-credentials-rotation-constants.ts @@ -8,10 +8,10 @@ export const ORACLEDB_CREDENTIALS_ROTATION_LIST_OPTION: TSecretRotationV2ListIte connection: AppConnection.OracleDB, template: { createUserStatement: `-- create user -CREATE USER infisical_user IDENTIFIED BY "temporary_password"; +CREATE USER INFISICAL_USER IDENTIFIED BY "temporary_password"; -- grant all privileges -GRANT ALL PRIVILEGES TO infisical_user;`, +GRANT ALL PRIVILEGES TO INFISICAL_USER;`, secretsMapping: { username: "ORACLEDB_USERNAME", password: "ORACLEDB_PASSWORD" diff --git a/docs/documentation/platform/secret-rotation/oracledb-credentials.mdx b/docs/documentation/platform/secret-rotation/oracledb-credentials.mdx index b9ba42841..fb0887d33 100644 --- a/docs/documentation/platform/secret-rotation/oracledb-credentials.mdx +++ b/docs/documentation/platform/secret-rotation/oracledb-credentials.mdx @@ -15,12 +15,12 @@ description: "Learn how to automatically rotate Oracle Database credentials." An example creation statement might look like: ```SQL -- create user roles - CREATE USER infisical_user_1 IDENTIFIED BY "temporary_password"; - CREATE USER infisical_user_2 IDENTIFIED BY "temporary_password"; + CREATE USER INFISICAL_USER_1 IDENTIFIED BY "temporary_password"; + CREATE USER INFISICAL_USER_2 IDENTIFIED BY "temporary_password"; -- grant necessary privileges - GRANT ALL PRIVILEGES TO infisical_user_1; - GRANT ALL PRIVILEGES TO infisical_user_2; + GRANT ALL PRIVILEGES TO INFISICAL_USER_1; + GRANT ALL PRIVILEGES TO INFISICAL_USER_2; ``` @@ -57,7 +57,7 @@ description: "Learn how to automatically rotate Oracle Database credentials." - **Database Username 2** - the username of the second user that will be used for rotation. - Ensure that the usernames are UPPERCASE if they were created without "quotes". + If your Oracle usernames were created without "quotes", Oracle sees them as UPPERCASE. Please use UPPERCASE for those names in the fields above. 5. Specify the secret names that the active credentials should be mapped to. Then click **Next**. diff --git a/frontend/src/components/secret-rotations-v2/forms/SecretRotationV2ParametersFields/shared/SqlCredentialsRotationParametersFields.tsx b/frontend/src/components/secret-rotations-v2/forms/SecretRotationV2ParametersFields/shared/SqlCredentialsRotationParametersFields.tsx index a36162157..0d88aaaaa 100644 --- a/frontend/src/components/secret-rotations-v2/forms/SecretRotationV2ParametersFields/shared/SqlCredentialsRotationParametersFields.tsx +++ b/frontend/src/components/secret-rotations-v2/forms/SecretRotationV2ParametersFields/shared/SqlCredentialsRotationParametersFields.tsx @@ -52,8 +52,8 @@ export const SqlCredentialsRotationParametersFields = () => { onChange={onChange} placeholder={ rotationOption.connection === AppConnection.OracleDB - ? "INFISICAL_USER_1" - : "infisical_user_1" + ? "INFISICAL_USER_2" + : "infisical_user_2" } />