From 37018581ef6366785991fc035e52666646fa83b2 Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Thu, 18 Sep 2025 17:29:57 -0700
Subject: [PATCH] improvements: final feedback

---
 .../components/SecretListView/SecretDetailSidebar.tsx       | 2 ++
 .../components/SecretListView/SecretVersionItem.tsx         | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
index c0ba7184e..67404f878 100644
--- a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
+++ b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
@@ -403,6 +403,7 @@ export const SecretDetailSidebar = ({
                             isLoadingSecretValue ||
                             isErrorFetchingSecretValue
                           }
+                          canEditButNotView={secret.secretValueHidden && canEditSecretValue}
                           environment={environment}
                           secretPath={secretPath}
                           key="secret-value"
@@ -703,6 +704,7 @@ export const SecretDetailSidebar = ({
               <div className="thin-scrollbar flex flex-1 flex-col space-y-2 overflow-y-auto overflow-x-hidden rounded-md border border-mineshaft-600 bg-mineshaft-900 p-4 dark:[color-scheme:dark]">
                 {secretVersion?.map((version) => (
                   <SecretVersionItem
+                    canReadValue={!cannotReadSecretValue}
                     secretVersion={version}
                     secret={secret}
                     currentVersion={secretVersion.length}
diff --git a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretVersionItem.tsx b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretVersionItem.tsx
index 1e24c83aa..808e549ee 100644
--- a/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretVersionItem.tsx
+++ b/frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretVersionItem.tsx
@@ -24,13 +24,15 @@ interface SecretVersionItemProps {
   secret: SecretV3RawSanitized;
   currentVersion: number;
   onRevert: (secretValue: string) => void;
+  canReadValue: boolean;
 }
 
 export const SecretVersionItem = ({
   secretVersion: { createdAt, version, actor, secretValueHidden },
   secret,
   currentVersion,
-  onRevert
+  onRevert,
+  canReadValue
 }: SecretVersionItemProps) => {
   const { currentProject } = useProject();
 
@@ -244,7 +246,7 @@ export const SecretVersionItem = ({
           </div>
         </div>
       </div>
-      {!secret?.isRotatedSecret && (
+      {!secret?.isRotatedSecret && canReadValue && (
         <div
           className={`flex items-center justify-center ${version === currentVersion ? "hidden" : ""}`}
         >