Merge pull request #857 from Infisical/signup-secrets-fix

added a check for signup events

backend/src/controllers/v3/secretsController.ts

@@ -362,7 +362,8 @@ export const createSecret = async (req: Request, res: Response) => {
     secretCommentCiphertext,
     secretCommentIV,
     secretCommentTag,
-    secretPath = "/"
+    secretPath = "/",
+    metadata
   } = req.body;
 
   const secret = await SecretService.createSecret({
@@ -380,7 +381,8 @@ export const createSecret = async (req: Request, res: Response) => {
     secretPath,
     secretCommentCiphertext,
     secretCommentIV,
-    secretCommentTag
+    secretCommentTag,
+    metadata
   });
 
   await EventService.handleEvent({

backend/src/helpers/secrets.ts

@@ -326,7 +326,8 @@ export const createSecretHelper = async ({
   secretCommentCiphertext,
   secretCommentIV,
   secretCommentTag,
-  secretPath = "/"
+  secretPath = "/",
+  metadata
 }: CreateSecretParams) => {
   const secretBlindIndex = await generateSecretBlindIndexHelper({
     secretName,
@@ -462,8 +463,8 @@ export const createSecretHelper = async ({
   });
 
   const postHogClient = await TelemetryService.getPostHogClient();
-
+  
-  if (postHogClient) {
+  if (postHogClient && (metadata?.source !== "signup")) {
     postHogClient.capture({
       event: "secrets added",
       distinctId: await TelemetryService.getDistinctId({

backend/src/interfaces/services/SecretService/index.ts

@@ -17,6 +17,9 @@ export interface CreateSecretParams {
   secretCommentIV?: string;
   secretCommentTag?: string;
   secretPath: string;
+  metadata?: {
+    source?: string;
+  }
 }
 
 export interface GetSecretsParams {

backend/src/routes/v3/secrets.ts

@@ -180,6 +180,8 @@ router.post(
   body("secretCommentIV").optional().isString().trim(),
   body("secretCommentTag").optional().isString().trim(),
   body("secretPath").default("/").isString().trim(),
+  body("metadata").optional().isObject().withMessage("Metadata should be an object"),
+  body("metadata.source").optional().isString().withMessage("Source should be a string"),
   validateRequest,
   requireAuth({
     acceptedAuthModes: [

frontend/src/helpers/project.ts

@@ -140,7 +140,10 @@ const initProjectHelper = async ({
       secretCommentCiphertext: secret.secretCommentCiphertext,
       secretCommentIV: secret.secretCommentIV,
       secretCommentTag: secret.secretCommentTag,
-      secretPath: "/"
+      secretPath: "/",
+      metadata: {
+        source: "signup"
+      }
     });
   });
   

frontend/src/hooks/api/secrets/types.ts

@@ -165,4 +165,7 @@ export type CreateSecretDTO = {
   secretCommentIV: string;
   secretCommentTag: string;
   secretPath: string;
+  metadata?: {
+    source?: string;
+  }
 }