From 2b289ddf77f45332790141f2774ab6f81a67b674 Mon Sep 17 00:00:00 2001
From: akhilmhdh <akhilmhdh@gmail.com>
Date: Sun, 12 Feb 2023 17:31:22 +0530
Subject: [PATCH] feat(ui): add new button style, improved select ui and linted
 app layout

---
 .../components/v2/Button/Button.stories.tsx   |   7 ++
 frontend/src/components/v2/Button/Button.tsx  |  14 ++-
 frontend/src/components/v2/Select/Select.tsx  |   3 +-
 frontend/src/layouts/AppLayout/AppLayout.tsx  | 110 ++++++++++--------
 4 files changed, 85 insertions(+), 49 deletions(-)

diff --git a/frontend/src/components/v2/Button/Button.stories.tsx b/frontend/src/components/v2/Button/Button.stories.tsx
index 51e58d0da..c823b5531 100644
--- a/frontend/src/components/v2/Button/Button.stories.tsx
+++ b/frontend/src/components/v2/Button/Button.stories.tsx
@@ -38,6 +38,13 @@ export const Secondary: Story = {
   }
 };
 
+export const Star: Story = {
+  args: {
+    children: 'Hello Infisical',
+    variant: 'star'
+  }
+};
+
 export const Danger: Story = {
   args: {
     children: 'Hello Infisical',
diff --git a/frontend/src/components/v2/Button/Button.tsx b/frontend/src/components/v2/Button/Button.tsx
index af59f3d51..8c6bf91b2 100644
--- a/frontend/src/components/v2/Button/Button.tsx
+++ b/frontend/src/components/v2/Button/Button.tsx
@@ -31,7 +31,9 @@ const buttonVariants = cva(
       variant: {
         solid: '',
         outline: ['bg-transparent', 'border-2', 'border-solid'],
-        plain: ''
+        plain: '',
+        // a constant color not in use on hover or click goes colorSchema color
+        star: 'text-bunker-200 bg-mineshaft-500'
       },
       isDisabled: {
         true: 'bg-mineshaft opacity-40 cursor-not-allowed',
@@ -53,6 +55,16 @@ const buttonVariants = cva(
       }
     },
     compoundVariants: [
+      {
+        colorSchema: 'primary',
+        variant: 'star',
+        className: 'hover:bg-primary hover:text-black'
+      },
+      {
+        colorSchema: 'danger',
+        variant: 'star',
+        className: 'hover:bg-red hover:text-white'
+      },
       {
         colorSchema: 'primary',
         variant: 'outline',
diff --git a/frontend/src/components/v2/Select/Select.tsx b/frontend/src/components/v2/Select/Select.tsx
index 5a1aa7a35..19885437d 100644
--- a/frontend/src/components/v2/Select/Select.tsx
+++ b/frontend/src/components/v2/Select/Select.tsx
@@ -42,7 +42,8 @@ export const Select = forwardRef<HTMLButtonElement, SelectProps>(
         <SelectPrimitive.Portal>
           <SelectPrimitive.Content
             className={twMerge(
-              'relative left-4 top-1 overflow-hidden rounded-md bg-bunker-800 font-inter text-bunker-100 shadow-md z-[100]',
+              'relative top-1 overflow-hidden rounded-md bg-bunker-800 font-inter text-bunker-100 shadow-md z-[100]',
+
               dropdownContainerClassName
             )}
             position={position}
diff --git a/frontend/src/layouts/AppLayout/AppLayout.tsx b/frontend/src/layouts/AppLayout/AppLayout.tsx
index 1a2dc2cfa..40406613c 100644
--- a/frontend/src/layouts/AppLayout/AppLayout.tsx
+++ b/frontend/src/layouts/AppLayout/AppLayout.tsx
@@ -64,7 +64,7 @@ export const AppLayout = ({ children }: LayoutProps) => {
   // eslint-disable-next-line prefer-const
   let { workspaces, currentWorkspace } = useWorkspace();
   const { currentOrg } = useOrganization();
-  workspaces = workspaces.filter(ws => ws.organization === currentOrg?._id)
+  workspaces = workspaces.filter((ws) => ws.organization === currentOrg?._id);
   const { user } = useUser();
 
   const createWs = useCreateWorkspace();
@@ -218,50 +218,58 @@ export const AppLayout = ({ children }: LayoutProps) => {
           <aside className="w-full border-r border-mineshaft-500 bg-mineshaft-900 md:w-60">
             <nav className="items-between flex h-full flex-col justify-between">
               <div>
-                {currentWorkspace 
-                ? <div className="w-full p-4 mt-3 mb-4">
-                  <p className="text-xs font-semibold ml-1.5 mb-1 uppercase text-gray-400">Project</p>
-                  <Select
-                    defaultValue={currentWorkspace?._id}
-                    value={currentWorkspace?._id}
-                    className="w-full py-2.5 bg-mineshaft-600 font-medium"
-                    onValueChange={(value) => {
-                      router.push(`/dashboard/${value}`);
-                    }}
-                    position="popper"
-                    dropdownContainerClassName="left-0 text-bunker-200 bg-mineshaft-800 border border-mineshaft-600 z-50"
-                  >
-                    {workspaces.map(({ _id, name }) => (
-                      <SelectItem key={`ws-layout-list-${_id}`} value={_id} className={`${currentWorkspace?._id === _id && "bg-mineshaft-600"}`}>
-                        {name}
-                      </SelectItem>
-                    ))}
-                    <hr className="mt-1 mb-1 h-px border-0 bg-gray-700" />
-                    <div className="w-full">
-                      <Button
-                        className="w-full py-2 text-bunker-200 bg-mineshaft-500 hover:bg-primary/90 hover:text-black"
-                        color="mineshaft"
-                        size="sm"
-                        onClick={() => handlePopUpOpen('addNewWs')}
-                        leftIcon={<FontAwesomeIcon icon={faPlus} />}
-                      >
-                        Add Project
-                      </Button>
-                    </div>
-                  </Select>
-                </div>
-                : <div className="w-full p-4 mt-3 mb-4">
-                  <Button
-                    className="w-full py-2 text-bunker-200 bg-mineshaft-500 hover:bg-primary/90 hover:text-black"
-                    color="mineshaft"
-                    size="sm"
-                    onClick={() => handlePopUpOpen('addNewWs')}
-                    leftIcon={<FontAwesomeIcon icon={faPlus} />}
-                  >
-                    Add Project
-                  </Button>
-                </div>}
-                <div className={`${currentWorkspace ? "block" : "hidden"}`}>
+                {currentWorkspace ? (
+                  <div className="w-full p-4 mt-3 mb-4">
+                    <p className="text-xs font-semibold ml-1.5 mb-1 uppercase text-gray-400">
+                      Project
+                    </p>
+                    <Select
+                      defaultValue={currentWorkspace?._id}
+                      value={currentWorkspace?._id}
+                      className="w-full py-2.5 bg-mineshaft-600 font-medium"
+                      onValueChange={(value) => {
+                        router.push(`/dashboard/${value}`);
+                      }}
+                      position="popper"
+                      dropdownContainerClassName="text-bunker-200 bg-mineshaft-800 border border-mineshaft-600 z-50"
+                    >
+                      {workspaces.map(({ _id, name }) => (
+                        <SelectItem
+                          key={`ws-layout-list-${_id}`}
+                          value={_id}
+                          className={`${currentWorkspace?._id === _id && 'bg-mineshaft-600'}`}
+                        >
+                          {name}
+                        </SelectItem>
+                      ))}
+                      <hr className="mt-1 mb-1 h-px border-0 bg-gray-700" />
+                      <div className="w-full">
+                        <Button
+                          className="w-full py-2 text-bunker-200 bg-mineshaft-500 hover:bg-primary/90 hover:text-black"
+                          color="mineshaft"
+                          size="sm"
+                          onClick={() => handlePopUpOpen('addNewWs')}
+                          leftIcon={<FontAwesomeIcon icon={faPlus} />}
+                        >
+                          Add Project
+                        </Button>
+                      </div>
+                    </Select>
+                  </div>
+                ) : (
+                  <div className="w-full p-4 mt-3 mb-4">
+                    <Button
+                      className="w-full py-2 text-bunker-200 bg-mineshaft-500 hover:bg-primary/90 hover:text-black"
+                      color="mineshaft"
+                      size="sm"
+                      onClick={() => handlePopUpOpen('addNewWs')}
+                      leftIcon={<FontAwesomeIcon icon={faPlus} />}
+                    >
+                      Add Project
+                    </Button>
+                  </div>
+                )}
+                <div className={`${currentWorkspace ? 'block' : 'hidden'}`}>
                   <Menu>
                     <Link href={`/dashboard/${currentWorkspace?._id}`} passHref>
                       <a>
@@ -392,7 +400,7 @@ export const AppLayout = ({ children }: LayoutProps) => {
                     </FormControl>
                   )}
                 />
-                <div className='pl-1 mt-4'>
+                <div className="pl-1 mt-4">
                   <Controller
                     control={control}
                     name="addMembers"
@@ -414,11 +422,19 @@ export const AppLayout = ({ children }: LayoutProps) => {
                     isDisabled={isSubmitting}
                     isLoading={isSubmitting}
                     key="layout-create-project-submit"
-                    className=""
+                    className="mr-4"
                     type="submit"
                   >
                     Create Project
                   </Button>
+                  <Button
+                    key="layout-cancel-create-project"
+                    onClick={() => handlePopUpClose('addNewWs')}
+                    variant="plain"
+                    colorSchema="secondary"
+                  >
+                    Cancel
+                  </Button>
                 </div>
               </form>
             </ModalContent>