awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-18 10:48:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: added initial version pruning and result limiting

Browse Source
This commit is contained in:
Sheen Capadngan
2024-05-31 19:12:55 +08:00
parent b801c1e48f
commit 3a1168c7e8
8 changed files with 140 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/secret-snapshot/secret-snapshot-service.ts
+15 -2
View File
@@ -4,6 +4,7 @@ import { TableName, TSecretTagJunctionInsert } from "@app/db/schemas";
import { BadRequestError, InternalServerError } from "@app/lib/errors";
import { groupBy } from "@app/lib/fn";
import { logger } from "@app/lib/logger";
import { TProjectDALFactory } from "@app/services/project/project-dal";
import { TSecretDALFactory } from "@app/services/secret/secret-dal";
import { TSecretVersionDALFactory } from "@app/services/secret/secret-version-dal";
import { TSecretVersionTagDALFactory } from "@app/services/secret/secret-version-tag-dal";
@@ -37,6 +38,7 @@ type TSecretSnapshotServiceFactoryDep = {
folderDAL: Pick<TSecretFolderDALFactory, "findById" | "findBySecretPath" | "delete" | "insertMany" | "find">;
permissionService: Pick<TPermissionServiceFactory, "getProjectPermission">;
licenseService: Pick<TLicenseServiceFactory, "isValidLicense">;
projectDAL: Pick<TProjectDALFactory, "findById">;
};
export type TSecretSnapshotServiceFactory = ReturnType<typeof secretSnapshotServiceFactory>;
@@ -48,6 +50,7 @@ export const secretSnapshotServiceFactory = ({
snapshotSecretDAL,
snapshotFolderDAL,
folderDAL,
projectDAL,
secretDAL,
permissionService,
licenseService,
@@ -81,8 +84,9 @@ export const secretSnapshotServiceFactory = ({
const folder = await folderDAL.findBySecretPath(projectId, environment, path);
if (!folder) throw new BadRequestError({ message: "Folder not found" });
const project = await projectDAL.findById(projectId);
const count = await snapshotDAL.countOfSnapshotsByFolderId(folder.id);
return count;
return Math.min(count, project.pitVersionLimit);
};
const listSnapshots = async ({
@@ -114,7 +118,16 @@ export const secretSnapshotServiceFactory = ({
const folder = await folderDAL.findBySecretPath(projectId, environment, path);
if (!folder) throw new BadRequestError({ message: "Folder not found" });
const snapshots = await snapshotDAL.find({ folderId: folder.id }, { limit, offset, sort: [["createdAt", "desc"]] });
const { pitVersionLimit } = await projectDAL.findById(projectId);
const computedQueryLimit = Math.min(pitVersionLimit - offset, limit);
if (offset > pitVersionLimit || computedQueryLimit <= 0) {
return [];
}
const snapshots = await snapshotDAL.find(
{ folderId: folder.id },
{ limit: computedQueryLimit, offset, sort: [["createdAt", "desc"]] }
);
return snapshots;
};