chore: refactor

This commit is contained in:
Meet
2024-09-23 19:04:57 +05:30
parent fcbc7fcece
commit 3a38e1e413
3 changed files with 5 additions and 5 deletions
@@ -20,7 +20,7 @@ export const registerAccessApprovalPolicyRouter = async (server: FastifyZodProvi
approvers: z approvers: z
.object({ type: z.nativeEnum(ApproverType), id: z.string() }) .object({ type: z.nativeEnum(ApproverType), id: z.string() })
.array() .array()
.min(1), .min(1, { message: "At least one approver should be provided" }),
approvals: z.number().min(1).default(1), approvals: z.number().min(1).default(1),
enforcementLevel: z.nativeEnum(EnforcementLevel).default(EnforcementLevel.Hard) enforcementLevel: z.nativeEnum(EnforcementLevel).default(EnforcementLevel.Hard)
}), }),
@@ -129,7 +129,7 @@ export const registerAccessApprovalPolicyRouter = async (server: FastifyZodProvi
approvers: z approvers: z
.object({ type: z.nativeEnum(ApproverType), id: z.string() }) .object({ type: z.nativeEnum(ApproverType), id: z.string() })
.array() .array()
.min(1), .min(1, { message: "At least one approver should be provided" }),
approvals: z.number().min(1).optional(), approvals: z.number().min(1).optional(),
enforcementLevel: z.nativeEnum(EnforcementLevel).default(EnforcementLevel.Hard) enforcementLevel: z.nativeEnum(EnforcementLevel).default(EnforcementLevel.Hard)
}), }),
@@ -30,7 +30,7 @@ export const registerSecretApprovalPolicyRouter = async (server: FastifyZodProvi
approvers: z approvers: z
.object({ type: z.nativeEnum(ApproverType), id: z.string() }) .object({ type: z.nativeEnum(ApproverType), id: z.string() })
.array() .array()
.min(1), .min(1, { message: "At least one approver should be provided" }),
approvals: z.number().min(1).default(1), approvals: z.number().min(1).default(1),
enforcementLevel: z.nativeEnum(EnforcementLevel).default(EnforcementLevel.Hard) enforcementLevel: z.nativeEnum(EnforcementLevel).default(EnforcementLevel.Hard)
}), }),
@@ -71,7 +71,7 @@ export const registerSecretApprovalPolicyRouter = async (server: FastifyZodProvi
approvers: z approvers: z
.object({ type: z.nativeEnum(ApproverType), id: z.string() }) .object({ type: z.nativeEnum(ApproverType), id: z.string() })
.array() .array()
.min(1), .min(1, { message: "At least one approver should be provided" }),
approvals: z.number().min(1).default(1), approvals: z.number().min(1).default(1),
secretPath: z secretPath: z
.string() .string()
@@ -448,7 +448,7 @@ export const secretApprovalRequestServiceFactory = ({
const hasMinApproval = const hasMinApproval =
secretApprovalRequest.policy.approvals <= secretApprovalRequest.policy.approvals <=
secretApprovalRequest.policy.approvers.filter(({ userId: approverId }) => secretApprovalRequest.policy.approvers.filter(({ userId: approverId }) =>
approverId ? reviewers[approverId.toString()] === ApprovalStatus.APPROVED : null approverId ? reviewers[approverId] === ApprovalStatus.APPROVED : false
).length; ).length;
const isSoftEnforcement = secretApprovalRequest.policy.enforcementLevel === EnforcementLevel.Soft; const isSoftEnforcement = secretApprovalRequest.policy.enforcementLevel === EnforcementLevel.Soft;