Merge pull request #1446 from Infisical/daniel/ghost-users-fixes

(Fix): Project upgrade

backend/src/services/project-membership/project-membership-service.ts

@@ -419,10 +419,6 @@ export const projectMembershipServiceFactory = ({
       });
     }
 
-    if (project.version === ProjectVersion.V1) {
-      throw new BadRequestError({ message: "Please upgrade your project on your dashboard" });
-    }
-
     const projectMembers = await projectMembershipDAL.findMembershipsByEmail(projectId, emails);
 
     if (projectMembers.length !== emails.length) {

backend/src/services/project/project-fns.ts

@@ -33,11 +33,12 @@ export const assignWorkspaceKeysToMembers = ({ members, decryptKey, userPrivateK
 type TCreateProjectKeyDTO = {
   publicKey: string;
   privateKey: string;
+  plainProjectKey?: string;
 };
 
-export const createProjectKey = ({ publicKey, privateKey }: TCreateProjectKeyDTO) => {
+export const createProjectKey = ({ publicKey, privateKey, plainProjectKey }: TCreateProjectKeyDTO) => {
   // 3. Create a random key that we'll use as the project key.
-  const randomBytes = crypto.randomBytes(16).toString("hex");
+  const randomBytes = plainProjectKey || crypto.randomBytes(16).toString("hex");
 
   // 4. Encrypt the project key with the users key pair.
   const { ciphertext: encryptedProjectKey, nonce: encryptedProjectKeyIv } = encryptAsymmetric(

backend/src/services/project/project-queue.ts

@@ -122,6 +122,13 @@ export const projectQueueFactory = ({
         tag: data.encryptedPrivateKey.encryptedKeyTag
       });
 
+      const decryptedPlainProjectKey = decryptAsymmetric({
+        ciphertext: oldProjectKey.encryptedKey,
+        nonce: oldProjectKey.nonce,
+        publicKey: oldProjectKey.sender.publicKey,
+        privateKey: userPrivateKey
+      });
+
       const projectEnvs = await projectEnvDAL.find({
         projectId: project.id
       });
@@ -199,6 +206,7 @@ export const projectQueueFactory = ({
 
         // Create a project key
         const { key: newEncryptedProjectKey, iv: newEncryptedProjectKeyIv } = createProjectKey({
+          plainProjectKey: decryptedPlainProjectKey,
           publicKey: ghostUser.keys.publicKey,
           privateKey: ghostUser.keys.plainPrivateKey
         });

docs/api-reference/endpoints/workspaces/create-workspace.mdx

@@ -1,4 +1,4 @@
 ---
-title: "Create Workspace"
+title: "Create Project"
 openapi: "POST /api/v2/workspace"
 ---

docs/api-reference/endpoints/workspaces/delete-workspace.mdx

@@ -1,5 +1,5 @@
 ---
-title: "Delete Workspace"
+title: "Delete Project"
 openapi: "DELETE /api/v1/workspace/{workspaceId}"
 ---
 

docs/api-reference/endpoints/workspaces/get-workspace.mdx

@@ -1,4 +1,4 @@
 ---
-title: "Get Workspace"
+title: "Get Project"
 openapi: "GET /api/v1/workspace/{workspaceId}"
 ---

docs/api-reference/endpoints/workspaces/update-workspace.mdx

@@ -1,4 +1,4 @@
 ---
-title: "Update Workspace"
+title: "Update Project"
 openapi: "PATCH /api/v1/workspace/{workspaceId}"
 ---

frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx

@@ -29,7 +29,7 @@ import {
   Tooltip,
   Tr
 } from "@app/components/v2";
-// import { UpgradeProjectAlert } from "@app/components/v2/UpgradeProjectAlert";
+import { UpgradeProjectAlert } from "@app/components/v2/UpgradeProjectAlert";
 import { useOrganization, useWorkspace } from "@app/context";
 import {
   useCreateFolder,
@@ -40,8 +40,8 @@ import {
   useGetUserWsKey,
   useUpdateSecretV3
 } from "@app/hooks/api";
+import { ProjectVersion } from "@app/hooks/api/workspace/types";
 
-// import { ProjectVersion } from "@app/hooks/api/workspace/types";
 import { FolderBreadCrumbs } from "./components/FolderBreadCrumbs";
 import { ProjectIndexSecretsSection } from "./components/ProjectIndexSecretsSection";
 import { SecretOverviewFolderRow } from "./components/SecretOverviewFolderRow";
@@ -274,6 +274,7 @@ export const SecretOverviewPage = () => {
       <div className="relative right-5 ml-4">
         <NavHeader pageName={t("dashboard.title")} isProjectRelated />
       </div>
+      <div className="space-y-8">
         <div className="mt-6">
           <p className="text-3xl font-semibold text-bunker-100">Secrets Overview</p>
           <p className="text-md text-bunker-300">
@@ -317,8 +318,11 @@ export const SecretOverviewPage = () => {
           </p>
         </div>
 
+        {currentWorkspace?.version === ProjectVersion.V1 && (
+          <UpgradeProjectAlert project={currentWorkspace} />
+        )}
 
-      <div className="mt-8 flex items-center justify-between">
+        <div className="flex items-center justify-between">
           <FolderBreadCrumbs secretPath={secretPath} onResetSearch={handleResetSearch} />
           <div className="w-80">
             <Input
@@ -330,6 +334,7 @@ export const SecretOverviewPage = () => {
             />
           </div>
         </div>
+      </div>
       <div className="thin-scrollbar mt-4" ref={parentTableRef}>
         <TableContainer className="max-h-[calc(100vh-250px)] overflow-y-auto">
           <Table>