From 41e65775ab877cfdb7cab7c7e9709ec0c11f2d06 Mon Sep 17 00:00:00 2001 From: Sheen Capadngan Date: Thu, 19 Jun 2025 03:24:32 +0800 Subject: [PATCH] misc: addressed comments --- backend/src/lib/api-docs/constants.ts | 2 +- .../secret-sync/render/render-sync-fns.ts | 8 +++ docs/mint.json | 60 +++++++++---------- 3 files changed, 39 insertions(+), 31 deletions(-) diff --git a/backend/src/lib/api-docs/constants.ts b/backend/src/lib/api-docs/constants.ts index 100fe50eb..c18c87c39 100644 --- a/backend/src/lib/api-docs/constants.ts +++ b/backend/src/lib/api-docs/constants.ts @@ -2393,7 +2393,7 @@ export const SecretSyncs = { RENDER: { serviceId: "The ID of the Render service to sync secrets to.", scope: "The Render scope that secrets should be synced to.", - type: "The type of Render resource to sync secrets to." + type: "The Render resource type to sync secrets to." }, FLYIO: { appId: "The ID of the Fly.io app to sync secrets to." diff --git a/backend/src/services/secret-sync/render/render-sync-fns.ts b/backend/src/services/secret-sync/render/render-sync-fns.ts index adfc442d8..8a9039e2e 100644 --- a/backend/src/services/secret-sync/render/render-sync-fns.ts +++ b/backend/src/services/secret-sync/render/render-sync-fns.ts @@ -90,11 +90,17 @@ const deleteEnvironmentSecret = async (secretSync: TRenderSyncWithCredentials, s ); }; +const sleep = async () => + new Promise((resolve) => { + setTimeout(resolve, 500); + }); + export const RenderSyncFns = { syncSecrets: async (secretSync: TRenderSyncWithCredentials, secretMap: TSecretMap) => { const renderSecrets = await getRenderEnvironmentSecrets(secretSync); for await (const key of Object.keys(secretMap)) { await putEnvironmentSecret(secretSync, secretMap, key); + await sleep(); } if (secretSync.syncOptions.disableSecretDeletion) return; @@ -106,6 +112,7 @@ export const RenderSyncFns = { if (!secretMap[renderSecret.key]) { await deleteEnvironmentSecret(secretSync, renderSecret); + await sleep(); } } }, @@ -120,6 +127,7 @@ export const RenderSyncFns = { for await (const encryptedSecret of encryptedSecrets) { if (encryptedSecret.key in secretMap) { await deleteEnvironmentSecret(secretSync, encryptedSecret); + await sleep(); } } } diff --git a/docs/mint.json b/docs/mint.json index 5672494b5..b543ee09f 100644 --- a/docs/mint.json +++ b/docs/mint.json @@ -516,11 +516,11 @@ "integrations/app-connections/oci", "integrations/app-connections/oracledb", "integrations/app-connections/postgres", + "integrations/app-connections/render", "integrations/app-connections/teamcity", "integrations/app-connections/terraform-cloud", "integrations/app-connections/vercel", - "integrations/app-connections/windmill", - "integrations/app-connections/render" + "integrations/app-connections/windmill" ] } ] @@ -546,11 +546,11 @@ "integrations/secret-syncs/hashicorp-vault", "integrations/secret-syncs/humanitec", "integrations/secret-syncs/oci-vault", + "integrations/secret-syncs/render", "integrations/secret-syncs/teamcity", "integrations/secret-syncs/terraform-cloud", "integrations/secret-syncs/vercel", - "integrations/secret-syncs/windmill", - "integrations/secret-syncs/render" + "integrations/secret-syncs/windmill" ] } ] @@ -1411,6 +1411,18 @@ "api-reference/endpoints/app-connections/postgres/delete" ] }, + { + "group": "Render", + "pages": [ + "api-reference/endpoints/app-connections/render/list", + "api-reference/endpoints/app-connections/render/available", + "api-reference/endpoints/app-connections/render/get-by-id", + "api-reference/endpoints/app-connections/render/get-by-name", + "api-reference/endpoints/app-connections/render/create", + "api-reference/endpoints/app-connections/render/update", + "api-reference/endpoints/app-connections/render/delete" + ] + }, { "group": "TeamCity", "pages": [ @@ -1458,18 +1470,6 @@ "api-reference/endpoints/app-connections/windmill/update", "api-reference/endpoints/app-connections/windmill/delete" ] - }, - { - "group": "Render", - "pages": [ - "api-reference/endpoints/app-connections/render/list", - "api-reference/endpoints/app-connections/render/available", - "api-reference/endpoints/app-connections/render/get-by-id", - "api-reference/endpoints/app-connections/render/get-by-name", - "api-reference/endpoints/app-connections/render/create", - "api-reference/endpoints/app-connections/render/update", - "api-reference/endpoints/app-connections/render/delete" - ] } ] }, @@ -1669,6 +1669,20 @@ "api-reference/endpoints/secret-syncs/oci-vault/remove-secrets" ] }, + { + "group": "Render", + "pages": [ + "api-reference/endpoints/secret-syncs/render/list", + "api-reference/endpoints/secret-syncs/render/get-by-id", + "api-reference/endpoints/secret-syncs/render/get-by-name", + "api-reference/endpoints/secret-syncs/render/create", + "api-reference/endpoints/secret-syncs/render/update", + "api-reference/endpoints/secret-syncs/render/delete", + "api-reference/endpoints/secret-syncs/render/sync-secrets", + "api-reference/endpoints/secret-syncs/render/import-secrets", + "api-reference/endpoints/secret-syncs/render/remove-secrets" + ] + }, { "group": "TeamCity", "pages": [ @@ -1723,20 +1737,6 @@ "api-reference/endpoints/secret-syncs/windmill/import-secrets", "api-reference/endpoints/secret-syncs/windmill/remove-secrets" ] - }, - { - "group": "Render", - "pages": [ - "api-reference/endpoints/secret-syncs/render/list", - "api-reference/endpoints/secret-syncs/render/get-by-id", - "api-reference/endpoints/secret-syncs/render/get-by-name", - "api-reference/endpoints/secret-syncs/render/create", - "api-reference/endpoints/secret-syncs/render/update", - "api-reference/endpoints/secret-syncs/render/delete", - "api-reference/endpoints/secret-syncs/render/sync-secrets", - "api-reference/endpoints/secret-syncs/render/import-secrets", - "api-reference/endpoints/secret-syncs/render/remove-secrets" - ] } ] },