From 9455993b2ba051d4faf614b5e2cf1264d067d333 Mon Sep 17 00:00:00 2001 From: Carlos Monastyrski Date: Thu, 25 Sep 2025 20:24:16 -0300 Subject: [PATCH 1/2] Fix reviewers email overflowing the component on secret approval page --- .../components/SecretApprovalRequestChanges.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx index 0cce12c47..7c831dc3b 100644 --- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx +++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx @@ -559,7 +559,7 @@ export const SecretApprovalRequestChanges = ({ approvalRequestId, onGoBack }: Pr sideOffset={10} >
-
{requiredApprover?.email}
+
{requiredApprover?.email}
* {!isOrgMembershipActive && (
- {reviewer?.email} + {reviewer?.email} {!isOrgMembershipActive && ( Date: Thu, 25 Sep 2025 20:46:47 -0300 Subject: [PATCH 2/2] Fix review button not showing on long requester email --- .../components/SecretApprovalRequestChanges.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx index 7c831dc3b..edd3d4e22 100644 --- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx +++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChanges.tsx @@ -245,14 +245,14 @@ export const SecretApprovalRequestChanges = ({ approvalRequestId, onGoBack }: Pr : secretApprovalRequestDetails.status}
-
+
{generateCommitText( secretApprovalRequestDetails.commits, secretApprovalRequestDetails.isReplicated )}
-

+

By{" "} {secretApprovalRequestDetails?.committerUser ? ( <>