From 420d71d9233ac759f138cf21826e52d6bca7dcd1 Mon Sep 17 00:00:00 2001 From: Maidul Islam Date: Tue, 9 May 2023 10:23:41 -0400 Subject: [PATCH] add membership validate to folder get --- .../src/controllers/v1/secretsFolderController.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/backend/src/controllers/v1/secretsFolderController.ts b/backend/src/controllers/v1/secretsFolderController.ts index 0783a232b..d20456577 100644 --- a/backend/src/controllers/v1/secretsFolderController.ts +++ b/backend/src/controllers/v1/secretsFolderController.ts @@ -88,10 +88,20 @@ export const deleteFolder = async (req: Request, res: Response) => { res.send() } +// TODO: validate workspace export const getFolderById = async (req: Request, res: Response) => { const { folderId } = req.params - const folder = await Folder.findById(folderId) + const folder = await Folder.findById(folderId); + if (!folder) { + throw BadRequestError({ message: "The folder doesn't exist" }) + } + // check that user is a member of the workspace + await validateMembership({ + userId: req.user._id.toString(), + workspaceId: folder.workspace as any, + acceptedRoles: [ADMIN, MEMBER] + }); res.send({ folder }) } \ No newline at end of file