greptile review fixes

backend/src/server/routes/v1/organization-router.ts

@@ -282,8 +282,12 @@ export const registerOrgRouter = async (server: FastifyZodProvider) => {
         sshProductEnabled: z.boolean().optional(),
         scannerProductEnabled: z.boolean().optional(),
         shareSecretsProductEnabled: z.boolean().optional(),
-        maxSharedSecretLifetime: z.number().optional(),
-        maxSharedSecretViewLimit: z.number().nullable().optional()
+        maxSharedSecretLifetime: z.number().max(2592000, "Max Shared Secret lifetime cannot exceed 30 days").optional(),
+        maxSharedSecretViewLimit: z
+          .number()
+          .max(1000, "Max Shared Secret view count cannot exceed 1000")
+          .nullable()
+          .optional()
       }),
       response: {
         200: z.object({

backend/src/services/secret-sharing/secret-sharing-service.ts

@@ -97,6 +97,7 @@ export const secretSharingServiceFactory = ({
     const expiresAtTimestamp = new Date(expiresAt).getTime();
     const lifetime = expiresAtTimestamp - new Date().getTime();
 
+    // org.maxSharedSecretLifetime is in seconds
     if (org.maxSharedSecretLifetime && lifetime / 1000 > org.maxSharedSecretLifetime) {
       throw new BadRequestError({ message: "Secret lifetime exceeds organization limit" });
     }