Addressed PR comments

backend/src/ee/services/audit-log/audit-log-types.ts

@@ -2569,19 +2569,41 @@ interface GetCertificateTemplateEstConfig {
 
 interface CreateCertificateTemplate {
   type: EventType.CREATE_CERTIFICATE_TEMPLATE;
-  metadata: {
-    certificateTemplateId: string;
-    name: string;
-    projectId: string;
-  };
+  metadata:
+    | {
+        certificateTemplateId: string;
+        name: string;
+        projectId: string;
+      }
+    | {
+        certificateTemplateId: string;
+        caId: string;
+        pkiCollectionId: string;
+        name: string;
+        commonName: string;
+        subjectAlternativeName: string;
+        ttl: string;
+        projectId: string;
+      };
 }
 
 interface UpdateCertificateTemplate {
   type: EventType.UPDATE_CERTIFICATE_TEMPLATE;
-  metadata: {
-    certificateTemplateId: string;
-    name: string;
-  };
+  metadata:
+    | {
+        certificateTemplateId: string;
+        name: string;
+      }
+    | {
+        certificateTemplateId: string;
+        caId: string;
+        pkiCollectionId: string;
+        name: string;
+        commonName: string;
+        subjectAlternativeName: string;
+        ttl: string;
+        projectId: string;
+      };
 }
 
 interface DeleteCertificateTemplate {
@@ -2629,6 +2651,7 @@ interface DeleteCertificateProfile {
   type: EventType.DELETE_CERTIFICATE_PROFILE;
   metadata: {
     certificateProfileId: string;
+    name: string;
   };
 }
 
@@ -2636,6 +2659,7 @@ interface GetCertificateProfile {
   type: EventType.GET_CERTIFICATE_PROFILE;
   metadata: {
     certificateProfileId: string;
+    name: string;
   };
 }
 
@@ -2652,6 +2676,7 @@ interface IssueCertificateFromProfile {
     certificateProfileId: string;
     certificateId: string;
     commonName: string;
+    profileName: string;
   };
 }
 
@@ -2660,6 +2685,8 @@ interface SignCertificateFromProfile {
   metadata: {
     certificateProfileId: string;
     certificateId: string;
+    profileName: string;
+    commonName: string;
   };
 }
 
@@ -2668,7 +2695,7 @@ interface OrderCertificateFromProfile {
   metadata: {
     certificateProfileId: string;
     orderId: string;
-    subjectAlternativeNames: string[];
+    profileName: string;
   };
 }
 

backend/src/ee/services/permission/project-permission.ts

@@ -1119,6 +1119,13 @@ export const ProjectPermissionV2Schema = z.discriminatedUnion("subject", [
       "When specified, only matching conditions will be allowed to access given resource."
     ).optional()
   }),
+  z.object({
+    subject: z.literal(ProjectPermissionSub.CertificateProfiles).describe("The entity this permission pertains to."),
+    inverted: z.boolean().optional().describe("Whether rule allows or forbids."),
+    action: CASL_ACTION_SCHEMA_NATIVE_ENUM(ProjectPermissionCertificateProfileActions).describe(
+      "Describe what action an entity can take."
+    )
+  }),
   ...GeneralPermissionSchema
 ]);