From 435ef4c5dc4fcacfcfa89eee9b750836fc20034a Mon Sep 17 00:00:00 2001 From: Fang-Pen Lin Date: Fri, 21 Nov 2025 18:55:57 -0800 Subject: [PATCH] Better logs --- .../acme/dns-providers/dns-made-easy.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts b/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts index 9356f8c42..6744662f1 100644 --- a/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts +++ b/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts @@ -66,11 +66,12 @@ export const dnsMadeEasyDeleteTxtRecord = async ( credentials: { apiKey, secretKey } } = connection; - logger.info({ hostedZoneId, domain }, "Deleting TXT record for DNS Made Easy"); + logger.info({ zoneId: hostedZoneId, domain }, "Deleting TXT record for DNS Made Easy"); try { const dnsRecords = await listDNSMadeEasyRecords(connection, { zoneId: hostedZoneId, type: "TXT", name: domain }); - if (Array.isArray(dnsRecords) && dnsRecords.length > 0) { + let foundRecord = false; + if (dnsRecords.length > 0) { const recordToDelete = dnsRecords.find( (record) => record.type === "TXT" && record.name === domain && JSON.parse(record.value) === value ); @@ -85,10 +86,12 @@ export const dnsMadeEasyDeleteTxtRecord = async ( } } ); - } else { - logger.warn({ domain, value }, `Record to delete not found for domain: ${domain} and value: ${value}`); + foundRecord = true; } } + if (!foundRecord) { + logger.warn({ zoneId: hostedZoneId, domain, value }, "Record to delete not found"); + } } catch (error) { if (axios.isAxiosError(error)) { const errorMessage =