Add warning on secret deletions where it's being imported by another folder

This commit is contained in:
carlosmonastyrski
2025-04-02 18:58:34 -03:00
parent 13485cecbb
commit 4420985669
6 changed files with 132 additions and 7 deletions
@@ -169,6 +169,27 @@ export const secretImportDALFactory = (db: TDbClient) => {
}
};
const getFolderIsImportedBy = async (secretPath: string, environment: string, tx?: Knex) => {
try {
const docs = await (tx || db.replicaNode())(TableName.SecretImport)
.where({ importPath: secretPath, importEnv: environment })
.join(TableName.SecretFolder, `${TableName.SecretImport}.folderId`, `${TableName.SecretFolder}.id`)
.join(TableName.Environment, `${TableName.SecretFolder}.envId`, `${TableName.Environment}.id`)
.select(
db.ref("name").withSchema(TableName.Environment).as("envName"),
db.ref("name").withSchema(TableName.SecretFolder).as("folderName"),
db.ref("parentId").withSchema(TableName.SecretFolder).as("parentFolderId")
);
return docs.map(({ envName, folderName, parentFolderId }) => ({
envName,
folderName: parentFolderId ? folderName : "Project Root Folder"
}));
} catch (error) {
throw new DatabaseError({ error, name: "get secret imports count" });
}
};
return {
...secretImportOrm,
find,
@@ -176,6 +197,7 @@ export const secretImportDALFactory = (db: TDbClient) => {
findByFolderIds,
findLastImportPosition,
updateAllPosition,
getProjectImportCount
getProjectImportCount,
getFolderIsImportedBy
};
};
@@ -793,6 +793,39 @@ export const secretImportServiceFactory = ({
return secImportsArrays.flat();
};
const getFolderIsImportedBy = async ({
path: secretPath,
environment,
projectId,
actor,
actorId,
actorAuthMethod,
actorOrgId
}: TGetSecretImportsDTO) => {
const { permission } = await permissionService.getProjectPermission({
actor,
actorId,
projectId,
actorAuthMethod,
actorOrgId,
actionProjectType: ActionProjectType.SecretManager
});
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Read,
subject(ProjectPermissionSub.SecretImports, { environment, secretPath })
);
const folder = await folderDAL.findBySecretPath(projectId, environment, secretPath);
if (!folder)
throw new NotFoundError({
message: `Folder with path '${secretPath}' in environment with slug '${environment}' not found`
});
const importedBy = await secretImportDAL.getFolderIsImportedBy(secretPath, folder.envId);
return importedBy;
};
return {
createImport,
updateImport,
@@ -805,6 +838,7 @@ export const secretImportServiceFactory = ({
getProjectImportCount,
fnSecretsFromImports,
getProjectImportMultiEnvCount,
getImportsMultiEnv
getImportsMultiEnv,
getFolderIsImportedBy
};
};