From 44370d49e320284f6210956fc7945c34abba44a6 Mon Sep 17 00:00:00 2001
From: Daniel Hougaard <62331820+DanielHougaard@users.noreply.github.com>
Date: Fri, 5 Apr 2024 18:57:36 -0700
Subject: [PATCH] Fix: Add tooltip for clarity and fix wording

---
 .../SpecificPrivilegeSection.tsx              | 40 +++++++++++--------
 1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/frontend/src/views/Project/MembersPage/components/MemberListTab/MemberRoleForm/SpecificPrivilegeSection.tsx b/frontend/src/views/Project/MembersPage/components/MemberListTab/MemberRoleForm/SpecificPrivilegeSection.tsx
index 2f59e553e..795ccbb24 100644
--- a/frontend/src/views/Project/MembersPage/components/MemberListTab/MemberRoleForm/SpecificPrivilegeSection.tsx
+++ b/frontend/src/views/Project/MembersPage/components/MemberListTab/MemberRoleForm/SpecificPrivilegeSection.tsx
@@ -344,20 +344,27 @@ export const SpecificPrivilegeSecretForm = ({
             render={({ field }) => {
               if (policies) {
                 return (
-                  <FormControl label="Secret Path">
-                    <Select
-                      {...field}
-                      isDisabled={isMemberEditDisabled || !selectablePaths.length}
-                      className="w-48"
-                      onValueChange={(e) => field.onChange(e)}
-                    >
-                      {selectablePaths.map((path) => (
-                        <SelectItem value={path} key={path}>
-                          {path}
-                        </SelectItem>
-                      ))}
-                    </Select>
-                  </FormControl>
+                  <Tooltip
+                    isDisabled={!!selectablePaths.length}
+                    content="The selected environment doesn't have any policies."
+                  >
+                    <div>
+                      <FormControl label="Secret Path">
+                        <Select
+                          {...field}
+                          isDisabled={isMemberEditDisabled || !selectablePaths.length}
+                          className="w-48"
+                          onValueChange={(e) => field.onChange(e)}
+                        >
+                          {selectablePaths.map((path) => (
+                            <SelectItem value={path} key={path}>
+                              {path}
+                            </SelectItem>
+                          ))}
+                        </Select>
+                      </FormControl>
+                    </div>
+                  </Tooltip>
                 );
               }
               return (
@@ -515,8 +522,9 @@ export const SpecificPrivilegeSecretForm = ({
                         );
                       }}
                     >
-                      {temporaryAccessField.isTemporary ? "Restart" : "Grant"}
+                      {temporaryAccessField.isTemporary && !policies ? "Restart" : "Grant"}
                     </Button>
+
                     {temporaryAccessField.isTemporary && (
                       <Button
                         size="xs"
@@ -528,7 +536,7 @@ export const SpecificPrivilegeSecretForm = ({
                           });
                         }}
                       >
-                        Revoke Access
+                        Cancel
                       </Button>
                     )}
                   </div>