fix: use put instead of post and improve var naming

This commit is contained in:
Scott Wilson
2024-10-16 11:05:53 -07:00
parent 8c4a26b0e2
commit 44544e0491
3 changed files with 3 additions and 4 deletions
@@ -38,7 +38,7 @@ export const registerExternalGroupOrgRoleMappingRouter = async (server: FastifyZ
// update mappings for current org
server.route({
method: "POST", // using post since this endpoint creates, updates and deletes mappings
method: "PUT", // using put since this endpoint creates, updates and deletes mappings
url: "/",
config: {
rateLimit: writeLimit
+1 -2
View File
@@ -5,8 +5,7 @@ import { TOrgRoleDALFactory } from "@app/services/org/org-role-dal";
const RESERVED_ORG_ROLE_SLUGS = Object.values(OrgMembershipRole).filter((role) => role !== "custom");
export const isCustomOrgRole = (membershipSlug: string) =>
!RESERVED_ORG_ROLE_SLUGS.includes(membershipSlug as OrgMembershipRole);
export const isCustomOrgRole = (roleSlug: string) => !RESERVED_ORG_ROLE_SLUGS.includes(roleSlug as OrgMembershipRole);
// this is only for updating an org
export const getDefaultOrgMembershipRoleForUpdateOrg = async ({