awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-05 13:26:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use put instead of post and improve var naming

Browse Source
This commit is contained in:
Scott Wilson
2024-10-16 11:05:53 -07:00
parent 8c4a26b0e2
commit 44544e0491
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/server/routes/v1/external-group-org-role-mapping-router.ts
+1 -1
View File
@@ -38,7 +38,7 @@ export const registerExternalGroupOrgRoleMappingRouter = async (server: FastifyZ
// update mappings for current org // update mappings for current org
server.route({ server.route({
method: "POST", // using post since this endpoint creates, updates and deletes mappings method: "PUT", // using put since this endpoint creates, updates and deletes mappings
url: "/", url: "/",
config: { config: {
rateLimit: writeLimit rateLimit: writeLimit
backend/src/services/org/org-role-fns.ts
+1 -2
View File
@@ -5,8 +5,7 @@ import { TOrgRoleDALFactory } from "@app/services/org/org-role-dal";
const RESERVED_ORG_ROLE_SLUGS = Object.values(OrgMembershipRole).filter((role) => role !== "custom"); const RESERVED_ORG_ROLE_SLUGS = Object.values(OrgMembershipRole).filter((role) => role !== "custom");
export const isCustomOrgRole = (membershipSlug: string) => export const isCustomOrgRole = (roleSlug: string) => !RESERVED_ORG_ROLE_SLUGS.includes(roleSlug as OrgMembershipRole);
!RESERVED_ORG_ROLE_SLUGS.includes(membershipSlug as OrgMembershipRole);
// this is only for updating an org // this is only for updating an org
export const getDefaultOrgMembershipRoleForUpdateOrg = async ({ export const getDefaultOrgMembershipRoleForUpdateOrg = async ({
frontend/src/hooks/api/externalGroupOrgRoleMappings/mutations.tsx
+1 -1
View File
@@ -8,7 +8,7 @@ export const useUpdateExternalGroupOrgRoleMappings = () => {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
return useMutation({ return useMutation({
mutationFn: async (payload: TSyncExternalGroupOrgRoleMappingsDTO) => { mutationFn: async (payload: TSyncExternalGroupOrgRoleMappingsDTO) => {
const { data } = await apiRequest.post("/api/v1/external-group-mappings", payload); const { data } = await apiRequest.put("/api/v1/external-group-mappings", payload);
return data; return data;
}, },