awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-08 13:28:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: added handling for empty values

Browse Source
This commit is contained in:
Sheen Capadngan
2025-01-29 01:41:59 +08:00
parent 23f605bda7
commit 457056b600
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/secret-sync/gcp/gcp-sync-fns.ts
+7 -1
View File
@@ -95,6 +95,12 @@ export const GcpSyncFns = {
for await (const key of Object.keys(secretMap)) { for await (const key of Object.keys(secretMap)) {
try { try {
// we do not process secrets with no value because GCP secret manager does not allow it
if (!secretMap[key].value) {
// eslint-disable-next-line no-continue
continue;
}
if (!(key in gcpSecrets)) { if (!(key in gcpSecrets)) {
// case: create secret // case: create secret
await request.post( await request.post(
@@ -140,7 +146,7 @@ export const GcpSyncFns = {
for await (const key of Object.keys(gcpSecrets)) { for await (const key of Object.keys(gcpSecrets)) {
try { try {
if (!(key in secretMap)) { if (!(key in secretMap) || !secretMap[key].value) {
// case: delete secret // case: delete secret
await request.delete( await request.delete(
`${IntegrationUrls.GCP_SECRET_MANAGER_URL}/v1/projects/${destinationConfig.projectId}/secrets/${key}`, `${IntegrationUrls.GCP_SECRET_MANAGER_URL}/v1/projects/${destinationConfig.projectId}/secrets/${key}`,