From 4576fdfdbb7a216adc38c7419bcf7b1165753b88 Mon Sep 17 00:00:00 2001 From: Piyush Gupta Date: Wed, 8 Oct 2025 23:24:12 +0530 Subject: [PATCH] fix: greptile review comments --- backend/src/services/identity/identity-dal.ts | 2 +- .../components/MachineIdentitiesTable.tsx | 38 +++++++++---------- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/backend/src/services/identity/identity-dal.ts b/backend/src/services/identity/identity-dal.ts index 596601703..c23e650d0 100644 --- a/backend/src/services/identity/identity-dal.ts +++ b/backend/src/services/identity/identity-dal.ts @@ -69,7 +69,7 @@ export const identityDALFactory = (db: TDbClient) => { .replicaNode()(TableName.Identity) .where((qb) => { if (searchTerm) { - void qb.whereILike(`${TableName.Identity}.name`, `%${searchTerm}%`); + void qb.whereILike(`name`, `%${searchTerm}%`); } }) .count("*") diff --git a/frontend/src/pages/admin/ResourceOverviewPage/components/MachineIdentitiesTable.tsx b/frontend/src/pages/admin/ResourceOverviewPage/components/MachineIdentitiesTable.tsx index 8cfc697c0..5417636ea 100644 --- a/frontend/src/pages/admin/ResourceOverviewPage/components/MachineIdentitiesTable.tsx +++ b/frontend/src/pages/admin/ResourceOverviewPage/components/MachineIdentitiesTable.tsx @@ -132,26 +132,24 @@ const IdentityPanelTable = ({ - {isInstanceAdmin && ( - { - e.stopPropagation(); - handlePopUpOpen("removeServerAdmin", { name, id }); - }} - icon={ -
- - -
- } - > - Remove Server Admin -
- )} + { + e.stopPropagation(); + handlePopUpOpen("removeServerAdmin", { name, id }); + }} + icon={ +
+ + +
+ } + > + Remove Server Admin +