feature: secret scanning pt2 and address initial feedback

backend/src/server/plugins/secret-scanner-v2.ts

@@ -12,7 +12,7 @@ export const registerSecretScanningV2Webhooks = async (server: FastifyZodProvide
       const { payload } = context;
       const { installation } = payload;
 
-      await server.services.secretScanningV2.github.handleInstallationDeleted(installation.id);
+      await server.services.secretScanningV2.github.handleInstallationDeletedEvent(installation.id);
     });
 
     app.on("installation", async (context) => {
@@ -28,6 +28,11 @@ export const registerSecretScanningV2Webhooks = async (server: FastifyZodProvide
 
   const appCfg = getConfig();
 
+  if (!appCfg.isSecretScanningV2Configured) {
+    logger.info("Secret Scanning V2 is not configured. Skipping registration of secret scanning v2 webhooks.");
+    return;
+  }
+
   const probot = new Probot({
     appId: appCfg.INF_APP_CONNECTION_GITHUB_RADAR_APP_ID as string,
     privateKey: appCfg.INF_APP_CONNECTION_GITHUB_RADAR_APP_PRIVATE_KEY as string,
@@ -36,6 +41,7 @@ export const registerSecretScanningV2Webhooks = async (server: FastifyZodProvide
 
   await probot.load(probotApp);
 
+  // github push event webhook
   server.route({
     method: "POST",
     url: "/github",

backend/src/server/routes/index.ts

@@ -1703,22 +1703,20 @@ export const registerRoutes = async (
   });
 
   const secretScanningV2Queue = await secretScanningV2QueueServiceFactory({
+    auditLogService,
     secretScanningV2DAL,
     queueService,
-    // projectDAL,
-    // projectMembershipDAL,
-    // smtpService,
-    kmsService
+    projectDAL,
+    projectMembershipDAL,
+    smtpService,
+    kmsService,
+    keyStore
   });
 
   const secretScanningV2Service = secretScanningV2ServiceFactory({
-    // appConnectionDAL,
     permissionService,
     appConnectionService,
     licenseService,
-    // auditLogService,
-    // keyStore,
-    // queueService,
     secretScanningV2DAL,
     secretScanningV2Queue,
     kmsService