From 4a3143e68996a58727ecb82cd534d777808a87ec Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Mon, 11 Nov 2024 14:04:36 -0800 Subject: [PATCH] fix: correct unique secret check to account for env and path --- .../services/secret-v2-bridge/secret-v2-bridge-service.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts index 6b9740ffd..d49a183ae 100644 --- a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts +++ b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts @@ -150,7 +150,11 @@ export const secretV2BridgeServiceFactory = ({ } }); - if (new Set(referredSecrets.map((sec) => sec.key)).size !== new Set(references.map((sec) => sec.secretKey)).size) + if ( + referredSecrets.length !== + new Set(references.map(({ secretKey, secretPath, environment }) => `${secretKey}.${secretPath}.${environment}`)) + .size // only count unique references + ) throw new BadRequestError({ message: `Referenced secret(s) not found: ${diff( references.map((el) => el.secretKey),