awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 20:27:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Greptile review fixes

Browse Source
This commit is contained in:
x032205
2025-06-09 12:10:47 -04:00
parent c06bbf0b9b
commit 4c6cca0864
3 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/app-connections/oracledb/oracledb-connection-schemas.ts
+5 -7
View File
@@ -11,19 +11,19 @@ import { BaseSqlUsernameAndPasswordConnectionSchema } from "@app/services/app-co
import { OracleDBConnectionMethod } from "./oracledb-connection-enums"; import { OracleDBConnectionMethod } from "./oracledb-connection-enums";
export const OracleDBConnectionAccessTokenCredentialsSchema = BaseSqlUsernameAndPasswordConnectionSchema; export const OracleDBConnectionCredentialsSchema = BaseSqlUsernameAndPasswordConnectionSchema;
const BaseOracleDBConnectionSchema = BaseAppConnectionSchema.extend({ app: z.literal(AppConnection.OracleDB) }); const BaseOracleDBConnectionSchema = BaseAppConnectionSchema.extend({ app: z.literal(AppConnection.OracleDB) });
export const OracleDBConnectionSchema = BaseOracleDBConnectionSchema.extend({ export const OracleDBConnectionSchema = BaseOracleDBConnectionSchema.extend({
method: z.literal(OracleDBConnectionMethod.UsernameAndPassword), method: z.literal(OracleDBConnectionMethod.UsernameAndPassword),
credentials: OracleDBConnectionAccessTokenCredentialsSchema credentials: OracleDBConnectionCredentialsSchema
}); });
export const SanitizedOracleDBConnectionSchema = z.discriminatedUnion("method", [ export const SanitizedOracleDBConnectionSchema = z.discriminatedUnion("method", [
BaseOracleDBConnectionSchema.extend({ BaseOracleDBConnectionSchema.extend({
method: z.literal(OracleDBConnectionMethod.UsernameAndPassword), method: z.literal(OracleDBConnectionMethod.UsernameAndPassword),
credentials: OracleDBConnectionAccessTokenCredentialsSchema.pick({ credentials: OracleDBConnectionCredentialsSchema.pick({
host: true, host: true,
database: true, database: true,
port: true, port: true,
@@ -40,9 +40,7 @@ export const ValidateOracleDBConnectionCredentialsSchema = z.discriminatedUnion(
method: z method: z
.literal(OracleDBConnectionMethod.UsernameAndPassword) .literal(OracleDBConnectionMethod.UsernameAndPassword)
.describe(AppConnections.CREATE(AppConnection.OracleDB).method), .describe(AppConnections.CREATE(AppConnection.OracleDB).method),
credentials: OracleDBConnectionAccessTokenCredentialsSchema.describe( credentials: OracleDBConnectionCredentialsSchema.describe(AppConnections.CREATE(AppConnection.OracleDB).credentials)
AppConnections.CREATE(AppConnection.OracleDB).credentials
)
}) })
]); ]);
@@ -52,7 +50,7 @@ export const CreateOracleDBConnectionSchema = ValidateOracleDBConnectionCredenti
export const UpdateOracleDBConnectionSchema = z export const UpdateOracleDBConnectionSchema = z
.object({ .object({
credentials: OracleDBConnectionAccessTokenCredentialsSchema.optional().describe( credentials: OracleDBConnectionCredentialsSchema.optional().describe(
AppConnections.UPDATE(AppConnection.OracleDB).credentials AppConnections.UPDATE(AppConnection.OracleDB).credentials
) )
}) })
backend/src/ee/services/secret-rotation-v2/secret-rotation-v2-union-schema.ts
+2 -3
View File
@@ -1,15 +1,14 @@
import { z } from "zod"; import { z } from "zod";
import { Auth0ClientSecretRotationSchema } from "@app/ee/services/secret-rotation-v2/auth0-client-secret"; import { Auth0ClientSecretRotationSchema } from "@app/ee/services/secret-rotation-v2/auth0-client-secret";
import { AwsIamUserSecretRotationSchema } from "@app/ee/services/secret-rotation-v2/aws-iam-user-secret";
import { AzureClientSecretRotationSchema } from "@app/ee/services/secret-rotation-v2/azure-client-secret"; import { AzureClientSecretRotationSchema } from "@app/ee/services/secret-rotation-v2/azure-client-secret";
import { LdapPasswordRotationSchema } from "@app/ee/services/secret-rotation-v2/ldap-password"; import { LdapPasswordRotationSchema } from "@app/ee/services/secret-rotation-v2/ldap-password";
import { MsSqlCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/mssql-credentials"; import { MsSqlCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/mssql-credentials";
import { MySqlCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/mysql-credentials"; import { MySqlCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/mysql-credentials";
import { OracleDBCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/oracledb-credentials";
import { PostgresCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/postgres-credentials"; import { PostgresCredentialsRotationSchema } from "@app/ee/services/secret-rotation-v2/postgres-credentials";
import { AwsIamUserSecretRotationSchema } from "./aws-iam-user-secret";
import { OracleDBCredentialsRotationSchema } from "./oracledb-credentials";
export const SecretRotationV2Schema = z.discriminatedUnion("type", [ export const SecretRotationV2Schema = z.discriminatedUnion("type", [
PostgresCredentialsRotationSchema, PostgresCredentialsRotationSchema,
MsSqlCredentialsRotationSchema, MsSqlCredentialsRotationSchema,
backend/src/ee/services/secret-rotation-v2/shared/sql-credentials/sql-credentials-rotation-types.ts
+2 -3
View File
@@ -2,10 +2,9 @@ import { z } from "zod";
import { TMsSqlCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/mssql-credentials"; import { TMsSqlCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/mssql-credentials";
import { TMySqlCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/mysql-credentials"; import { TMySqlCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/mysql-credentials";
import { TOracleDBCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/oracledb-credentials";
import { TPostgresCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/postgres-credentials"; import { TPostgresCredentialsRotationWithConnection } from "@app/ee/services/secret-rotation-v2/postgres-credentials";
import { SqlCredentialsRotationGeneratedCredentialsSchema } from "@app/ee/services/secret-rotation-v2/shared/sql-credentials/sql-credentials-rotation-schemas";
import { TOracleDBCredentialsRotationWithConnection } from "../../oracledb-credentials";
import { SqlCredentialsRotationGeneratedCredentialsSchema } from "./sql-credentials-rotation-schemas";
export type TSqlCredentialsRotationWithConnection = export type TSqlCredentialsRotationWithConnection =
| TPostgresCredentialsRotationWithConnection | TPostgresCredentialsRotationWithConnection