fix: address runtime error for secret approval requests

This commit is contained in:
Sheen Capadngan
2025-04-11 01:26:56 +08:00
parent 06cd496ab3
commit 4d4547015e
@@ -262,13 +262,14 @@ export const secretApprovalRequestServiceFactory = ({
id: el.id, id: el.id,
version: el.version, version: el.version,
secretMetadata: el.secretMetadata as ResourceMetadataDTO, secretMetadata: el.secretMetadata as ResourceMetadataDTO,
isRotatedSecret: el.secret.isRotatedSecret, isRotatedSecret: el.secret?.isRotatedSecret ?? false,
// eslint-disable-next-line no-nested-ternary secretValue:
secretValue: el.secret.isRotatedSecret // eslint-disable-next-line no-nested-ternary
? undefined el.secret && el.secret.isRotatedSecret
: el.encryptedValue ? undefined
? secretManagerDecryptor({ cipherTextBlob: el.encryptedValue }).toString() : el.encryptedValue
: "", ? secretManagerDecryptor({ cipherTextBlob: el.encryptedValue }).toString()
: "",
secretComment: el.encryptedComment secretComment: el.encryptedComment
? secretManagerDecryptor({ cipherTextBlob: el.encryptedComment }).toString() ? secretManagerDecryptor({ cipherTextBlob: el.encryptedComment }).toString()
: "", : "",
@@ -615,7 +616,7 @@ export const secretApprovalRequestServiceFactory = ({
tx, tx,
inputSecrets: secretUpdationCommits.map((el) => { inputSecrets: secretUpdationCommits.map((el) => {
const encryptedValue = const encryptedValue =
!el.secret.isRotatedSecret && typeof el.encryptedValue !== "undefined" !el.secret?.isRotatedSecret && typeof el.encryptedValue !== "undefined"
? { ? {
encryptedValue: el.encryptedValue as Buffer, encryptedValue: el.encryptedValue as Buffer,
references: el.encryptedValue references: el.encryptedValue