From 4d4b4c13c39afe10c3e27288a9c2e1e631f555e0 Mon Sep 17 00:00:00 2001
From: Carlos Monastyrski <charly.monastyrski@gmail.com>
Date: Mon, 1 Sep 2025 23:11:00 -0300
Subject: [PATCH] Address greptile comments

---
 docs/integrations/dynamic-secrets.mdx          |  2 +-
 docs/snippets/AppConnectionsBrowser.jsx        | 13 ++++++++++---
 docs/snippets/DynamicSecretsBrowser.jsx        | 15 ++++++++++++---
 docs/snippets/FrameworkIntegrationsBrowser.jsx | 13 ++++++++++---
 docs/snippets/MachineAuthenticationBrowser.jsx | 17 ++++++++++++-----
 docs/snippets/RotationsBrowser.jsx             | 10 +++++++---
 docs/snippets/SecretSyncsBrowser.jsx           | 13 ++++++++++---
 docs/snippets/UserAuthenticationBrowser.jsx    | 11 ++++++++---
 8 files changed, 70 insertions(+), 24 deletions(-)

diff --git a/docs/integrations/dynamic-secrets.mdx b/docs/integrations/dynamic-secrets.mdx
index e2b5f0a46..84ff43ab5 100644
--- a/docs/integrations/dynamic-secrets.mdx
+++ b/docs/integrations/dynamic-secrets.mdx
@@ -6,4 +6,4 @@ description: "Browse and search through all available dynamic secrets for Infisi
 
 import { DynamicSecretsBrowser } from "/snippets/DynamicSecretsBrowser.jsx";
 
-<DynamicSecretsBrowser />
\ No newline at end of file
+<DynamicSecretsBrowser />
diff --git a/docs/snippets/AppConnectionsBrowser.jsx b/docs/snippets/AppConnectionsBrowser.jsx
index 6b9a981dc..73e88fd01 100644
--- a/docs/snippets/AppConnectionsBrowser.jsx
+++ b/docs/snippets/AppConnectionsBrowser.jsx
@@ -63,7 +63,7 @@ export const AppConnectionsBrowser = () => {
     }
 
     return filtered;
-  }, [connections, searchTerm, selectedCategory]);
+  }, [searchTerm, selectedCategory]);
 
   return (
     <div className="max-w-none">
@@ -118,7 +118,7 @@ export const AppConnectionsBrowser = () => {
         <div className="space-y-4">
           {filteredConnections.map((connection, index) => (
             <a
-              key={`${connection.slug}-${index}`}
+              key={connection.slug}
               href={connection.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -138,7 +138,14 @@ export const AppConnectionsBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-8">
+          <p className="text-gray-500">No app connections found matching your criteria.</p>
+          {searchTerm && (
+            <p className="text-gray-400 text-sm mt-2">Try adjusting your search terms or category filter.</p>
+          )}
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file
diff --git a/docs/snippets/DynamicSecretsBrowser.jsx b/docs/snippets/DynamicSecretsBrowser.jsx
index 46f8585c9..3de248170 100644
--- a/docs/snippets/DynamicSecretsBrowser.jsx
+++ b/docs/snippets/DynamicSecretsBrowser.jsx
@@ -48,7 +48,7 @@ export const DynamicSecretsBrowser = () => {
     }
 
     return filtered;
-  }, [dynamicSecrets, searchTerm, selectedCategory]);
+  }, [searchTerm, selectedCategory]);
 
   return (
     <div className="max-w-none">
@@ -103,7 +103,7 @@ export const DynamicSecretsBrowser = () => {
         <div className="space-y-4">
           {filteredDynamicSecrets.map((secret, index) => (
             <a
-              key={`${secret.slug}-${index}`}
+              key={secret.slug}
               href={secret.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -123,7 +123,16 @@ export const DynamicSecretsBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-8">
+          <div className="text-gray-500 text-sm">
+            <p>No dynamic secrets found</p>
+            {searchTerm && (
+              <p className="mt-1">Try adjusting your search terms or filters</p>
+            )}
+          </div>
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file
diff --git a/docs/snippets/FrameworkIntegrationsBrowser.jsx b/docs/snippets/FrameworkIntegrationsBrowser.jsx
index 0644d0826..2ee650f7d 100644
--- a/docs/snippets/FrameworkIntegrationsBrowser.jsx
+++ b/docs/snippets/FrameworkIntegrationsBrowser.jsx
@@ -43,7 +43,7 @@ export const FrameworkIntegrationsBrowser = () => {
     }
 
     return filtered;
-  }, [integrations, searchTerm, selectedCategory]);
+  }, [searchTerm, selectedCategory]);
 
   return (
     <div className="max-w-none">
@@ -98,7 +98,7 @@ export const FrameworkIntegrationsBrowser = () => {
         <div className="space-y-4">
           {filteredIntegrations.map((integration, index) => (
             <a
-              key={`${integration.slug}-${index}`}
+              key={integration.slug}
               href={integration.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -118,7 +118,14 @@ export const FrameworkIntegrationsBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-8">
+          <p className="text-gray-500">No framework integrations found matching your criteria.</p>
+          {searchTerm && (
+            <p className="text-gray-400 text-sm mt-2">Try adjusting your search terms or category filter.</p>
+          )}
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file
diff --git a/docs/snippets/MachineAuthenticationBrowser.jsx b/docs/snippets/MachineAuthenticationBrowser.jsx
index cf1a5a860..e6b5aa699 100644
--- a/docs/snippets/MachineAuthenticationBrowser.jsx
+++ b/docs/snippets/MachineAuthenticationBrowser.jsx
@@ -21,8 +21,8 @@ export const MachineAuthenticationBrowser = () => {
     {"name": "OIDC Auth (Terraform Cloud)", "slug": "oidc-auth-terraform", "path": "/documentation/platform/identities/oidc-auth/terraform-cloud", "description": "Learn how to authenticate Terraform Cloud using OIDC.", "category": "Token-based"},
     {"name": "OIDC Auth (SPIRE)", "slug": "oidc-auth-spire", "path": "/documentation/platform/identities/oidc-auth/spire", "description": "Learn how to authenticate workloads using SPIFFE/SPIRE OIDC.", "category": "Token-based"},
     {"name": "TLS Certificate Auth", "slug": "tls-cert-auth", "path": "/documentation/platform/identities/tls-cert-auth", "description": "Learn how to authenticate machines using TLS client certificates.", "category": "Certificate-based"},
-    {"name": "LDAP Auth (General)", "slug": "ldap-auth-general", "path": "/documentation/platform/identities/ldap-auth/general", "description": "Learn how to authenticate machines using LDAP credentials.", "category": "Certificate-based"},
-    {"name": "LDAP Auth (JumpCloud)", "slug": "ldap-auth-jumpcloud", "path": "/documentation/platform/identities/ldap-auth/jumpcloud", "description": "Learn how to authenticate machines using JumpCloud LDAP.", "category": "Certificate-based"}
+    {"name": "LDAP Auth (General)", "slug": "ldap-auth-general", "path": "/documentation/platform/identities/ldap-auth/general", "description": "Learn how to authenticate machines using LDAP credentials.", "category": "Directory-based"},
+    {"name": "LDAP Auth (JumpCloud)", "slug": "ldap-auth-jumpcloud", "path": "/documentation/platform/identities/ldap-auth/jumpcloud", "description": "Learn how to authenticate machines using JumpCloud LDAP.", "category": "Directory-based"}
   ];
 
   const filteredAuthMethods = useMemo(() => {
@@ -32,7 +32,7 @@ export const MachineAuthenticationBrowser = () => {
       method.name.toLowerCase().includes(searchTerm.toLowerCase()) ||
       method.description.toLowerCase().includes(searchTerm.toLowerCase())
     );
-  }, [authMethods, searchTerm]);
+  }, [searchTerm]);
 
   return (
     <div className="max-w-none">
@@ -67,7 +67,7 @@ export const MachineAuthenticationBrowser = () => {
         <div className="space-y-4">
           {filteredAuthMethods.map((method, index) => (
             <a
-              key={`${method.slug}-${index}`}
+              key={method.slug}
               href={method.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -87,7 +87,14 @@ export const MachineAuthenticationBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-8">
+          <p className="text-gray-500">No authentication methods found matching your criteria.</p>
+          {searchTerm && (
+            <p className="text-gray-400 text-sm mt-2">Try adjusting your search terms.</p>
+          )}
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file
diff --git a/docs/snippets/RotationsBrowser.jsx b/docs/snippets/RotationsBrowser.jsx
index 0077e0798..988c217bc 100644
--- a/docs/snippets/RotationsBrowser.jsx
+++ b/docs/snippets/RotationsBrowser.jsx
@@ -35,7 +35,7 @@ export const RotationsBrowser = () => {
     }
 
     return filtered;
-  }, [rotations, searchTerm, selectedCategory]);
+  }, [searchTerm, selectedCategory]);
 
   return (
     <div className="max-w-none">
@@ -90,7 +90,7 @@ export const RotationsBrowser = () => {
         <div className="space-y-4">
           {filteredRotations.map((rotation, index) => (
             <a
-              key={`${rotation.slug}-${index}`}
+              key={rotation.slug}
               href={rotation.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -110,7 +110,11 @@ export const RotationsBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-8">
+          <p className="text-gray-500">No secret rotations found matching your criteria.</p>
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file
diff --git a/docs/snippets/SecretSyncsBrowser.jsx b/docs/snippets/SecretSyncsBrowser.jsx
index 5ae9f9c7a..e49765940 100644
--- a/docs/snippets/SecretSyncsBrowser.jsx
+++ b/docs/snippets/SecretSyncsBrowser.jsx
@@ -53,7 +53,7 @@ export const SecretSyncsBrowser = () => {
     }
 
     return filtered;
-  }, [syncs, searchTerm, selectedCategory]);
+  }, [searchTerm, selectedCategory]);
 
   return (
     <div className="max-w-none">
@@ -108,7 +108,7 @@ export const SecretSyncsBrowser = () => {
         <div className="space-y-4">
           {filteredSyncs.map((sync, index) => (
             <a
-              key={`${sync.slug}-${index}`}
+              key={sync.slug}
               href={sync.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -128,7 +128,14 @@ export const SecretSyncsBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-8">
+          <p className="text-gray-500">No secret syncs found matching your criteria.</p>
+          {searchTerm && (
+            <p className="text-gray-400 text-sm mt-2">Try adjusting your search terms or category filter.</p>
+          )}
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file
diff --git a/docs/snippets/UserAuthenticationBrowser.jsx b/docs/snippets/UserAuthenticationBrowser.jsx
index 82dbd5b09..c8feacc1b 100644
--- a/docs/snippets/UserAuthenticationBrowser.jsx
+++ b/docs/snippets/UserAuthenticationBrowser.jsx
@@ -43,7 +43,7 @@ export const UserAuthenticationBrowser = () => {
     }
 
     return filtered;
-  }, [authMethods, searchTerm, selectedCategory]);
+  }, [searchTerm, selectedCategory]);
 
   return (
     <div className="max-w-none">
@@ -98,7 +98,7 @@ export const UserAuthenticationBrowser = () => {
         <div className="space-y-4">
           {filteredAuthMethods.map((method, index) => (
             <a
-              key={`${method.slug}-${index}`}
+              key={method.slug}
               href={method.path}
               className="group block px-4 py-3 border border-gray-200 rounded-xl hover:border-yellow-200 hover:bg-yellow-50/50 hover:shadow-sm transition-all duration-200 bg-white shadow-sm"
             >
@@ -118,7 +118,12 @@ export const UserAuthenticationBrowser = () => {
             </a>
           ))}
         </div>
-      ) : null}
+      ) : (
+        <div className="text-center py-12">
+          <p className="text-gray-500 text-base">No authentication methods found matching your criteria.</p>
+          <p className="text-gray-400 text-sm mt-2">Try adjusting your search terms or category filter.</p>
+        </div>
+      )}
     </div>
   );
 };
\ No newline at end of file