misc: addressed review comments

This commit is contained in:
Sheen Capadngan
2024-10-24 19:20:21 +08:00
parent e1dbe769a8
commit 4db79edf19
4 changed files with 12 additions and 1 deletions
@@ -5,7 +5,7 @@ description: "How to sync secrets from Infisical to Azure App Configuration"
<Tabs> <Tabs>
<Tab title="Usage"> <Tab title="Usage">
Prerequisites: **Prerequisites:**
- Set up and add envars to [Infisical Cloud](https://app.infisical.com). - Set up and add envars to [Infisical Cloud](https://app.infisical.com).
- Set up Azure and have an existing App Configuration instance. - Set up Azure and have an existing App Configuration instance.
@@ -37,6 +37,10 @@ description: "How to sync secrets from Infisical to Azure App Configuration"
Using the Azure App Configuration integration on a self-hosted instance of Infisical requires configuring an application in Azure Using the Azure App Configuration integration on a self-hosted instance of Infisical requires configuring an application in Azure
and registering your instance with it. and registering your instance with it.
**Prerequisites:**
- Set up Azure and have an existing App Configuration instance.
<Steps> <Steps>
<Step title="Create an application in Azure"> <Step title="Create an application in Azure">
Navigate to Azure Active Directory > App registrations to create a new application. Navigate to Azure Active Directory > App registrations to create a new application.
@@ -48,6 +52,9 @@ description: "How to sync secrets from Infisical to Azure App Configuration"
![integrations Azure app config](../../images/integrations/azure-app-configuration/config-new-app.png) ![integrations Azure app config](../../images/integrations/azure-app-configuration/config-new-app.png)
Create the application. As part of the form, set the **Redirect URI** to `https://your-domain.com/integrations/azure-app-configuration/oauth2/callback`. Create the application. As part of the form, set the **Redirect URI** to `https://your-domain.com/integrations/azure-app-configuration/oauth2/callback`.
<Tip>
The domain you defined in the Redirect URI should be equivalent to the `SITE_URL` configured in your Infisical instance.
</Tip>
![integrations Azure app config](../../images/integrations/azure-app-configuration/app-registration-redirect.png) ![integrations Azure app config](../../images/integrations/azure-app-configuration/app-registration-redirect.png)
@@ -46,6 +46,7 @@ export type TIntegration = {
secretSuffix?: string; secretSuffix?: string;
secretPrefix?: string; secretPrefix?: string;
syncBehavior?: IntegrationSyncBehavior; syncBehavior?: IntegrationSyncBehavior;
initialSyncBehavior: IntegrationSyncBehavior;
mappingBehavior?: IntegrationMappingBehavior; mappingBehavior?: IntegrationMappingBehavior;
scope: string; scope: string;
org: string; org: string;
@@ -166,6 +166,7 @@ export default function AzureAppConfigurationCreateIntegration() {
> >
<Select <Select
className="w-full border border-mineshaft-500" className="w-full border border-mineshaft-500"
dropdownContainerClassName="max-w-full"
value={field.value} value={field.value}
onValueChange={(val) => { onValueChange={(val) => {
field.onChange(val); field.onChange(val);
@@ -230,6 +231,7 @@ export default function AzureAppConfigurationCreateIntegration() {
defaultValue={field.value} defaultValue={field.value}
onValueChange={(e) => onChange(e)} onValueChange={(e) => onChange(e)}
className="w-full border border-mineshaft-500" className="w-full border border-mineshaft-500"
dropdownContainerClassName="max-w-full"
> >
{initialSyncBehaviors.map((b) => { {initialSyncBehaviors.map((b) => {
return ( return (
@@ -17,6 +17,7 @@ const metadataMappings: Record<keyof NonNullable<TIntegrationWithEnv["metadata"]
secretSuffix: "Secret Suffix", secretSuffix: "Secret Suffix",
secretPrefix: "Secret Prefix", secretPrefix: "Secret Prefix",
syncBehavior: "Secrets Sync behavior", syncBehavior: "Secrets Sync behavior",
initialSyncBehavior: "Initial Sync Behavior",
mappingBehavior: "Secrets Mapping Behavior", mappingBehavior: "Secrets Mapping Behavior",
scope: "Scope", scope: "Scope",
org: "Organization", org: "Organization",